From: Jeff Garzik <jgarzik@pobox.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers
Date: Thu, 25 Jan 2007 18:36:18 -0500 [thread overview]
Message-ID: <45B93EF2.3030706@pobox.com> (raw)
In-Reply-To: <20070125150905.652f9ce2@localhost.localdomain>
Alan wrote:
> Fixes bogus accesses to ports 0-15 with a non DMA capable controller.
> This I think should go in for 2.6.20
applied to #upstream-fixes, but it's a hack based on a misunderstanding.
See comments below for further work needed.
> Arguably it shouldn't be called for PIO commands at all but thats a
> matter for Jeff to decide
You are getting misled by the function name.
ata_bmdma_post_internal_cmd() is the common ->post_internal_cmd() hook
for BMDMA-like (SFF-like) controllers. ->post_internal_cmd() hook will
always be called, for all commands, when present.
For PIO-only controllers, simply delete the post_internal_cmd hook from
that specific driver's ata_port_operations. (assuming no other cleanup
is needed)
For other SFF controllers, perhaps ata_bmdma_post_internal_cmd() should
be revised to check the taskfile protocol (PIO, DMA, ...)?
I leave that up to your judgement, to figure out what's best. I
certainly AGREE that an unconditional ata_bmdma_stop() for all commands,
for all taskfile protocols, sounds wrong.
Jeff
prev parent reply other threads:[~2007-01-25 23:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 15:09 [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers Alan
2007-01-25 16:14 ` David Woodhouse
2007-01-25 16:17 ` Jeff Garzik
2007-01-25 16:19 ` David Woodhouse
2007-01-25 16:22 ` Russell King
2007-01-25 16:26 ` David Woodhouse
2007-01-25 17:27 ` Alan
2007-01-25 17:56 ` Linus Torvalds
2007-01-26 0:23 ` David Woodhouse
2007-01-26 1:28 ` Linus Torvalds
2007-01-26 1:45 ` Jeff Garzik
2007-01-26 2:01 ` Linus Torvalds
2007-01-26 2:11 ` Jeff Garzik
2007-01-26 10:37 ` Alan
2007-01-28 23:01 ` Benjamin Herrenschmidt
2007-01-28 22:57 ` Benjamin Herrenschmidt
2007-01-26 2:23 ` David Woodhouse
2007-01-26 2:58 ` Linus Torvalds
2007-01-26 3:28 ` David Woodhouse
2007-01-26 4:00 ` Linus Torvalds
2007-01-26 4:19 ` David Woodhouse
2007-01-26 4:48 ` Linus Torvalds
2007-01-26 5:09 ` David Woodhouse
2007-01-26 6:01 ` Linus Torvalds
2007-01-26 6:18 ` Linus Torvalds
2007-01-26 8:17 ` David Miller
2007-01-26 8:20 ` David Miller
2007-01-26 4:53 ` Jeff Garzik
2007-01-26 15:32 ` Mark Lord
2007-01-26 15:29 ` Mark Lord
2007-01-28 23:04 ` Benjamin Herrenschmidt
2007-01-28 22:49 ` Benjamin Herrenschmidt
2007-01-25 23:36 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B93EF2.3030706@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).