* [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static
@ 2019-03-20 13:42 Yue Haibing
2019-03-20 14:57 ` Guenter Roeck
2019-03-20 19:27 ` Mukesh Ojha
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-03-20 13:42 UTC (permalink / raw)
To: wim, linux; +Cc: linux-kernel, linux-watchdog, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
drivers/watchdog/sb_wdog.c:70:6: warning: symbol 'sbwdog_set' was not declared. Should it be static?
drivers/watchdog/sb_wdog.c:84:6: warning: symbol 'sbwdog_pet' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/watchdog/sb_wdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
index 3abae50..8264fced 100644
--- a/drivers/watchdog/sb_wdog.c
+++ b/drivers/watchdog/sb_wdog.c
@@ -67,7 +67,7 @@ static DEFINE_SPINLOCK(sbwd_lock);
*
* wdog is the iomem address of the cfg register
*/
-void sbwdog_set(char __iomem *wdog, unsigned long t)
+static void sbwdog_set(char __iomem *wdog, unsigned long t)
{
spin_lock(&sbwd_lock);
__raw_writeb(0, wdog);
@@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
*
* wdog is the iomem address of the cfg register
*/
-void sbwdog_pet(char __iomem *wdog)
+static void sbwdog_pet(char __iomem *wdog)
{
spin_lock(&sbwd_lock);
__raw_writeb(__raw_readb(wdog) | 1, wdog);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static
2019-03-20 13:42 [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static Yue Haibing
@ 2019-03-20 14:57 ` Guenter Roeck
2019-03-20 19:27 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-03-20 14:57 UTC (permalink / raw)
To: Yue Haibing; +Cc: wim, linux-kernel, linux-watchdog
On Wed, Mar 20, 2019 at 09:42:50PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/watchdog/sb_wdog.c:70:6: warning: symbol 'sbwdog_set' was not declared. Should it be static?
> drivers/watchdog/sb_wdog.c:84:6: warning: symbol 'sbwdog_pet' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sb_wdog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
> index 3abae50..8264fced 100644
> --- a/drivers/watchdog/sb_wdog.c
> +++ b/drivers/watchdog/sb_wdog.c
> @@ -67,7 +67,7 @@ static DEFINE_SPINLOCK(sbwd_lock);
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_set(char __iomem *wdog, unsigned long t)
> +static void sbwdog_set(char __iomem *wdog, unsigned long t)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(0, wdog);
> @@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_pet(char __iomem *wdog)
> +static void sbwdog_pet(char __iomem *wdog)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(__raw_readb(wdog) | 1, wdog);
> --
> 2.7.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static
2019-03-20 13:42 [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static Yue Haibing
2019-03-20 14:57 ` Guenter Roeck
@ 2019-03-20 19:27 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-03-20 19:27 UTC (permalink / raw)
To: Yue Haibing, wim, linux; +Cc: linux-kernel, linux-watchdog
On 3/20/2019 7:12 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/watchdog/sb_wdog.c:70:6: warning: symbol 'sbwdog_set' was not declared. Should it be static?
> drivers/watchdog/sb_wdog.c:84:6: warning: symbol 'sbwdog_pet' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/watchdog/sb_wdog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
> index 3abae50..8264fced 100644
> --- a/drivers/watchdog/sb_wdog.c
> +++ b/drivers/watchdog/sb_wdog.c
> @@ -67,7 +67,7 @@ static DEFINE_SPINLOCK(sbwd_lock);
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_set(char __iomem *wdog, unsigned long t)
> +static void sbwdog_set(char __iomem *wdog, unsigned long t)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(0, wdog);
> @@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
> *
> * wdog is the iomem address of the cfg register
> */
> -void sbwdog_pet(char __iomem *wdog)
> +static void sbwdog_pet(char __iomem *wdog)
> {
> spin_lock(&sbwd_lock);
> __raw_writeb(__raw_readb(wdog) | 1, wdog);
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks.
Mukesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-20 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 13:42 [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet static Yue Haibing
2019-03-20 14:57 ` Guenter Roeck
2019-03-20 19:27 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).