* [PATCH] nvmem: Convert to using %pOF instead of full_name
@ 2017-07-18 21:43 Rob Herring
2017-08-09 22:14 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-07-18 21:43 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: linux-kernel, devicetree
Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/nvmem/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 4c49285168fb..b0c60338296a 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
addr = of_get_property(cell_np, "reg", &len);
if (!addr || (len < 2 * sizeof(u32))) {
- dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
- cell_np->full_name);
+ dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
+ cell_np);
rval = -EINVAL;
goto err_mem;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: Convert to using %pOF instead of full_name
2017-07-18 21:43 [PATCH] nvmem: Convert to using %pOF instead of full_name Rob Herring
@ 2017-08-09 22:14 ` Rob Herring
2017-08-10 8:57 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-08-09 22:14 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: linux-kernel, devicetree
On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/nvmem/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Ping?
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 4c49285168fb..b0c60338296a 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>
> addr = of_get_property(cell_np, "reg", &len);
> if (!addr || (len < 2 * sizeof(u32))) {
> - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
> - cell_np->full_name);
> + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
> + cell_np);
> rval = -EINVAL;
> goto err_mem;
> }
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: Convert to using %pOF instead of full_name
2017-08-09 22:14 ` Rob Herring
@ 2017-08-10 8:57 ` Srinivas Kandagatla
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2017-08-10 8:57 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, devicetree
On 09/08/17 23:14, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/nvmem/core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Ping?
I have already sent this patch to Greg to queue up for next.
Thanks,
srini
>
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 4c49285168fb..b0c60338296a 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>>
>> addr = of_get_property(cell_np, "reg", &len);
>> if (!addr || (len < 2 * sizeof(u32))) {
>> - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
>> - cell_np->full_name);
>> + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
>> + cell_np);
>> rval = -EINVAL;
>> goto err_mem;
>> }
>> --
>> 2.11.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-10 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-18 21:43 [PATCH] nvmem: Convert to using %pOF instead of full_name Rob Herring
2017-08-09 22:14 ` Rob Herring
2017-08-10 8:57 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).