From: Zhang Rui <rui.zhang@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@redhat.com" <jolsa@redhat.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform
Date: Fri, 05 Feb 2021 00:04:25 +0800 [thread overview]
Message-ID: <45cbb7f18765cf7365e5eaa1358727201fc1f4bf.camel@intel.com> (raw)
In-Reply-To: <YBq3csfKeH7PaK39@hirez.programming.kicks-ass.net>
Hi, Peter,
On Wed, 2021-02-03 at 15:47 +0100, Peter Zijlstra wrote:
> FWIW, your email is malformed, please wrap at 78 chars.
>
> On Mon, Jan 25, 2021 at 06:11:14AM +0000, Zhang, Rui wrote:
> > In short, the current code does not allow RAPL energy counter to
> > return 0. And all the work I do is to allow Psys energy counter to
> > return 0.
>
> Ok.
>
> > In this way, the Psys event is "valid" on all CPUs, so we don't
> > need
> > to handle the master thing.
>
> So RAPL is mapped to DIEs, and IIRC we can have multiple DIEs per
> Package. But the master thing is a Package.
>
> Is this all moot because SPR has one DIE per Package?
Oh, right.
This is not a problem on SPR because it is a single-die
platform.
> Because if it
> would have more, there's be more interesting problems I suppose.
Agreed.
thanks,
rui
prev parent reply other threads:[~2021-02-04 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 9:22 [PATCH 1/3] perf/x86/rapl: Add msr mask support Zhang Rui
2021-01-15 9:22 ` [PATCH 2/3] perf/x86/rapl: Fix energy counter detection Zhang Rui
2021-01-15 20:03 ` Peter Zijlstra
2021-01-16 8:19 ` Zhang, Rui
2021-01-16 12:48 ` Peter Zijlstra
2021-01-17 14:44 ` Zhang, Rui
2021-02-03 14:21 ` Peter Zijlstra
2021-01-15 9:22 ` [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform Zhang Rui
2021-01-16 12:50 ` Peter Zijlstra
2021-01-17 14:33 ` Zhang, Rui
2021-01-25 6:11 ` Zhang, Rui
2021-02-03 14:17 ` Zhang, Rui
2021-02-03 14:47 ` Peter Zijlstra
2021-02-04 16:04 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45cbb7f18765cf7365e5eaa1358727201fc1f4bf.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).