From: Nikolaus Voss <nv@vosn.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Nikolaus Voss <nikolaus.voss@haag-streit.com>,
Horia Geanta <horia.geanta@nxp.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Gaurav Jain <gaurav.jain@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
David Gstir <david@sigma-star.at>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure
Date: Fri, 2 Dec 2022 15:43:29 +0100 (CET) [thread overview]
Message-ID: <46085da-4dd4-f02e-1e1d-442cfceeeb15@vosn.de> (raw)
In-Reply-To: <94f5f20b-f7c9-b9b5-1b49-3c4366b47370@pengutronix.de>
On Fri, 2 Dec 2022, Ahmad Fatoum wrote:
> On 21.11.22 15:12, Nikolaus Voss wrote:
>> + ctrlpriv = dev_get_drvdata(jrdev->parent);
>> + moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status));
>
> Sorry for not having spotted this the first time, but ioread32 is not
> completely correct here as the CAAM may be big endian while the CPU is
> little endian.
>
> You should be using rd_reg32 here.
Ok.
Herbert, shall I spin v3 of the patch or patch against v2?
Niko
next prev parent reply other threads:[~2022-12-02 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:12 [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure Nikolaus Voss
2022-12-01 8:18 ` Ahmad Fatoum
2022-12-02 10:19 ` Herbert Xu
2022-12-02 12:05 ` Ahmad Fatoum
2022-12-02 14:43 ` Nikolaus Voss [this message]
2022-12-02 23:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46085da-4dd4-f02e-1e1d-442cfceeeb15@vosn.de \
--to=nv@vosn.de \
--cc=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=david@sigma-star.at \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolaus.voss@haag-streit.com \
--cc=pankaj.gupta@nxp.com \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).