From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nikolaus Voss <nikolaus.voss@haag-streit.com>
Cc: Horia Geanta <horia.geanta@nxp.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Gaurav Jain <gaurav.jain@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
David Gstir <david@sigma-star.at>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Nikolaus Voss <nv@vosn.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure
Date: Fri, 2 Dec 2022 18:19:08 +0800 [thread overview]
Message-ID: <Y4nRHLAJeaVs1vMW@gondor.apana.org.au> (raw)
In-Reply-To: <20221121141929.2E36427E9@mail.steuer-voss.de>
On Mon, Nov 21, 2022 at 03:12:41PM +0100, Nikolaus Voss wrote:
> If CAAM is not in "trusted" or "secure" state, a fixed non-volatile key
> is used instead of the unique device key. This is the default mode of
> operation without secure boot (HAB). In this scenario, CAAM encrypted
> blobs should be used only for testing but not in a production
> environment, so issue a warning.
>
> Signed-off-by: Nikolaus Voss <nikolaus.voss@haag-streit.com>
>
> ---
> CHANGES
> =======
> v2: make warning more verbose, correct register, style fixes
> v3: fix sparse warning "dereference of noderef expression"
> by using ioread32() to dereference iomem pointer
>
> drivers/crypto/caam/blob_gen.c | 9 +++++++++
> drivers/crypto/caam/regs.h | 3 +++
> 2 files changed, 12 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-12-02 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:12 [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure Nikolaus Voss
2022-12-01 8:18 ` Ahmad Fatoum
2022-12-02 10:19 ` Herbert Xu [this message]
2022-12-02 12:05 ` Ahmad Fatoum
2022-12-02 14:43 ` Nikolaus Voss
2022-12-02 23:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4nRHLAJeaVs1vMW@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=david@sigma-star.at \
--cc=gaurav.jain@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolaus.voss@haag-streit.com \
--cc=nv@vosn.de \
--cc=pankaj.gupta@nxp.com \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).