From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Aaron Lu <aaron.lu@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] PM / sleep: New flag to speed up suspend-resume of suspended devices
Date: Thu, 27 Feb 2014 00:13:19 +0100 [thread overview]
Message-ID: <4633671.dBN1DXCk1F@vostro.rjw.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1402261708030.1308-100000@iolanthe.rowland.org>
On Wednesday, February 26, 2014 05:17:03 PM Alan Stern wrote:
> On Wed, 26 Feb 2014, Rafael J. Wysocki wrote:
>
> > > > Still, I think that something like power.fast_suspend is needed to indicate
> > > > that .suspend_late(), .suspend_noirq(), .resume_noirq() and .resume_early()
> > > > should be skipped for it (in my opinion the core may very well skip them then)
> > > > and so that .resume() knows how to handle the device.
> > >
> > > I don't follow. Why would you skip these routines without also
> > > skipping .suspend and .resume?
> >
> > Because .suspend will set the flag and then it would be reasonable to call .resume,
> > for symmetry and to let it decide what to do (e.g. call pm_runtime_resume(dev) or
> > do something else, depending on the subsystem).
>
> In the original patch, ->prepare returned the flag. When it was set,
> you would skip ->suspend, ->suspend_late, and ->suspend_noirq (and the
> corresponding resume callbacks). Did you decide to change this?
Yes, I did.
After these patches:
https://patchwork.kernel.org/patch/3705261/
https://patchwork.kernel.org/patch/3705271/
the decision doesn't have to be made until ->suspend (I'm ingoring the
power.ignore_children set special case), because that's when
pm_runtime_resume(dev) is now called (by ACPI and PCI).
> > > However, the second may indeed be a problem. I don't know how you
> > > intend to handle it. Apply the patch, like you did for ACPI and PCI
> > > above, and then see what happens?
> >
> > For starters, I'd just make the parent's ->resume call pm_runtime_resume(dev).
> > That will make the parent be ready before the child's ->resume is called.
> > And then it may be optimized further going forward, possibly by replacing
> > the pm_runtime_resume() with pm_request_resume() for some devices and by
> > leaving some devices in RPM_SUSPENDED.
>
> Of course, this would not be possible with the original version of the
> patch, because it wouldn't invoke the parent's ->resume.
Right.
> > > A simple solution is to use fast_suspend only for devices that have no
> > > children. But that would not be optimal.
> > >
> > > Another possibility is always to call pm_runtime_resume(dev->parent)
> > > before invoking dev's ->resume callback. But that might not solve the
> > > entire problem (it wouldn't help dev's ->resume_early callback, for
> > > instance) and it also might be sub-optimal.
> >
> > The child's ->resume_early may be a problem indeed (or its ->resume_noirq
> > for that matter).
>
> If the child knows about the problem beforehand, it can runtime-resume
> the parent during its ->suspend.
Well, it even should do that in those cases. We may need to deal with children
that don't do that, though.
> > Well, if power.fast_suspend set guarantees that ->suspend_late, ->suspend_noirq,
> > ->resume_noirq, and ->resume_early will be skipped for a device, then we may
> > restrict setting it for devices whose children have it set (or that have no
> > children). Initially, that will be equivalent to setting it for leaf devices
> > only, but it might be extended over time in a natural way.
>
> Initially, maybe.
Of course initially.
> But it's the wrong approach in general.
In the long run - I agree.
> The right approach is to restrict setting fast_suspend for devices whose
> children don't mind their parent being suspended when their resume callbacks
> run -- not for devices whose children also have fast_suspend set.
I agree, but we need to know which children are OK with the parent being
suspended. Having fast_suspend set is a good indication of that. :-)
Of course, we may introduce a separate flag for that just fine if you prefer.
> That's the point I've been trying to express all along.
I see.
Rafael
next prev parent reply other threads:[~2014-02-26 22:58 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 23:12 [RFC][PATCH 0/3] PM: Mechanism to avoid resuming runtime-suspended devices during system suspend Rafael J. Wysocki
2014-01-14 23:13 ` [RFC][PATCH 1/3] PM / sleep: Flag to avoid executing suspend callbacks for devices Rafael J. Wysocki
2014-01-14 23:14 ` [RFC][PATCH 2/3] PM / runtime: Routine for checking device status during system suspend Rafael J. Wysocki
2014-01-16 13:32 ` Mika Westerberg
2014-01-16 16:07 ` [Update][RFC][PATCH " Rafael J. Wysocki
2014-01-14 23:16 ` [RFC][PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain " Rafael J. Wysocki
2014-01-15 13:57 ` [Update][RFC][PATCH " Rafael J. Wysocki
2014-02-16 23:49 ` [RFC][PATCH 0/3] PM: Mechanism to avoid resuming runtime-suspended devices " Rafael J. Wysocki
2014-02-16 23:50 ` [PATCH 1/3] PM / sleep: New flag to speed up suspend-resume of suspended devices Rafael J. Wysocki
2014-02-18 12:59 ` Ulf Hansson
2014-02-18 13:25 ` Rafael J. Wysocki
2014-02-19 17:01 ` Alan Stern
2014-02-20 1:23 ` Rafael J. Wysocki
2014-02-20 1:42 ` Rafael J. Wysocki
2014-02-20 17:03 ` Alan Stern
2014-02-24 0:00 ` Rafael J. Wysocki
2014-02-24 19:36 ` Alan Stern
2014-02-25 0:07 ` Rafael J. Wysocki
2014-02-25 17:08 ` Alan Stern
2014-02-25 23:56 ` Rafael J. Wysocki
2014-02-26 16:49 ` Alan Stern
2014-02-26 21:44 ` Rafael J. Wysocki
2014-02-26 22:17 ` Alan Stern
2014-02-26 23:13 ` Rafael J. Wysocki [this message]
2014-02-27 15:02 ` Alan Stern
2014-04-24 22:36 ` [RFC][PATCH 0/3] PM: Mechanism to avoid resuming runtime-suspended devices during system suspend, v2 Rafael J. Wysocki
2014-04-24 22:37 ` [RFC][PATCH 1/3] PM / sleep: Flags to speed up suspend-resume of runtime-suspended devices Rafael J. Wysocki
2014-05-01 21:39 ` Alan Stern
2014-05-01 23:15 ` Rafael J. Wysocki
2014-05-01 23:36 ` Rafael J. Wysocki
2014-05-02 0:04 ` Rafael J. Wysocki
2014-05-02 15:41 ` Rafael J. Wysocki
2014-05-02 18:44 ` Alan Stern
2014-05-05 0:09 ` Rafael J. Wysocki
2014-05-05 15:46 ` Alan Stern
2014-05-06 1:31 ` Rafael J. Wysocki
2014-05-06 19:31 ` Alan Stern
2014-05-07 0:36 ` Rafael J. Wysocki
2014-05-07 15:43 ` Alan Stern
2014-05-07 23:27 ` [RFC][PATCH 0/3] (was: Re: [RFC][PATCH 1/3] PM / sleep: Flags to speed up suspend-resume of runtime-suspended devices) Rafael J. Wysocki
2014-05-07 23:29 ` [RFC][PATCH 1/3] PM / sleep: Flag to speed up suspend-resume of runtime-suspended devices Rafael J. Wysocki
2014-05-08 7:49 ` Ulf Hansson
2014-05-08 10:53 ` Rafael J. Wysocki
2014-05-08 10:59 ` Ulf Hansson
2014-05-08 11:44 ` Rafael J. Wysocki
2014-05-08 12:25 ` Ulf Hansson
2014-05-08 20:02 ` Rafael J. Wysocki
2014-05-08 14:36 ` Alan Stern
2014-05-08 14:57 ` Alan Stern
2014-05-08 20:17 ` Rafael J. Wysocki
2014-05-08 21:03 ` Rafael J. Wysocki
2014-05-08 21:20 ` Alan Stern
2014-05-08 21:42 ` Rafael J. Wysocki
2014-05-08 21:50 ` Rafael J. Wysocki
2014-05-08 22:28 ` [RFC][PATCH 0/3] (was: Re: PM / sleep: Flag to speed up suspend-resume of runtime-suspended devices) Rafael J. Wysocki
2014-05-08 22:41 ` [RFC][PATCH 1/3] PM / sleep: Flag to speed up suspend-resume of runtime-suspended devices Rafael J. Wysocki
2014-05-09 7:23 ` Ulf Hansson
2014-05-09 11:33 ` Rafael J. Wysocki
2014-05-08 22:41 ` [RFC][PATCH 2/3] PM / runtime: Routine for checking device status during system suspend Rafael J. Wysocki
2014-05-08 22:42 ` [RFC][PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain " Rafael J. Wysocki
2014-05-09 1:52 ` [RFC][PATCH 1/3] PM / sleep: Flag to speed up suspend-resume of runtime-suspended devices Alan Stern
2014-05-09 22:49 ` Rafael J. Wysocki
2014-05-11 16:46 ` Alan Stern
2014-05-13 0:51 ` Rafael J. Wysocki
2014-05-08 21:08 ` Alan Stern
2014-05-09 22:48 ` Kevin Hilman
2014-05-10 1:38 ` Rafael J. Wysocki
2014-05-12 16:33 ` Kevin Hilman
2014-05-07 23:31 ` [Resend][PATCH 2/3] PM / runtime: Routine for checking device status during system suspend Rafael J. Wysocki
2014-05-07 23:33 ` [RFC][PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain " Rafael J. Wysocki
2014-05-08 14:59 ` Alan Stern
2014-05-08 19:40 ` Rafael J. Wysocki
2014-05-02 16:12 ` [RFC][PATCH 1/3] PM / sleep: Flags to speed up suspend-resume of runtime-suspended devices Alan Stern
2014-04-24 22:39 ` [RFC][PATCH 2/3][Resend] PM / runtime: Routine for checking device status during system suspend Rafael J. Wysocki
2014-04-25 11:28 ` Ulf Hansson
2014-04-24 22:40 ` [RFC][PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain " Rafael J. Wysocki
2014-02-16 23:51 ` [PATCH 2/3][Resend] PM / runtime: Routine for checking device status " Rafael J. Wysocki
2014-02-16 23:52 ` [PATCH 3/3] ACPI / PM: Avoid resuming devices in ACPI PM domain " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4633671.dBN1DXCk1F@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=aaron.lu@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).