From: Bean Huo <huobean@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org,
rdunlap@infradead.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@infradead.org
Subject: Re: [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB
Date: Fri, 08 May 2020 12:15:33 +0200 [thread overview]
Message-ID: <464f674a9a439bbfd563b5360e3a8fbbf6c41de1.camel@gmail.com> (raw)
In-Reply-To: <c398bc0c-c87c-3260-471d-85f0d10cf917@acm.org>
On Thu, 2020-05-07 at 18:04 -0700, Bart Van Assche wrote:
> > + GEOMETRY_DESC_PARAM_HPB_REGION_SIZE = 0x48,
> > + GEOMETRY_DESC_PARAM_HPB_NUMBER_LU = 0x49,
> > + GEOMETRY_DESC_PARAM_HPB_SUBREGION_SIZE = 0x4A,
> > + GEOMETRY_DESC_PARAM_HPB_MAX_ACTIVE_REGIONS = 0x4B,
> > };
>
> How about adding the names from the spec as a comment above the new
> constants, e.g. as follows?
>
> /* wHPBPinnedRegionStartIdx */
> UNIT_DESC_PARAM_HPB_PIN_REGION_START_OFFSET = 0x25,
>
> Thanks,
>
> Bart.
Bart
I will add in the next version.
thanks,
Bean
next prev parent reply other threads:[~2020-05-08 10:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:20 [RESENT PATCH RFC v3 0/5] scsi: ufs: add UFS Host Performance Booster(HPB) support huobean
2020-05-04 14:20 ` [RESENT PATCH RFC v3 1/5] scsi; ufs: add device descriptor for Host Performance Booster huobean
2020-05-08 0:59 ` Bart Van Assche
2020-05-08 9:09 ` Bean Huo
2020-05-04 14:20 ` [RESENT PATCH RFC v3 2/5] scsi: ufs: make ufshcd_read_unit_desc_param() non-static func huobean
2020-05-04 14:20 ` [RESENT PATCH RFC v3 3/5] scsi: ufs: add ufs_features parameter in structure ufs_dev_info huobean
2020-05-08 1:02 ` Bart Van Assche
2020-05-08 9:15 ` Bean Huo
2020-05-04 14:20 ` [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB huobean
2020-05-08 1:04 ` Bart Van Assche
2020-05-08 10:15 ` Bean Huo [this message]
2020-05-04 14:20 ` [RESENT PATCH RFC v3 5/5] scsi: ufs: UFS Host Performance Booster(HPB) driver huobean
2020-05-08 1:34 ` Randy Dunlap
2020-05-08 10:08 ` Bean Huo
2020-05-08 3:21 ` Bart Van Assche
2020-05-08 14:44 ` Bean Huo
2020-05-08 20:11 ` Bart Van Assche
2020-05-08 11:38 ` Avri Altman
2020-05-08 12:15 ` Bean Huo
2020-05-08 14:26 ` Alim Akhtar
2020-05-08 14:59 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464f674a9a439bbfd563b5360e3a8fbbf6c41de1.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rdunlap@infradead.org \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).