From: Bart Van Assche <bvanassche@acm.org>
To: huobean@gmail.com, alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org,
rdunlap@infradead.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@infradead.org
Subject: Re: [RESENT PATCH RFC v3 1/5] scsi; ufs: add device descriptor for Host Performance Booster
Date: Thu, 7 May 2020 17:59:52 -0700 [thread overview]
Message-ID: <6d06ec34-04d2-93ff-1ff5-dc1317c3d060@acm.org> (raw)
In-Reply-To: <20200504142032.16619-2-beanhuo@micron.com>
On 2020-05-04 07:20, huobean@gmail.com wrote:
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 698e8d20b4ba..de13d2333f1f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6627,6 +6627,17 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
> goto out;
> }
>
> + if (desc_buf[DEVICE_DESC_PARAM_UFS_FEAT] & 0x80) {
> + hba->dev_info.hpb_control_mode =
> + desc_buf[DEVICE_DESC_PARAM_HPB_CTRL_MODE];
> + hba->dev_info.hpb_ver =
> + (u16) (desc_buf[DEVICE_DESC_PARAM_HPB_VER] << 8) |
> + desc_buf[DEVICE_DESC_PARAM_HPB_VER + 1];
> + dev_info(hba->dev, "HPB Version: 0x%2x\n",
> + hba->dev_info.hpb_ver);
> + dev_info(hba->dev, "HPB control mode: %d\n",
> + hba->dev_info.hpb_control_mode);
> + }
> /*
> * getting vendor (manufacturerID) and Bank Index in big endian
> * format
Please introduce a symbolic name for the constant 0x80, e.g.
UFS_FEATURE_HPB.
Please use get_unaligned_be16() instead of open-coding it.
Thanks,
Bart.
next prev parent reply other threads:[~2020-05-08 0:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:20 [RESENT PATCH RFC v3 0/5] scsi: ufs: add UFS Host Performance Booster(HPB) support huobean
2020-05-04 14:20 ` [RESENT PATCH RFC v3 1/5] scsi; ufs: add device descriptor for Host Performance Booster huobean
2020-05-08 0:59 ` Bart Van Assche [this message]
2020-05-08 9:09 ` Bean Huo
2020-05-04 14:20 ` [RESENT PATCH RFC v3 2/5] scsi: ufs: make ufshcd_read_unit_desc_param() non-static func huobean
2020-05-04 14:20 ` [RESENT PATCH RFC v3 3/5] scsi: ufs: add ufs_features parameter in structure ufs_dev_info huobean
2020-05-08 1:02 ` Bart Van Assche
2020-05-08 9:15 ` Bean Huo
2020-05-04 14:20 ` [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB huobean
2020-05-08 1:04 ` Bart Van Assche
2020-05-08 10:15 ` Bean Huo
2020-05-04 14:20 ` [RESENT PATCH RFC v3 5/5] scsi: ufs: UFS Host Performance Booster(HPB) driver huobean
2020-05-08 1:34 ` Randy Dunlap
2020-05-08 10:08 ` Bean Huo
2020-05-08 3:21 ` Bart Van Assche
2020-05-08 14:44 ` Bean Huo
2020-05-08 20:11 ` Bart Van Assche
2020-05-08 11:38 ` Avri Altman
2020-05-08 12:15 ` Bean Huo
2020-05-08 14:26 ` Alim Akhtar
2020-05-08 14:59 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d06ec34-04d2-93ff-1ff5-dc1317c3d060@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hch@infradead.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rdunlap@infradead.org \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).