* [PATCH 1/5] cxgb3 - fix skb->dev dereference
@ 2007-05-30 17:01 divy
2007-06-20 23:17 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: divy @ 2007-05-30 17:01 UTC (permalink / raw)
To: jeff; +Cc: netdev, linux-kernel, swise
From: Divy Le Ray <divy@chelsio.com>
eth_type_trans() now sets skb->dev.
References to skb->dev should happen after it is called.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/sge.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 3666586..eaa7dac 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -1690,8 +1690,8 @@ static void rx_eth(struct adapter *adap,
struct port_info *pi;
skb_pull(skb, sizeof(*p) + pad);
- skb->dev->last_rx = jiffies;
skb->protocol = eth_type_trans(skb, adap->port[p->iff]);
+ skb->dev->last_rx = jiffies;
pi = netdev_priv(skb->dev);
if (pi->rx_csum_offload && p->csum_valid && p->csum == 0xffff &&
!p->fragment) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/5] cxgb3 - fix skb->dev dereference
2007-05-30 17:01 [PATCH 1/5] cxgb3 - fix skb->dev dereference divy
@ 2007-06-20 23:17 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-06-20 23:17 UTC (permalink / raw)
To: divy; +Cc: netdev, linux-kernel, swise
divy@chelsio.com wrote:
> From: Divy Le Ray <divy@chelsio.com>
>
> eth_type_trans() now sets skb->dev.
> References to skb->dev should happen after it is called.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
> ---
>
> drivers/net/cxgb3/sge.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied 1-5 to #upstream-fixes (2.6.22)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-20 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-30 17:01 [PATCH 1/5] cxgb3 - fix skb->dev dereference divy
2007-06-20 23:17 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).