* [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
@ 2007-08-30 22:46 Jason Gaston
2007-08-31 1:41 ` Matthew Wilcox
2007-09-01 21:19 ` Grant Grundler
0 siblings, 2 replies; 5+ messages in thread
From: Jason Gaston @ 2007-08-30 22:46 UTC (permalink / raw)
To: gregkh, linux-kernel, linux-pci, khali, i2c, jason.d.gaston
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
Signed-off-by: Jason Gaston <jason.d.gaston@intel.com>
--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
@@ -550,6 +550,7 @@
case PCI_DEVICE_ID_INTEL_ICH9_3:
case PCI_DEVICE_ID_INTEL_ICH9_4:
case PCI_DEVICE_ID_INTEL_ICH9_5:
+ case PCI_DEVICE_ID_INTEL_Tolapai_0:
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
--- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27
18:32:35.000000000 -0700
+++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-28 16:58:31.000000000
-0700
@@ -2293,6 +2293,8 @@
#define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
#define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
#define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000
#define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010
#define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
2007-08-30 22:46 [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai Jason Gaston
@ 2007-08-31 1:41 ` Matthew Wilcox
2007-09-01 21:19 ` Grant Grundler
1 sibling, 0 replies; 5+ messages in thread
From: Matthew Wilcox @ 2007-08-31 1:41 UTC (permalink / raw)
To: Jason Gaston; +Cc: gregkh, linux-kernel, linux-pci, khali, i2c
On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
NACK -- use all upper-case.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
2007-08-30 22:46 [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai Jason Gaston
2007-08-31 1:41 ` Matthew Wilcox
@ 2007-09-01 21:19 ` Grant Grundler
2007-09-01 21:30 ` Jeff Garzik
1 sibling, 1 reply; 5+ messages in thread
From: Grant Grundler @ 2007-09-01 21:19 UTC (permalink / raw)
To: Jason Gaston; +Cc: gregkh, linux-kernel, linux-pci, khali, i2c
On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
>
> Signed-off-by: ?Jason Gaston <jason.d.gaston@intel.com>
>
> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
> -0700
> +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
> @@ -550,6 +550,7 @@
> case PCI_DEVICE_ID_INTEL_ICH9_3:
> case PCI_DEVICE_ID_INTEL_ICH9_4:
> case PCI_DEVICE_ID_INTEL_ICH9_5:
> + case PCI_DEVICE_ID_INTEL_Tolapai_0:
If this is the only place it's used, the prefence is to define the
constant locally (in the file) and not in pci_ids.h.
Please do submit new PCI device IDs to pciids.sf.net project.
thanks,
grant
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;
> --- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27
> 18:32:35.000000000 -0700
> +++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-28 16:58:31.000000000
> -0700
> @@ -2293,6 +2293,8 @@
> #define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
> #define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000
> #define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010
> #define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
2007-09-01 21:19 ` Grant Grundler
@ 2007-09-01 21:30 ` Jeff Garzik
2007-09-04 17:17 ` Gaston, Jason D
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2007-09-01 21:30 UTC (permalink / raw)
To: Grant Grundler, Jason Gaston; +Cc: gregkh, linux-kernel, linux-pci, khali, i2c
Grant Grundler wrote:
> On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
>> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
>>
>> Signed-off-by: ?Jason Gaston <jason.d.gaston@intel.com>
>>
>> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
>> -0700
>> +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
>> @@ -550,6 +550,7 @@
>> case PCI_DEVICE_ID_INTEL_ICH9_3:
>> case PCI_DEVICE_ID_INTEL_ICH9_4:
>> case PCI_DEVICE_ID_INTEL_ICH9_5:
>> + case PCI_DEVICE_ID_INTEL_Tolapai_0:
>
> If this is the only place it's used, the prefence is to define the
> constant locally (in the file) and not in pci_ids.h.
Kinda sorta: if you must define a constant, it should go into
linux/pci_ids.h. Otherwise someone will come along later, do the same
locally in another file, then you have two independent symbols with the
same meaning.
Ideally, in pci_device_id tables and such, you can just use the hex
number, since they are all arbitrary and lack meaning anyway.
> Please do submit new PCI device IDs to pciids.sf.net project.
Yep.
>> #define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
>> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
>> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
>> +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
>> +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
And change the StudlyCaps to ALLCAPS.
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
2007-09-01 21:30 ` Jeff Garzik
@ 2007-09-04 17:17 ` Gaston, Jason D
0 siblings, 0 replies; 5+ messages in thread
From: Gaston, Jason D @ 2007-09-04 17:17 UTC (permalink / raw)
To: Jeff Garzik, Grant Grundler; +Cc: gregkh, linux-kernel, linux-pci, khali, i2c
>> Please do submit new PCI device IDs to pciids.sf.net project.
>
>Yep.
FYI: I have already posted the Tolapai DID's and device strings to
pciids.sf.net.
Thanks,
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-04 17:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-30 22:46 [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai Jason Gaston
2007-08-31 1:41 ` Matthew Wilcox
2007-09-01 21:19 ` Grant Grundler
2007-09-01 21:30 ` Jeff Garzik
2007-09-04 17:17 ` Gaston, Jason D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).