* [PATCH] mmc: at91_mci: cleanup: use MCI_ERRORS
@ 2007-10-17 9:53 Nicolas Ferre
2007-10-17 19:35 ` Pierre Ossman
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Ferre @ 2007-10-17 9:53 UTC (permalink / raw)
To: Pierre Ossman; +Cc: Andrew Victor, Linux Kernel list, Patrice Vilchez
From: Andrew Victor <andrew@sanpeople.com>
A small MMC driver cleanup.
Use the defined AT91_MCI_ERRORS in at91_mci_completed_command() instead
of specifying all the error bits individually.
Signed-off-by: Andrew Victor <andrew@sanpeople.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Index: linux-2.6-snapshot/drivers/mmc/host/at91_mci.c
===================================================================
--- a/drivers/mmc/host/at91_mci.c
+++ b/drivers/mmc/host/at91_mci.c
@@ -581,9 +581,7 @@
pr_debug("Status = %08X [%08X %08X %08X %08X]\n",
status, cmd->resp[0], cmd->resp[1], cmd->resp[2], cmd->resp[3]);
- if (status & (AT91_MCI_RINDE | AT91_MCI_RDIRE | AT91_MCI_RCRCE |
- AT91_MCI_RENDE | AT91_MCI_RTOE | AT91_MCI_DCRCE |
- AT91_MCI_DTOE | AT91_MCI_OVRE | AT91_MCI_UNRE)) {
+ if (status & AT91_MCI_ERRORS) {
if ((status & AT91_MCI_RCRCE) && !(mmc_resp_type(cmd) & MMC_RSP_CRC)) {
cmd->error = 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: at91_mci: cleanup: use MCI_ERRORS
2007-10-17 9:53 [PATCH] mmc: at91_mci: cleanup: use MCI_ERRORS Nicolas Ferre
@ 2007-10-17 19:35 ` Pierre Ossman
0 siblings, 0 replies; 2+ messages in thread
From: Pierre Ossman @ 2007-10-17 19:35 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: Andrew Victor, Linux Kernel list, Patrice Vilchez
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Wed, 17 Oct 2007 11:53:40 +0200
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> From: Andrew Victor <andrew@sanpeople.com>
>
> A small MMC driver cleanup.
>
> Use the defined AT91_MCI_ERRORS in at91_mci_completed_command()
> instead of specifying all the error bits individually.
>
> Signed-off-by: Andrew Victor <andrew@sanpeople.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
Applied, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-17 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-17 9:53 [PATCH] mmc: at91_mci: cleanup: use MCI_ERRORS Nicolas Ferre
2007-10-17 19:35 ` Pierre Ossman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).