* [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite
@ 2019-09-17 15:22 Qian Cai
2019-09-17 17:37 ` Ram Pai
2019-10-30 12:14 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Qian Cai @ 2019-09-17 15:22 UTC (permalink / raw)
To: mpe; +Cc: benh, paulus, linuxram, linuxppc-dev, linux-kernel, Qian Cai
pkey_allows_readwrite() was first introduced in the commit 5586cf61e108
("powerpc: introduce execute-only pkey"), but the usage was removed
entirely in the commit a4fcc877d4e1 ("powerpc/pkeys: Preallocate
execute-only key").
Found by the "-Wunused-function" compiler warning flag.
Fixes: a4fcc877d4e1 ("powerpc/pkeys: Preallocate execute-only key")
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/powerpc/mm/book3s64/pkeys.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/powerpc/mm/book3s64/pkeys.c b/arch/powerpc/mm/book3s64/pkeys.c
index ae7fca40e5b3..59e0ebbd8036 100644
--- a/arch/powerpc/mm/book3s64/pkeys.c
+++ b/arch/powerpc/mm/book3s64/pkeys.c
@@ -307,16 +307,6 @@ void thread_pkey_regs_init(struct thread_struct *thread)
write_iamr(pkey_iamr_mask);
}
-static inline bool pkey_allows_readwrite(int pkey)
-{
- int pkey_shift = pkeyshift(pkey);
-
- if (!is_pkey_enabled(pkey))
- return true;
-
- return !(read_amr() & ((AMR_RD_BIT|AMR_WR_BIT) << pkey_shift));
-}
-
int __execute_only_pkey(struct mm_struct *mm)
{
return mm->context.execute_only_pkey;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite
2019-09-17 15:22 [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite Qian Cai
@ 2019-09-17 17:37 ` Ram Pai
2019-10-30 12:14 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Ram Pai @ 2019-09-17 17:37 UTC (permalink / raw)
To: Qian Cai; +Cc: mpe, benh, paulus, linuxppc-dev, linux-kernel
On Tue, Sep 17, 2019 at 11:22:30AM -0400, Qian Cai wrote:
> pkey_allows_readwrite() was first introduced in the commit 5586cf61e108
> ("powerpc: introduce execute-only pkey"), but the usage was removed
> entirely in the commit a4fcc877d4e1 ("powerpc/pkeys: Preallocate
> execute-only key").
>
> Found by the "-Wunused-function" compiler warning flag.
>
> Fixes: a4fcc877d4e1 ("powerpc/pkeys: Preallocate execute-only key")
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> arch/powerpc/mm/book3s64/pkeys.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/powerpc/mm/book3s64/pkeys.c b/arch/powerpc/mm/book3s64/pkeys.c
> index ae7fca40e5b3..59e0ebbd8036 100644
> --- a/arch/powerpc/mm/book3s64/pkeys.c
> +++ b/arch/powerpc/mm/book3s64/pkeys.c
> @@ -307,16 +307,6 @@ void thread_pkey_regs_init(struct thread_struct *thread)
> write_iamr(pkey_iamr_mask);
> }
>
> -static inline bool pkey_allows_readwrite(int pkey)
> -{
> - int pkey_shift = pkeyshift(pkey);
> -
> - if (!is_pkey_enabled(pkey))
> - return true;
> -
> - return !(read_amr() & ((AMR_RD_BIT|AMR_WR_BIT) << pkey_shift));
> -}
> -
> int __execute_only_pkey(struct mm_struct *mm)
> {
> return mm->context.execute_only_pkey;
The function was initially used by __execute_only_pkey(), but ones we
changed the implementation of __execute_only_pkey(), the need for
pkey_allows_readwrite() disappeared.
Acked-by: Ram Pai <linuxram@us.ibm.com>
--
Ram Pai
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite
2019-09-17 15:22 [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite Qian Cai
2019-09-17 17:37 ` Ram Pai
@ 2019-10-30 12:14 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-10-30 12:14 UTC (permalink / raw)
To: Qian Cai; +Cc: linuxram, linux-kernel, Qian Cai, paulus, linuxppc-dev
On Tue, 2019-09-17 at 15:22:30 UTC, Qian Cai wrote:
> pkey_allows_readwrite() was first introduced in the commit 5586cf61e108
> ("powerpc: introduce execute-only pkey"), but the usage was removed
> entirely in the commit a4fcc877d4e1 ("powerpc/pkeys: Preallocate
> execute-only key").
>
> Found by the "-Wunused-function" compiler warning flag.
>
> Fixes: a4fcc877d4e1 ("powerpc/pkeys: Preallocate execute-only key")
> Signed-off-by: Qian Cai <cai@lca.pw>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/29674a1c71be710f8418468aa6a8addd6d1aba1c
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-30 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 15:22 [PATCH] powerpc/pkeys: remove unused pkey_allows_readwrite Qian Cai
2019-09-17 17:37 ` Ram Pai
2019-10-30 12:14 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).