* [PATCH] ata: sata_rcar: make of_device_ids const.
@ 2017-06-16 12:02 Arvind Yadav
2017-06-19 18:05 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-16 12:02 UTC (permalink / raw)
To: tj, b.zolnierkie; +Cc: linux-ide, linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
3946 2296 0 6242 1862 drivers/ata/sata_rcar.o
File size after constify sata_rcar_match.
text data bss dec hex filename
5554 696 0 6250 186a drivers/ata/sata_rcar.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/ata/sata_rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 5d38245..35945e3 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -828,7 +828,7 @@ static void sata_rcar_init_controller(struct ata_host *host)
iowrite32(ATAPI_INT_ENABLE_SATAINT, base + ATAPI_INT_ENABLE_REG);
}
-static struct of_device_id sata_rcar_match[] = {
+static const struct of_device_id sata_rcar_match[] = {
{
/* Deprecated by "renesas,sata-r8a7779" */
.compatible = "renesas,rcar-sata",
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: sata_rcar: make of_device_ids const.
2017-06-16 12:02 [PATCH] ata: sata_rcar: make of_device_ids const Arvind Yadav
@ 2017-06-19 18:05 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-06-19 18:05 UTC (permalink / raw)
To: Arvind Yadav; +Cc: b.zolnierkie, linux-ide, linux-kernel
On Fri, Jun 16, 2017 at 05:32:21PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 3946 2296 0 6242 1862 drivers/ata/sata_rcar.o
>
> File size after constify sata_rcar_match.
> text data bss dec hex filename
> 5554 696 0 6250 186a drivers/ata/sata_rcar.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to libata/for-4.13.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-19 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 12:02 [PATCH] ata: sata_rcar: make of_device_ids const Arvind Yadav
2017-06-19 18:05 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).