linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* PATCH: Hitachi disk quirk
@ 2007-12-04 10:45 Lukas Hejtmanek
  2007-12-04 11:48 ` Michael Tokarev
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Hejtmanek @ 2007-12-04 10:45 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Hello,

the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi
disk has also problem with NCQ.

-- 
Lukáš Hejtmánek

[-- Attachment #2: ata.patch --]
[-- Type: text/x-diff, Size: 587 bytes --]

--- a/drivers/ata/libata-core.c	2007-12-04 11:08:20.000000000 +0100
+++ b/drivers/ata/libata-core.c	2007-12-04 11:09:23.000000000 +0100
@@ -4159,6 +4159,7 @@
 	{ "HTS541612J9SA00",	"SBDIC7JP",	ATA_HORKAGE_NONCQ, },
 	{ "HDT722516DLA380",	"V43OA96A",	ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
+	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },
 	{ "WDC WD740ADFD-00NLR1", NULL,		ATA_HORKAGE_NONCQ, },
 	{ "WDC WD3200AAJS-00RYA0", "12.01B01",	ATA_HORKAGE_NONCQ, },

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Hitachi disk quirk
  2007-12-04 10:45 PATCH: Hitachi disk quirk Lukas Hejtmanek
@ 2007-12-04 11:48 ` Michael Tokarev
  2007-12-04 12:31   ` Lukas Hejtmanek
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Tokarev @ 2007-12-04 11:48 UTC (permalink / raw)
  To: Lukas Hejtmanek; +Cc: linux-kernel

Lukas Hejtmanek wrote:
> Hello,
> 
> the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi
> disk has also problem with NCQ.

Which problems, exactly?

Note that recent massive "NCQ horkage" isn't necessary due to drives fault.
Search for "spurious completions during NCQ" for recent discussions
(many of them).

> --- a/drivers/ata/libata-core.c	2007-12-04 11:08:20.000000000 +0100
> +++ b/drivers/ata/libata-core.c	2007-12-04 11:09:23.000000000 +0100
>  	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
> +	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
>  	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },

/mjt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Hitachi disk quirk
  2007-12-04 11:48 ` Michael Tokarev
@ 2007-12-04 12:31   ` Lukas Hejtmanek
  0 siblings, 0 replies; 3+ messages in thread
From: Lukas Hejtmanek @ 2007-12-04 12:31 UTC (permalink / raw)
  To: Michael Tokarev; +Cc: linux-kernel

On Tue, Dec 04, 2007 at 02:48:27PM +0300, Michael Tokarev wrote:
> Which problems, exactly?

it is spurious completitions and I saw that because of that the drives are
blacklisted. Moreover, the same drive is already blacklisted but with
different firmware. 
 
> Note that recent massive "NCQ horkage" isn't necessary due to drives fault.
> Search for "spurious completions during NCQ" for recent discussions
> (many of them).
> 
> > --- a/drivers/ata/libata-core.c	2007-12-04 11:08:20.000000000 +0100
> > +++ b/drivers/ata/libata-core.c	2007-12-04 11:09:23.000000000 +0100
> >  	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
> > +	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
> >  	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },
> 
> /mjt

-- 
Lukáš Hejtmánek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-12-04 12:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-04 10:45 PATCH: Hitachi disk quirk Lukas Hejtmanek
2007-12-04 11:48 ` Michael Tokarev
2007-12-04 12:31   ` Lukas Hejtmanek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).