From: Shuah Khan <skhan@linuxfoundation.org>
To: Mimi Zohar <zohar@linux.ibm.com>, Joe Perches <joe@perches.com>,
jmorris@namei.org, serge@hallyn.com, mpe@ellerman.id.au,
erichte@linux.ibm.com, nayna@linux.ibm.com,
yuehaibing@huawei.com
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] security/integrity: Include __func__ in messages for easier debug
Date: Mon, 3 Feb 2020 11:55:22 -0700 [thread overview]
Message-ID: <475ab05c-300b-fdbe-5de0-6fce8d1a360d@linuxfoundation.org> (raw)
In-Reply-To: <1580736077.5585.4.camel@linux.ibm.com>
On 2/3/20 6:21 AM, Mimi Zohar wrote:
> On Wed, 2020-01-29 at 19:08 -0800, Joe Perches wrote:
>> On Wed, 2020-01-29 at 19:01 -0700, Shuah Khan wrote:
>>> Change messages to messages to make it easier to debug. The following
>>> error message isn't informative enough to figure out what failed.
>>> Change messages to include function information.
>>>
>>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>>> ---
>>> .../integrity/platform_certs/load_powerpc.c | 14 ++++++++------
>>> security/integrity/platform_certs/load_uefi.c | 17 ++++++++++-------
>>> 2 files changed, 18 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/security/integrity/platform_certs/load_powerpc.c b/security/integrity/platform_certs/load_powerpc.c
>>
>> perhaps instead add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> so all the pr_<level> logging is more specific.
>>
>> This would prefix all pr_<level> output with "integrity: "
>
Joe! Sorry for the delay in getting back to you.
> Agreed. Joe, could you post a patch with a proper patch description
> for this?
>
I have been looking into this a bit more and there is an opportunity
here to add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to integrity.h
and get rid of duplicate defines.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-02-03 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 2:01 [PATCH] security/integrity: Include __func__ in messages for easier debug Shuah Khan
2020-01-30 3:08 ` Joe Perches
2020-02-03 13:21 ` Mimi Zohar
2020-02-03 18:55 ` Shuah Khan [this message]
2020-02-03 19:02 ` Joe Perches
2020-02-03 19:20 ` Shuah Khan
2020-02-03 19:23 ` Casey Schaufler
2020-02-03 19:29 ` Joe Perches
2020-02-03 15:15 ` Nayna
2020-02-03 19:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475ab05c-300b-fdbe-5de0-6fce8d1a360d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=erichte@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=yuehaibing@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).