[PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

[PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

[Jochen Friedrich]

This patch adds support to use the fixed-link property
of an ethernet node to fs_enet for the
CONFIG_PPC_CPM_NEW_BINDING case.

Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
 drivers/net/fs_enet/fs_enet-main.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index f2a4d39..8220c70 100644
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -1174,8 +1174,15 @@ static int __devinit find_phy(struct device_node *np,
 	struct device_node *phynode, *mdionode;
 	struct resource res;
 	int ret = 0, len;
+	const u32 *data;
+
+	data  = of_get_property(np, "fixed-link", NULL);
+	if (data) {
+		snprintf(fpi->bus_id, 16, PHY_ID_FMT, 0, *data);
+		return 0;
+	}

-	const u32 *data = of_get_property(np, "phy-handle", &len);
+	data = of_get_property(np, "phy-handle", &len);
 	if (!data || len != 4)
 		return -EINVAL;

-- 
1.5.3.7

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

[Jeff Garzik]

Jochen Friedrich wrote:
> This patch adds support to use the fixed-link property
> of an ethernet node to fs_enet for the
> CONFIG_PPC_CPM_NEW_BINDING case.
> 
> Signed-off-by: Jochen Friedrich <jochen@scram.de>
> ---
>  drivers/net/fs_enet/fs_enet-main.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
> index f2a4d39..8220c70 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -1174,8 +1174,15 @@ static int __devinit find_phy(struct device_node *np,
>  	struct device_node *phynode, *mdionode;
>  	struct resource res;
>  	int ret = 0, len;
> +	const u32 *data;
> +
> +	data  = of_get_property(np, "fixed-link", NULL);
> +	if (data) {
> +		snprintf(fpi->bus_id, 16, PHY_ID_FMT, 0, *data);
> +		return 0;
> +	}
> 
> -	const u32 *data = of_get_property(np, "phy-handle", &len);
> +	data = of_get_property(np, "phy-handle", &len);
>  	if (!data || len != 4)

ACK, pass this through paulus?

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

[Jochen Friedrich]

Hi Jeff,

> ACK, pass this through paulus?

Yes, that's fine for me.

Thanks,
Jochen

Re: [PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

[Vitaly Bordug]

On Mon, 17 Dec 2007 18:20:14 -0500
Jeff Garzik wrote:

> Jochen Friedrich wrote:
> > This patch adds support to use the fixed-link property
> > of an ethernet node to fs_enet for the
> > CONFIG_PPC_CPM_NEW_BINDING case.
> > 
> > Signed-off-by: Jochen Friedrich <jochen@scram.de>
Acked-by: Vitaly Bordug <vitb@kernel.crashing.org>

Jochen,
will you resend the patch with all acks to paulus? I'll do that if not.


-- 
Sincerely, Vitaly