[PATCH 00/63] ide-cd: redux

[PATCH 00/63] ide-cd: redux

[Bartlomiej Zolnierkiewicz]

Hi,

This patch series is a major rework of the ide-cd driver.

The motivations behind it are twofold:

* ide-cd is still in use but because it has been out of luck for maintainers
  lately the code become quite hard to debug and maintain - this puts it back
  into the shape

* aid efforts of developers (Tejun and Alan) who are working on libata ATAPI
  support - it should be now a lot easier to spot the various quirks for
  weird/buggy devices, differences between sr/ide-cd etc.

This patch series contains only safe/straightforward changes (some "risky"
ones are scheduled for later time) and should be fully bisectable.


Changes:

* unify _four_ slightly different IRQ handlers into one

* re-organize handling of quirky-devices (group quirks scattered
  all over the driver in the table and handle them using flags)

* move code for verbose error logging to ide-cd_verbose.c (this
  code doesn't have any IDE subsystem dependencies so if desired
  it can be easily converted into generic IDE/libata library)

* move code handling cdrom.c IOCTLs to ide-cd_ioctl.c

* remove duplicated/dead code (> 700 LOC gone)

* move historical changelog to Documentation/ide/

* fix few bugs discovered during rewrite


diffstat:

 Documentation/ide/ChangeLog.ide-cd.1994-2004 |  268 ++
 drivers/cdrom/cdrom.c                        |    6
 drivers/ide/Kconfig                          |    9
 drivers/ide/Makefile                         |    6
 drivers/ide/ide-cd.c                         | 3236 +++++++++------------------
 drivers/ide/ide-cd.h                         |  737 ------
 drivers/ide/ide-cd_ioctl.c                   |  265 ++
 drivers/ide/ide-cd_verbose.c                 |  359 ++
 include/linux/cdrom.h                        |   14
 9 files changed, 2095 insertions(+), 2805 deletions(-)


PS ide-cd Maintainer position is still open...

Thanks,
Bart

Re: [PATCH 00/63] ide-cd: redux

[Borislav Petkov]

On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
Hi all,

> PS ide-cd Maintainer position is still open...
i'd like to take that position if nobody objects. I've done some work around the
kernel here and there and i think its time for me to get serious.

Thanks.
-- 
Regards/Gruß,
    Boris.

Re: [PATCH 00/63] ide-cd: redux

[Phillip Susi]

Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> This patch series is a major rework of the ide-cd driver.

Hi, in the future could you please post big patchbombs like this as 
replies to the first one so they fold nicely into one thread?  IIRC, 
git-send-email does this by default now.

Re: [PATCH 00/63] ide-cd: redux

[Bartlomiej Zolnierkiewicz]

On Thursday 20 December 2007, Borislav Petkov wrote:
> On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi Bart,
> Hi all,
> 
> > PS ide-cd Maintainer position is still open...
> i'd like to take that position if nobody objects. I've done some work around the
> kernel here and there and i think its time for me to get serious.

Great!

Please send me a patch for MAINTAINERS file updating ide-cd entry.

Thanks,
Bart

Re: [PATCH 00/63] ide-cd: redux

[Bartlomiej Zolnierkiewicz]

On Thursday 20 December 2007, Phillip Susi wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> > 
> > This patch series is a major rework of the ide-cd driver.
> 
> Hi, in the future could you please post big patchbombs like this as 
> replies to the first one so they fold nicely into one thread?  IIRC, 
> git-send-email does this by default now.

Sure, sorry for forgetting about it this time.

Bart

Re: [PATCH 00/63] ide-cd: redux

[Borislav Petkov]

On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 20 December 2007, Borislav Petkov wrote:
> > On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
> > Hi Bart,
> > Hi all,
> > 
> > > PS ide-cd Maintainer position is still open...
> > i'd like to take that position if nobody objects. I've done some work around the
> > kernel here and there and i think its time for me to get serious.
> 
> Great!
> 
> Please send me a patch for MAINTAINERS file updating ide-cd entry.

Sure, there it is:

---

Reopen ide-cd for maintainership.

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

--
diff --git a/MAINTAINERS b/MAINTAINERS
index 3c7db62..fb59941 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1870,8 +1870,10 @@ T:	quilt kernel.org/pub/linux/kernel/people/bart/pata-2.6/
 S:	Maintained
 
 IDE/ATAPI CDROM DRIVER
+P:	Borislav Petkov
+M:	bbpetkov@yahoo.de
 L:	linux-ide@vger.kernel.org
-S:	Unmaintained
+S:	Maintained
 
 IDE/ATAPI FLOPPY DRIVERS
 P:	Paul Bristow
-- 
Regards/Gruß,
    Boris.

Re: [PATCH 00/63] ide-cd: redux

[Bartlomiej Zolnierkiewicz]

On Sunday 23 December 2007, Borislav Petkov wrote:
> On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday 20 December 2007, Borislav Petkov wrote:
> > > On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > Hi Bart,
> > > Hi all,
> > > 
> > > > PS ide-cd Maintainer position is still open...
> > > i'd like to take that position if nobody objects. I've done some work around the
> > > kernel here and there and i think its time for me to get serious.
> > 
> > Great!
> > 
> > Please send me a patch for MAINTAINERS file updating ide-cd entry.
> 
> Sure, there it is:
> 
> ---
> 
> Reopen ide-cd for maintainership.
> 
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

applied, thanks

Re: [PATCH 00/63] ide-cd: redux

[Andrew Morton]

On Thu, 20 Dec 2007 01:48:49 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> This patch series is a major rework of the ide-cd driver.

woo-hoo.

> PS ide-cd Maintainer position is still open...

boo-hoo.

I wish someone would fix that "The drive appears confused (ireason =
0x%02x)" thing.  I had a go a while back but iirc the reporter disappeared
on me.  It is somewhat common.

Or do you think this patch might indeed fix it?

Re: [PATCH 00/63] ide-cd: redux

[Borislav Petkov]

On Tue, Dec 25, 2007 at 02:05:14PM -0800, Andrew Morton wrote:
> On Thu, 20 Dec 2007 01:48:49 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> > This patch series is a major rework of the ide-cd driver.
> 
> woo-hoo.
> 
> > PS ide-cd Maintainer position is still open...
> 
> boo-hoo.
> 
> I wish someone would fix that "The drive appears confused (ireason =
> 0x%02x)" thing.  I had a go a while back but iirc the reporter disappeared
> on me.  It is somewhat common.
> 
> Or do you think this patch might indeed fix it?

Andrew, take a look at patch #12 in this series: "ide-cd: fix "missing data" handling in
cdrom_pc_intr()."
-- 
Regards/Gruß,
    Boris.