* [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE
@ 2021-10-06 12:03 Lukas Bulwahn
2021-10-06 12:09 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-10-06 12:03 UTC (permalink / raw)
To: Andrew Morton, David Hildenbrand, Michal Hocko, Dave Hansen, linux-mm
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove
functions") defines CONFIG_MEM_BLOCK_SIZE, but this has never been
utilized anywhere.
It is a good practice to keep the CONFIG_* defines exclusively for the
Kbuild system. So, drop this unused definition.
This issue was noticed due to running ./scripts/checkkconfigsymbols.py.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
include/linux/memory.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/memory.h b/include/linux/memory.h
index c46ff374d48d..a216829df280 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -143,7 +143,6 @@ typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
extern int walk_memory_blocks(unsigned long start, unsigned long size,
void *arg, walk_memory_blocks_func_t func);
extern int for_each_memory_block(void *arg, walk_memory_blocks_func_t func);
-#define CONFIG_MEM_BLOCK_SIZE (PAGES_PER_SECTION<<PAGE_SHIFT)
extern int memory_group_register_static(int nid, unsigned long max_pages);
extern int memory_group_register_dynamic(int nid, unsigned long unit_pages);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE
2021-10-06 12:03 [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE Lukas Bulwahn
@ 2021-10-06 12:09 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2021-10-06 12:09 UTC (permalink / raw)
To: Lukas Bulwahn, Andrew Morton, Michal Hocko, Dave Hansen, linux-mm
Cc: kernel-janitors, linux-kernel
On 06.10.21 14:03, Lukas Bulwahn wrote:
> Commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove
> functions") defines CONFIG_MEM_BLOCK_SIZE, but this has never been
> utilized anywhere.
>
> It is a good practice to keep the CONFIG_* defines exclusively for the
> Kbuild system. So, drop this unused definition.
>
> This issue was noticed due to running ./scripts/checkkconfigsymbols.py.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> include/linux/memory.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index c46ff374d48d..a216829df280 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -143,7 +143,6 @@ typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
> extern int walk_memory_blocks(unsigned long start, unsigned long size,
> void *arg, walk_memory_blocks_func_t func);
> extern int for_each_memory_block(void *arg, walk_memory_blocks_func_t func);
> -#define CONFIG_MEM_BLOCK_SIZE (PAGES_PER_SECTION<<PAGE_SHIFT)
>
> extern int memory_group_register_static(int nid, unsigned long max_pages);
> extern int memory_group_register_dynamic(int nid, unsigned long unit_pages);
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 12:03 [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE Lukas Bulwahn
2021-10-06 12:09 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).