* [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC
@ 2008-02-03 5:59 Li Zefan
2008-02-04 0:47 ` Li Zefan
0 siblings, 1 reply; 5+ messages in thread
From: Li Zefan @ 2008-02-03 5:59 UTC (permalink / raw)
To: David Miller; +Cc: linux-net, LKML
compile error building without CONFIG_FS_PROC.
net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_
init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_
exit'
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
include/net/ip_fib.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 90d1175..af5e985 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -267,5 +267,13 @@ static inline void fib_res_put(struct fib_result *res)
extern int __net_init fib_proc_init(struct net *net);
extern void __net_exit fib_proc_exit(struct net *net);
#endif
+static inline int fib_proc_init(struct net *net)
+{
+ return 0;
+}
+static inline int fib_proc_exit(struct net *net)
+{
+ return 0;
+}
#endif /* _NET_FIB_H */
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC
2008-02-03 5:59 [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC Li Zefan
@ 2008-02-04 0:47 ` Li Zefan
2008-02-04 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
0 siblings, 1 reply; 5+ messages in thread
From: Li Zefan @ 2008-02-04 0:47 UTC (permalink / raw)
To: David Miller; +Cc: linux-net, LKML
compile error building without CONFIG_FS_PROC.
net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_
init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_
exit'
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
The exit method should have no return values...
---
include/net/ip_fib.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 90d1175..69393e3 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -267,5 +267,12 @@ static inline void fib_res_put(struct fib_result *res)
extern int __net_init fib_proc_init(struct net *net);
extern void __net_exit fib_proc_exit(struct net *net);
#endif
+static inline int fib_proc_init(struct net *net)
+{
+ return 0;
+}
+static inline void fib_proc_exit(struct net *net)
+{
+}
#endif /* _NET_FIB_H */
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC
2008-02-04 0:47 ` Li Zefan
@ 2008-02-04 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
2008-02-04 3:16 ` Li Zefan
0 siblings, 1 reply; 5+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2008-02-04 2:25 UTC (permalink / raw)
To: lizf; +Cc: davem, linux-net, linux-kernel, yoshfuji
In article <47A660A1.5080504@cn.fujitsu.com> (at Mon, 04 Feb 2008 08:47:29 +0800), Li Zefan <lizf@cn.fujitsu.com> says:
> compile error building without CONFIG_FS_PROC.
:
> The exit method should have no return values...
Have you really tested this with CONFIG_FS_PROC?
--yoshfuji
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC
2008-02-04 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
@ 2008-02-04 3:16 ` Li Zefan
2008-02-05 10:55 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Li Zefan @ 2008-02-04 3:16 UTC (permalink / raw)
To: yoshfuji; +Cc: davem, linux-net, linux-kernel
YOSHIFUJI Hideaki wrote:
> In article <47A660A1.5080504@cn.fujitsu.com> (at Mon, 04 Feb 2008 08:47:29 +0800), Li Zefan <lizf@cn.fujitsu.com> says:
>
>> compile error building without CONFIG_FS_PROC.
> :
>> The exit method should have no return values...
>
> Have you really tested this with CONFIG_FS_PROC?
>
> --yoshfuji
>
>
Oops, shame on me, what a silly patch... :( I tested it without CONFIG_PROC_PS,
but didn't test it with CONFIG_PROC_FS.
Now I've tested the new patch both with and without CONFIG_PROC_FS.
---
compile error building without CONFIG_FS_PROC:
net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_
init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_
exit'
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
include/net/ip_fib.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 90d1175..8b12667 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -266,6 +266,14 @@ static inline void fib_res_put(struct fib_result *res)
#ifdef CONFIG_PROC_FS
extern int __net_init fib_proc_init(struct net *net);
extern void __net_exit fib_proc_exit(struct net *net);
+#else
+static inline int fib_proc_init(struct net *net)
+{
+ return 0;
+}
+static inline void fib_proc_exit(struct net *net)
+{
+}
#endif
#endif /* _NET_FIB_H */
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC
2008-02-04 3:16 ` Li Zefan
@ 2008-02-05 10:55 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2008-02-05 10:55 UTC (permalink / raw)
To: lizf; +Cc: yoshfuji, linux-net, linux-kernel
From: Li Zefan <lizf@cn.fujitsu.com>
Date: Mon, 04 Feb 2008 11:16:24 +0800
> compile error building without CONFIG_FS_PROC:
>
> net/ipv4/fib_frontend.c: In function 'fib_net_init':
> net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_
> init'
> net/ipv4/fib_frontend.c: In function 'fib_net_exit':
> net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_
> exit'
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-05 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-03 5:59 [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC Li Zefan
2008-02-04 0:47 ` Li Zefan
2008-02-04 2:25 ` YOSHIFUJI Hideaki / 吉藤英明
2008-02-04 3:16 ` Li Zefan
2008-02-05 10:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).