* [2.6 patch] scsi_transport_iscsi.c: make 2 functions static
@ 2008-02-13 21:30 Adrian Bunk
2008-02-14 18:30 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-13 21:30 UTC (permalink / raw)
To: Mike Christie, James Bottomley; +Cc: linux-scsi, linux-kernel
This patch makes the following needlessly global functions static:
- __iscsi_unblock_session()
- iscsi_session_state_name()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/scsi/scsi_transport_iscsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
c7b0a4c74538d3a53cd7325a5ad0f2ae774ebb94 diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index fac7534..9981682 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -231,7 +231,7 @@ static struct {
{ ISCSI_SESSION_FREE, "FREE" },
};
-const char *iscsi_session_state_name(int state)
+static const char *iscsi_session_state_name(int state)
{
int i;
char *name = NULL;
@@ -373,7 +373,7 @@ static void session_recovery_timedout(struct work_struct *work)
scsi_target_unblock(&session->dev);
}
-void __iscsi_unblock_session(struct iscsi_cls_session *session)
+static void __iscsi_unblock_session(struct iscsi_cls_session *session)
{
if (!cancel_delayed_work(&session->recovery_work))
flush_workqueue(iscsi_eh_timer_workq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] scsi_transport_iscsi.c: make 2 functions static
2008-02-13 21:30 [2.6 patch] scsi_transport_iscsi.c: make 2 functions static Adrian Bunk
@ 2008-02-14 18:30 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2008-02-14 18:30 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James Bottomley, linux-scsi, linux-kernel
Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - __iscsi_unblock_session()
> - iscsi_session_state_name()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Looks good. Thanks.
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-14 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-13 21:30 [2.6 patch] scsi_transport_iscsi.c: make 2 functions static Adrian Bunk
2008-02-14 18:30 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).