From: Tsuchiya Yuto <kitakar@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Brian Norris <briannorris@chromium.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Xinming Hu <huxinming820@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
verdre@v0yd.nl
Subject: Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter
Date: Mon, 02 Nov 2020 18:18:44 +0900 [thread overview]
Message-ID: <47e149dfbf84e685f8b81e4561b8c9fd375cbcb4.camel@gmail.com> (raw)
In-Reply-To: <20201030110246.GM4077@smile.fi.intel.com>
On Fri, 2020-10-30 at 13:02 +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 04:58:33PM +0900, Tsuchiya Yuto wrote:
> > On Wed, 2020-10-28 at 15:04 -0700, Brian Norris wrote:
>
> ...
>
> > On the other hand, I agree that I don't want to break the existing users.
> > As you mentioned in the reply to the first patch, I can set the default
> > value of this parameter depending on the chip id (88W8897) or DMI matching.
>
> Since it's a PCIe device you already have ID table where you may add a
> driver_data with what ever quirks are needed.
Sorry that my comment was misleading. I meant using the quirk framework
(that is based on DMI matching) I sent in another series. This applies
to the other replies from me.
However, thanks to your comment, I remembered that currently, the quirk
framework can be used only within pcie.c file. For example, the quirk
initialization is currently done in pcie.c file. The mwifiex driver is
divided into interface-specific modules (PCIe, SDIO, USB) (e.g.,
mwifiex_pcie module for PCIe interface) + common module (mwifiex module).
So, I need to extend the quirk framework so that it can be used by the
mwifiex module globally.
I'll make a v2 version of this series with using the updated quirk
framework so that it won't change behaviors for existing users.
next prev parent reply other threads:[~2020-11-02 9:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:24 [PATCH 0/3] mwifiex: disable ps_mode by default for stability Tsuchiya Yuto
2020-10-28 14:24 ` [PATCH 1/3] mwifiex: disable ps_mode explicitly by default instead Tsuchiya Yuto
2020-10-29 18:25 ` Brian Norris
2020-10-29 18:36 ` Andy Shevchenko
2020-10-29 18:56 ` Brian Norris
2020-10-30 8:04 ` Tsuchiya Yuto
2020-11-20 21:04 ` Brian Norris
2020-11-26 19:44 ` Tsuchiya Yuto
2020-10-28 14:24 ` [PATCH 2/3] mwifiex: add allow_ps_mode module parameter Tsuchiya Yuto
2020-10-28 22:04 ` Brian Norris
2020-10-29 17:04 ` Willem de Bruijn
2020-10-30 8:02 ` Tsuchiya Yuto
2020-10-30 7:58 ` Tsuchiya Yuto
2020-10-30 11:02 ` Andy Shevchenko
2020-11-02 9:18 ` Tsuchiya Yuto [this message]
2020-10-28 14:24 ` [PATCH 3/3] mwifiex: print message when changing ps_mode Tsuchiya Yuto
[not found] ` <20201028152115.GT4077@smile.fi.intel.com>
2020-10-30 8:26 ` [PATCH 0/3] mwifiex: disable ps_mode by default for stability Tsuchiya Yuto
2020-12-20 21:43 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e149dfbf84e685f8b81e4561b8c9fd375cbcb4.camel@gmail.com \
--to=kitakar@gmail.com \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).