linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Cleanups in rtl8723bs
@ 2019-04-15 20:27 Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex Madhumitha Prabakaran
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-04-15 20:27 UTC (permalink / raw)
  To: gregkh, devel, linux-kernel; +Cc: Madhumitha Prabakaran

Patch 1 and 2 remove typedef in structures. Patch 3 remove unused
structure.

Madhumitha Prabakaran (3):
  Staging: rtl8723bs: Remove typedef in struct ieee_param_ex
  Staging: rtl8723bs: Remove typedef in struct ieee_param
  Staging: rtl8723bs: Remove an unused struct tx_pending_t

 drivers/staging/rtl8723bs/include/ieee80211.h | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex
  2019-04-15 20:27 [PATCH 0/3] Cleanups in rtl8723bs Madhumitha Prabakaran
@ 2019-04-15 20:27 ` Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 2/3] Staging: rtl8723bs: Remove typedef in struct ieee_param Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 3/3] Staging: rtl8723bs: Remove an unused struct tx_pending_t Madhumitha Prabakaran
  2 siblings, 0 replies; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-04-15 20:27 UTC (permalink / raw)
  To: gregkh, devel, linux-kernel; +Cc: Madhumitha Prabakaran

Remove typedef in struct ieee_param_ex, as the struct that
has elements that can reasonably be directly accessed should
never be a typedef.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 9efb4dcb9d3a..8077465402c6 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -242,11 +242,11 @@ typedef struct ieee_param {
 	} u;
 }ieee_param;
 
-typedef struct ieee_param_ex {
+struct ieee_param_ex {
 	u32 cmd;
 	u8 sta_addr[ETH_ALEN];
 	u8 data[0];
-}ieee_param_ex;
+};
 
 struct sta_data{
 	u16 aid;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] Staging: rtl8723bs: Remove typedef in struct ieee_param
  2019-04-15 20:27 [PATCH 0/3] Cleanups in rtl8723bs Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex Madhumitha Prabakaran
@ 2019-04-15 20:27 ` Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 3/3] Staging: rtl8723bs: Remove an unused struct tx_pending_t Madhumitha Prabakaran
  2 siblings, 0 replies; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-04-15 20:27 UTC (permalink / raw)
  To: gregkh, devel, linux-kernel; +Cc: Madhumitha Prabakaran

Remove typedef in struct ieee_param, as the struct that
has elements that can reasonably be directly accessed
should never be a typedef.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 8077465402c6..1327728e6dff 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -202,7 +202,7 @@ enum NETWORK_TYPE
 #define IsSupportedVHT(NetType) (((NetType) & (WIRELESS_11AC)) ? true : false)
 
 
-typedef struct ieee_param {
+struct ieee_param {
 	u32 cmd;
 	u8 sta_addr[ETH_ALEN];
 	union {
@@ -240,7 +240,7 @@ typedef struct ieee_param {
 			u8 buf[0];
 		} bcn_ie;
 	} u;
-}ieee_param;
+};
 
 struct ieee_param_ex {
 	u32 cmd;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] Staging: rtl8723bs: Remove an unused struct tx_pending_t
  2019-04-15 20:27 [PATCH 0/3] Cleanups in rtl8723bs Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex Madhumitha Prabakaran
  2019-04-15 20:27 ` [PATCH 2/3] Staging: rtl8723bs: Remove typedef in struct ieee_param Madhumitha Prabakaran
@ 2019-04-15 20:27 ` Madhumitha Prabakaran
  2 siblings, 0 replies; 4+ messages in thread
From: Madhumitha Prabakaran @ 2019-04-15 20:27 UTC (permalink / raw)
  To: gregkh, devel, linux-kernel; +Cc: Madhumitha Prabakaran

Remove an unused struct tx_pending_t, as it is never used in
kernel tree.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index 1327728e6dff..74c028fbe8f7 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -870,13 +870,6 @@ static inline int is_zero_mac_addr(const u8 *addr)
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)
 
-typedef struct tx_pending_t{
-	int frag;
-	struct ieee80211_txb *txb;
-}tx_pending_t;
-
-
-
 #define MAXTID	16
 
 #define IEEE_A            (1<<0)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-15 20:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 20:27 [PATCH 0/3] Cleanups in rtl8723bs Madhumitha Prabakaran
2019-04-15 20:27 ` [PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex Madhumitha Prabakaran
2019-04-15 20:27 ` [PATCH 2/3] Staging: rtl8723bs: Remove typedef in struct ieee_param Madhumitha Prabakaran
2019-04-15 20:27 ` [PATCH 3/3] Staging: rtl8723bs: Remove an unused struct tx_pending_t Madhumitha Prabakaran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).