linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: davem@davemloft.net, LKML <linux-kernel@vger.kernel.org>,
	Andreas Ziegler <ziegler@cs.fau.de>
Subject: Re: fou: dead build rule for fou6.o
Date: Tue, 31 May 2016 15:18:34 +0200	[thread overview]
Message-ID: <4806183.jXJkFW1R6y@wuerfel> (raw)
In-Reply-To: <CAD3Xx4+RZm6JYoQfJAZmpnUKisEJU=fx0_vMQEaPSnjhP-sBUg@mail.gmail.com>

On Tuesday, May 31, 2016 8:25:40 AM CEST Valentin Rothberg wrote:
> Hi Arnd,
> 
> your commit fabb13db448e ("fou: add Kconfig options for IPv6 support")
> has shown up in today's linux-next. ./scripts/checkkconfigsymbols.py
> warned because of the following statement in net/ipv6/Makefile:
> 
> +obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o
> 
> The referenced Kconfig option does not exist, but I assume the right
> option is 'IPV6_FOU_TUNNEL'?  In case yes, the modified #if block in
> the commit could be removed (redundant check).

I found another mistake that was hidden by the one you found.
The option controlling the file is IPV6_TUNNEL, not INET6_TUNNEL.
I'm currently testing with the patch below to address both bugs.

	Arnd

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 994608263260..2343e4f2e0bf 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -239,7 +239,7 @@ config IPV6_FOU
 config IPV6_FOU_TUNNEL
 	tristate
 	default NET_FOU_IP_TUNNELS && IPV6_FOU
-	select INET6_TUNNEL
+	select IPV6_TUNNEL
 
 config IPV6_MULTIPLE_TABLES
 	bool "IPv6: Multiple Routing Tables"
diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile
index d42ca3d1197f..6d8ea099213e 100644
--- a/net/ipv6/Makefile
+++ b/net/ipv6/Makefile
@@ -42,7 +42,7 @@ obj-$(CONFIG_IPV6_VTI) += ip6_vti.o
 obj-$(CONFIG_IPV6_SIT) += sit.o
 obj-$(CONFIG_IPV6_TUNNEL) += ip6_tunnel.o
 obj-$(CONFIG_IPV6_GRE) += ip6_gre.o
-obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o
+obj-$(CONFIG_IPV6_FOU) += fou6.o
 
 obj-y += addrconf_core.o exthdrs_core.o ip6_checksum.o ip6_icmp.o
 obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6-offload)

  parent reply	other threads:[~2016-05-31 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31  6:25 fou: dead build rule for fou6.o Valentin Rothberg
2016-05-31 10:08 ` Arnd Bergmann
2016-05-31 13:18 ` Arnd Bergmann [this message]
2016-05-31 20:43 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4806183.jXJkFW1R6y@wuerfel \
    --to=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valentinrothberg@gmail.com \
    --cc=ziegler@cs.fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).