From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, sathyanarayana.nujella@intel.com,
Adam.Thomson.Opensource@diasemi.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe
Date: Mon, 9 Apr 2018 13:57:43 -0500 [thread overview]
Message-ID: <482591fb-bf12-2e0a-e0ef-2ae0b4095000@linux.intel.com> (raw)
In-Reply-To: <1523270781-22627-1-git-send-email-baijiaju1990@gmail.com>
On 4/9/18 5:46 AM, Jia-Ju Bai wrote:
> broxton_audio_probe() is never called in atomic context.
> This function is only set as ".probe" in "struct platform_driver".
>
> Despite never getting called from atomic context,
> broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
> which waits busily for allocation.
> GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
> to avoid busy waiting and improve the possibility of sucessful allocation.
[answering for the series]
Humm, this is interesting.
If indeed we can afford to sleep then the change should be done on ALL
14 boards in sound/soc/intel/boards which follow the same code pattern.
If we cannot sleep then then none of these changes should be applied.
Liam and Vinod?
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> sound/soc/intel/boards/bxt_da7219_max98357a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c b/sound/soc/intel/boards/bxt_da7219_max98357a.c
> index ce35ec7..f4361b7 100644
> --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c
> @@ -585,7 +585,7 @@ static int broxton_audio_probe(struct platform_device *pdev)
> {
> struct bxt_card_private *ctx;
>
> - ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
> + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
> if (!ctx)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2018-04-09 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:46 [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe Jia-Ju Bai
2018-04-09 18:57 ` Pierre-Louis Bossart [this message]
2018-04-09 19:39 ` [alsa-devel] " Takashi Iwai
2018-04-10 14:02 ` Mark Brown
2018-04-10 14:17 ` Vinod Koul
2018-04-13 10:41 ` Mark Brown
2018-04-13 10:54 ` Jia-Ju Bai
2018-04-13 10:55 ` Mark Brown
2018-04-13 10:56 ` Applied "ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe" to the asoc tree Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482591fb-bf12-2e0a-e0ef-2ae0b4095000@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).