From: Takashi Iwai <tiwai@suse.de>
To: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
Cc: <Adam.Thomson.Opensource@diasemi.com>,
"Jia-Ju Bai" <baijiaju1990@gmail.com>, <lgirdwood@gmail.com>,
<sathyanarayana.nujella@intel.com>, <broonie@kernel.org>,
<perex@perex.cz>, <alsa-devel@alsa-project.org>,
"Vinod Koul" <vinod.koul@intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe
Date: Mon, 09 Apr 2018 21:39:06 +0200 [thread overview]
Message-ID: <s5h3704dvad.wl-tiwai@suse.de> (raw)
In-Reply-To: <482591fb-bf12-2e0a-e0ef-2ae0b4095000@linux.intel.com>
On Mon, 09 Apr 2018 20:57:43 +0200,
Pierre-Louis Bossart wrote:
>
> On 4/9/18 5:46 AM, Jia-Ju Bai wrote:
> > broxton_audio_probe() is never called in atomic context.
> > This function is only set as ".probe" in "struct platform_driver".
> >
> > Despite never getting called from atomic context,
> > broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
> > which waits busily for allocation.
> > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
> > to avoid busy waiting and improve the possibility of sucessful allocation.
>
> [answering for the series]
> Humm, this is interesting.
> If indeed we can afford to sleep then the change should be done on ALL
> 14 boards in sound/soc/intel/boards which follow the same code
> pattern.
> If we cannot sleep then then none of these changes should be applied.
> Liam and Vinod?
It must be sleepable context as it's a standard platform driver probe
callback.
And now looking at grep output, only sound/soc/intel contains so many
calls with GFP_ATOMIC. I bet that almost all can be done with
GFP_KERNEL, maybe only one or two in atom/sst would be conditionally
with GFP_ATOMIC.
thanks,
Takashi
next prev parent reply other threads:[~2018-04-09 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:46 [PATCH] sound: soc: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe Jia-Ju Bai
2018-04-09 18:57 ` [alsa-devel] " Pierre-Louis Bossart
2018-04-09 19:39 ` Takashi Iwai [this message]
2018-04-10 14:02 ` Mark Brown
2018-04-10 14:17 ` Vinod Koul
2018-04-13 10:41 ` Mark Brown
2018-04-13 10:54 ` Jia-Ju Bai
2018-04-13 10:55 ` Mark Brown
2018-04-13 10:56 ` Applied "ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe" to the asoc tree Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h3704dvad.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=baijiaju1990@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).