* No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" @ 2020-03-25 4:01 Qian Cai 2020-03-25 19:33 ` Moshe Shemesh 0 siblings, 1 reply; 5+ messages in thread From: Qian Cai @ 2020-03-25 4:01 UTC (permalink / raw) To: Vladyslav Tarasiuk Cc: Moshe Shemesh, Jiri Pirko, Saeed Mahameed, Parav Pandit, David S. Miller, netdev, LKML Reverted the linux-next commit c6acd629ee (“net/mlx5e: Add support for devlink-port in non-representors mode”) and its dependencies, 162add8cbae4 (“net/mlx5e: Use devlink virtual flavour for VF devlink port”) 31e87b39ba9d (“net/mlx5e: Fix devlink port register sequence”) on the top of next-20200324 allowed NICs to obtain an IPv4 address from DHCP again. 0b:00.0 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] 0b:00.1 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] [ 223.280777][ T13] mlx5_core 0000:0b:00.0: firmware version: 14.21.1000 [ 223.287753][ T13] mlx5_core 0000:0b:00.0: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) [ 226.292153][ C0] mlx5_core 0000:0b:00.0: Port module event: module 0, Cable plugged [ 226.874100][ T2023] mlx5_core 0000:0b:00.1: Adding to iommu group 2 [ 227.343553][ T13] mlx5_core 0000:0b:00.1: firmware version: 14.21.1000 [ 227.350467][ T13] mlx5_core 0000:0b:00.1: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) [ 230.026346][ C0] mlx5_core 0000:0b:00.1: Port module event: module 1, Cable unplugged [ 230.522660][ T2023] mlx5_core 0000:0b:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) [ 231.448493][ T2023] mlx5_core 0000:0b:00.1: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) [ 232.436993][ T2007] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed from eth1 [ 232.690895][ T2013] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed from eth0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" 2020-03-25 4:01 No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" Qian Cai @ 2020-03-25 19:33 ` Moshe Shemesh 2020-03-25 20:25 ` Qian Cai 0 siblings, 1 reply; 5+ messages in thread From: Moshe Shemesh @ 2020-03-25 19:33 UTC (permalink / raw) To: Qian Cai, Vladyslav Tarasiuk Cc: Jiri Pirko, Saeed Mahameed, Parav Pandit, David S. Miller, netdev, LKML On 3/25/2020 6:01 AM, Qian Cai wrote: > Reverted the linux-next commit c6acd629ee (“net/mlx5e: Add support for devlink-port in non-representors mode”) > and its dependencies, > > 162add8cbae4 (“net/mlx5e: Use devlink virtual flavour for VF devlink port”) > 31e87b39ba9d (“net/mlx5e: Fix devlink port register sequence”) > > on the top of next-20200324 allowed NICs to obtain an IPv4 address from DHCP again. These patches should not interfere DHCP. You might have dependencies on interface name which was changed by this patch, please check. > 0b:00.0 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] > 0b:00.1 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] > > [ 223.280777][ T13] mlx5_core 0000:0b:00.0: firmware version: 14.21.1000 > [ 223.287753][ T13] mlx5_core 0000:0b:00.0: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) > [ 226.292153][ C0] mlx5_core 0000:0b:00.0: Port module event: module 0, Cable plugged > [ 226.874100][ T2023] mlx5_core 0000:0b:00.1: Adding to iommu group 2 > [ 227.343553][ T13] mlx5_core 0000:0b:00.1: firmware version: 14.21.1000 > [ 227.350467][ T13] mlx5_core 0000:0b:00.1: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) > [ 230.026346][ C0] mlx5_core 0000:0b:00.1: Port module event: module 1, Cable unplugged > [ 230.522660][ T2023] mlx5_core 0000:0b:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) > [ 231.448493][ T2023] mlx5_core 0000:0b:00.1: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) > [ 232.436993][ T2007] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed from eth1 > [ 232.690895][ T2013] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed from eth0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" 2020-03-25 19:33 ` Moshe Shemesh @ 2020-03-25 20:25 ` Qian Cai 2020-03-26 0:17 ` Saeed Mahameed 0 siblings, 1 reply; 5+ messages in thread From: Qian Cai @ 2020-03-25 20:25 UTC (permalink / raw) To: Moshe Shemesh Cc: Vladyslav Tarasiuk, Jiri Pirko, Saeed Mahameed, Parav Pandit, David S. Miller, netdev, LKML > On Mar 25, 2020, at 3:33 PM, Moshe Shemesh <moshe@mellanox.com> wrote: > > > On 3/25/2020 6:01 AM, Qian Cai wrote: >> Reverted the linux-next commit c6acd629ee (“net/mlx5e: Add support for devlink-port in non-representors mode”) >> and its dependencies, >> >> 162add8cbae4 (“net/mlx5e: Use devlink virtual flavour for VF devlink port”) >> 31e87b39ba9d (“net/mlx5e: Fix devlink port register sequence”) >> >> on the top of next-20200324 allowed NICs to obtain an IPv4 address from DHCP again. > > > These patches should not interfere DHCP. > > You might have dependencies on interface name which was changed by this patch, please check. Yes, Before, [ 238.225149][ T2021] mlx5_core 0000:0b:00.1 enp11s0f1: renamed from eth1 [ 238.511324][ T2035] mlx5_core 0000:0b:00.0 enp11s0f0: renamed from eth0 Now, [ 234.448420][ T2013] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed from eth1 [ 234.664236][ T2042] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed from eth0 > >> 0b:00.0 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] >> 0b:00.1 Ethernet controller: Mellanox Technologies MT27710 Family [ConnectX-4 Lx] >> >> [ 223.280777][ T13] mlx5_core 0000:0b:00.0: firmware version: 14.21.1000 >> [ 223.287753][ T13] mlx5_core 0000:0b:00.0: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) >> [ 226.292153][ C0] mlx5_core 0000:0b:00.0: Port module event: module 0, Cable plugged >> [ 226.874100][ T2023] mlx5_core 0000:0b:00.1: Adding to iommu group 2 >> [ 227.343553][ T13] mlx5_core 0000:0b:00.1: firmware version: 14.21.1000 >> [ 227.350467][ T13] mlx5_core 0000:0b:00.1: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link) >> [ 230.026346][ C0] mlx5_core 0000:0b:00.1: Port module event: module 1, Cable unplugged >> [ 230.522660][ T2023] mlx5_core 0000:0b:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) >> [ 231.448493][ T2023] mlx5_core 0000:0b:00.1: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0) >> [ 232.436993][ T2007] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed from eth1 >> [ 232.690895][ T2013] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed from eth0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" 2020-03-25 20:25 ` Qian Cai @ 2020-03-26 0:17 ` Saeed Mahameed 2020-03-26 3:18 ` Qian Cai 0 siblings, 1 reply; 5+ messages in thread From: Saeed Mahameed @ 2020-03-26 0:17 UTC (permalink / raw) To: cai, Moshe Shemesh Cc: Jiri Pirko, linux-kernel, davem, Parav Pandit, Vladyslav Tarasiuk, netdev On Wed, 2020-03-25 at 16:25 -0400, Qian Cai wrote: > > On Mar 25, 2020, at 3:33 PM, Moshe Shemesh <moshe@mellanox.com> > > wrote: > > > > > > On 3/25/2020 6:01 AM, Qian Cai wrote: > > > Reverted the linux-next commit c6acd629ee (“net/mlx5e: Add > > > support for devlink-port in non-representors mode”) > > > and its dependencies, > > > > > > 162add8cbae4 (“net/mlx5e: Use devlink virtual flavour for VF > > > devlink port”) > > > 31e87b39ba9d (“net/mlx5e: Fix devlink port register sequence”) > > > > > > on the top of next-20200324 allowed NICs to obtain an IPv4 > > > address from DHCP again. > > > > These patches should not interfere DHCP. > > > > You might have dependencies on interface name which was changed by > > this patch, please check. > > Yes, > > Before, > [ 238.225149][ T2021] mlx5_core 0000:0b:00.1 enp11s0f1: renamed from > eth1 > [ 238.511324][ T2035] mlx5_core 0000:0b:00.0 enp11s0f0: renamed from > eth0 > > Now, > [ 234.448420][ T2013] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed > from eth1 > [ 234.664236][ T2042] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed > from eth0 > it is not a good idea to use the interface name as a unique identifier, this is not resilient for kernel updates or configuration updates, e.g installing an extra card Just use the HW mac address as a unique identifier in the network scripts: from [1]: HWADDR=MAC-address where MAC-address is the hardware address of the Ethernet device in the form AA:BB:CC:DD:EE:FF. This directive must be used in machines containing more than one NIC to ensure that the interfaces are assigned the correct device names regardless of the configured load order for each NIC's module. [1] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/s1-networkscripts-interfaces ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" 2020-03-26 0:17 ` Saeed Mahameed @ 2020-03-26 3:18 ` Qian Cai 0 siblings, 0 replies; 5+ messages in thread From: Qian Cai @ 2020-03-26 3:18 UTC (permalink / raw) To: Saeed Mahameed Cc: Moshe Shemesh, Jiri Pirko, linux-kernel, davem, Parav Pandit, Vladyslav Tarasiuk, netdev > On Mar 25, 2020, at 8:17 PM, Saeed Mahameed <saeedm@mellanox.com> wrote: > > On Wed, 2020-03-25 at 16:25 -0400, Qian Cai wrote: >>> On Mar 25, 2020, at 3:33 PM, Moshe Shemesh <moshe@mellanox.com> >>> wrote: >>> >>> >>> On 3/25/2020 6:01 AM, Qian Cai wrote: >>>> Reverted the linux-next commit c6acd629ee (“net/mlx5e: Add >>>> support for devlink-port in non-representors mode”) >>>> and its dependencies, >>>> >>>> 162add8cbae4 (“net/mlx5e: Use devlink virtual flavour for VF >>>> devlink port”) >>>> 31e87b39ba9d (“net/mlx5e: Fix devlink port register sequence”) >>>> >>>> on the top of next-20200324 allowed NICs to obtain an IPv4 >>>> address from DHCP again. >>> >>> These patches should not interfere DHCP. >>> >>> You might have dependencies on interface name which was changed by >>> this patch, please check. >> >> Yes, >> >> Before, >> [ 238.225149][ T2021] mlx5_core 0000:0b:00.1 enp11s0f1: renamed from >> eth1 >> [ 238.511324][ T2035] mlx5_core 0000:0b:00.0 enp11s0f0: renamed from >> eth0 >> >> Now, >> [ 234.448420][ T2013] mlx5_core 0000:0b:00.1 enp11s0f1np1: renamed >> from eth1 >> [ 234.664236][ T2042] mlx5_core 0000:0b:00.0 enp11s0f0np0: renamed >> from eth0 >> > > it is not a good idea to use the interface name as a unique identifier, > this is not resilient for kernel updates or configuration updates, e.g > installing an extra card > > Just use the HW mac address as a unique identifier in the network > scripts: > > from [1]: > HWADDR=MAC-address > where MAC-address is the hardware address of the Ethernet device in the > form AA:BB:CC:DD:EE:FF. This directive must be used in machines > containing more than one NIC to ensure that the interfaces are assigned > the correct device names regardless of the configured load order for > each NIC's module. > > [1] > https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/s1-networkscripts-interfaces Is it really necessary to cause a device naming change? The installer/NetworkManager here (annaconda) will create those files automatically. They don’t usually use hard-coded HWADDR. Ironically, it is RHEL-8.1. # cat /etc/sysconfig/network-scripts/ifcfg-enp11s0f0 # Generated by dracut initrd NAME="enp11s0f0" DEVICE="enp11s0f0" ONBOOT=yes NETBOOT=yes UUID="be2237f3-e40b-4404-be6c-bcb484dbebf6" IPV6INIT=yes BOOTPROTO=dhcp TYPE=Ethernet # cat /etc/sysconfig/network-scripts/ifcfg-enp11s0f1 TYPE=Ethernet PROXY_METHOD=none BROWSER_ONLY=no BOOTPROTO=dhcp DEFROUTE=yes IPV4_FAILURE_FATAL=no IPV6INIT=yes IPV6_AUTOCONF=yes IPV6_DEFROUTE=yes IPV6_FAILURE_FATAL=no IPV6_ADDR_GEN_MODE=stable-privacy NAME=enp11s0f1 UUID=400773fc-5436-4a85-9cee-a8e18cee9230 DEVICE=enp11s0f1 ONBOOT=no Imagining a kernel update from enterprise distros contain those patches which would break all those existing setup. It is trivial for me to fix myself, but it could be a different story for those customers with thousand of machines need to change. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-26 3:18 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-25 4:01 No networking due to "net/mlx5e: Add support for devlink-port in non-representors mode" Qian Cai 2020-03-25 19:33 ` Moshe Shemesh 2020-03-25 20:25 ` Qian Cai 2020-03-26 0:17 ` Saeed Mahameed 2020-03-26 3:18 ` Qian Cai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).