From: David Howells <dhowells@redhat.com>
To: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, David Woodhouse <dwmw2@infradead.org>,
keyrings <keyrings@vger.kernel.org>,
LSM <linux-security-module@vger.kernel.org>,
kernel <linux-kernel@vger.kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
George Wilson <gcwilson@us.ibm.com>
Subject: Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage
Date: Fri, 28 Apr 2017 16:47:37 +0100 [thread overview]
Message-ID: <486.1493394457@warthog.procyon.org.uk> (raw)
In-Reply-To: <73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com>
Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote:
> >> + /* TODO: update CRC */
> >
> > Is this bit missing?
>
> I didn't add it, since I wasn't sure it was still used with secure boot.
I'm not sure why secure boot would skip it if normal boot does it. You'll
have to trawl the boot wrapper and kernel arch setup code to answer that one.
> The CRC code is implemented in multiple places, but not exposed to the
> tools/scripts. Should I make the crc32() in tools/pcmcia/crc32hash.c
> non-static, maybe?
Making it non-static won't help since it's a standalone program. You could
just shift it to scripts or something.
David
next prev parent reply other threads:[~2017-04-28 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 22:28 [PATCH v4 0/4] Certificate insertion support for x86 bzImages Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 1/4] KEYS: Insert incompressible bytes to reserve space in bzImage Mehmet Kayaalp
2017-04-20 23:13 ` Henrique de Moraes Holschuh
2017-04-21 0:22 ` Mehmet Kayaalp
2017-04-21 19:47 ` Henrique de Moraes Holschuh
2017-04-20 22:28 ` [PATCH v4 2/4] KEYS: Add ELF class-independent certificate insertion support Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 4/4] KEYS: Print insert-sys-cert information to stdout instead of stderr Mehmet Kayaalp
2017-04-27 13:54 ` [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage David Howells
2017-04-27 19:06 ` Mehmet Kayaalp
2017-04-28 15:47 ` David Howells [this message]
2017-04-27 13:57 ` [PATCH v4 4/4] KEYS: Print insert-sys-cert information to stdout instead of stderr David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486.1493394457@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gcwilson@us.ibm.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mkayaalp@linux.vnet.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).