From: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
keyrings <keyrings@vger.kernel.org>,
LSM <linux-security-module@vger.kernel.org>,
kernel <linux-kernel@vger.kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
George Wilson <gcwilson@us.ibm.com>
Subject: Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage
Date: Thu, 27 Apr 2017 15:06:34 -0400 [thread overview]
Message-ID: <73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com> (raw)
In-Reply-To: <13470.1493301291@warthog.procyon.org.uk>
> On Apr 27, 2017, at 9:54 AM, David Howells <dhowells@redhat.com> wrote:
>
> Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote:
>
>> + /* TODO: update CRC */
>
> Is this bit missing?
I didn't add it, since I wasn't sure it was still used with secure boot. The CRC
code is implemented in multiple places, but not exposed to the tools/scripts.
Should I make the crc32() in tools/pcmcia/crc32hash.c non-static, maybe?
Mehmet
next prev parent reply other threads:[~2017-04-27 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 22:28 [PATCH v4 0/4] Certificate insertion support for x86 bzImages Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 1/4] KEYS: Insert incompressible bytes to reserve space in bzImage Mehmet Kayaalp
2017-04-20 23:13 ` Henrique de Moraes Holschuh
2017-04-21 0:22 ` Mehmet Kayaalp
2017-04-21 19:47 ` Henrique de Moraes Holschuh
2017-04-20 22:28 ` [PATCH v4 2/4] KEYS: Add ELF class-independent certificate insertion support Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage Mehmet Kayaalp
2017-04-20 22:28 ` [PATCH v4 4/4] KEYS: Print insert-sys-cert information to stdout instead of stderr Mehmet Kayaalp
2017-04-27 13:54 ` [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage David Howells
2017-04-27 19:06 ` Mehmet Kayaalp [this message]
2017-04-28 15:47 ` David Howells
2017-04-27 13:57 ` [PATCH v4 4/4] KEYS: Print insert-sys-cert information to stdout instead of stderr David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com \
--to=mkayaalp@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gcwilson@us.ibm.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).