From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-kernel@vger.kernel.org, Aren Moynihan <aren@peacevolution.org>
Cc: Miles Alan <m@milesalan.com>, Ondrej Jirman <megi@xff.cz>,
Aren Moynihan <aren@peacevolution.org>,
Chen-Yu Tsai <wens@csie.org>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Samuel Holland <samuel@sholland.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node
Date: Tue, 30 Jan 2024 20:41:14 +0100 [thread overview]
Message-ID: <4864457.GXAFRqVoOG@jernej-laptop> (raw)
In-Reply-To: <20240128204740.2355092-3-aren@peacevolution.org>
Dne nedelja, 28. januar 2024 ob 21:45:09 CET je Aren Moynihan napisal(a):
> The red, green, and blue leds currently in the device tree represent a
> single rgb led on the front of the PinePhone.
>
> Signed-off-by: Aren Moynihan <aren@peacevolution.org>
> ---
>
> .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index ad2476ee01e4..6eab61a12cd8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -39,21 +39,21 @@ chosen {
> leds {
> compatible = "gpio-leds";
>
> - led-0 {
> + led0: led-0 {
> function = LED_FUNCTION_INDICATOR;
> color = <LED_COLOR_ID_BLUE>;
> gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */
> retain-state-suspended;
> };
>
> - led-1 {
> + led1: led-1 {
> function = LED_FUNCTION_INDICATOR;
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */
> retain-state-suspended;
> };
>
> - led-2 {
> + led2: led-2 {
> function = LED_FUNCTION_INDICATOR;
> color = <LED_COLOR_ID_RED>;
> gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */
> @@ -61,6 +61,13 @@ led-2 {
> };
> };
>
> + multi-led {
> + compatible = "leds-group-multicolor";
> + color = <LED_COLOR_ID_RGB>;
> + function = LED_FUNCTION_INDICATOR;
Does it make sense to have function specified here and above? Example
specifies it only in multi-led node.
Best regards,
Jernej
> + leds = <&led0>, <&led1>, <&led2>;
> + };
> +
> reg_ps: ps-regulator {
> compatible = "regulator-fixed";
> regulator-name = "ps";
>
next prev parent reply other threads:[~2024-01-30 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 20:45 [PATCH 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Aren Moynihan
2024-01-28 20:45 ` [PATCH 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state " Aren Moynihan
2024-01-30 19:06 ` Jernej Škrabec
2024-02-01 1:36 ` Aren
2024-02-01 19:54 ` Jernej Škrabec
2024-01-28 20:45 ` [PATCH 3/4] arm64: dts: sun50i-a64-pinephone: add multicolor led node Aren Moynihan
2024-01-30 19:41 ` Jernej Škrabec [this message]
2024-02-01 1:28 ` Aren
2024-01-28 20:45 ` [PATCH 4/4] arm64: dts: sun50i-a64-pinephone: change led type to status Aren Moynihan
2024-01-31 7:39 ` [PATCH 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend Jean-Jacques Hiblot
2024-02-01 1:39 ` Aren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4864457.GXAFRqVoOG@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=aren@peacevolution.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=m@milesalan.com \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).