[PATCH 1/2] x86: call early_cpu_init at the same point

[PATCH 1/2] x86: call early_cpu_init at the same point

[Jeremy Fitzhardinge]

Call early_cpu_init() at the same (early) point in setup_arch().
The x86_64 code was calling it relatively late, after when other arch
code need to do cpu-related setup which depends on it.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
 arch/x86/kernel/setup.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

===================================================================
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -597,11 +597,11 @@
 	memcpy(&boot_cpu_data, &new_cpu_data, sizeof(new_cpu_data));
 	visws_early_detect();
 	pre_setup_arch_hook();
-	early_cpu_init();
 #else
 	printk(KERN_INFO "Command line: %s\n", boot_command_line);
 #endif
 
+	early_cpu_init();
 	early_ioremap_init();
 
 	ROOT_DEV = old_decode_dev(boot_params.hdr.root_dev);
@@ -665,9 +665,6 @@
 	bss_resource.start = virt_to_phys(&__bss_start);
 	bss_resource.end = virt_to_phys(&__bss_stop)-1;
 
-#ifdef CONFIG_X86_64
-	early_cpu_init();
-#endif
 	strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
 	*cmdline_p = command_line;
 

Re: [PATCH 1/2] x86: call early_cpu_init at the same point

[Ingo Molnar]

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Call early_cpu_init() at the same (early) point in setup_arch(). The 
> x86_64 code was calling it relatively late, after when other arch code 
> need to do cpu-related setup which depends on it.

applied to tip/x86/urgent, thanks Jeremy.

	Ingo

Re: [PATCH 1/2] x86: call early_cpu_init at the same point

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Call early_cpu_init() at the same (early) point in setup_arch(). The 
>> x86_64 code was calling it relatively late, after when other arch code 
>> need to do cpu-related setup which depends on it.
>>     
>
> applied to tip/x86/urgent, thanks Jeremy.
>   

Thanks.  Curious to see if this causes any breakage, especially in 
numa-ish type systems.

    J

Re: [PATCH 1/2] x86: call early_cpu_init at the same point

[Ingo Molnar]

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>>
>>   
>>> Call early_cpu_init() at the same (early) point in setup_arch(). The  
>>> x86_64 code was calling it relatively late, after when other arch 
>>> code need to do cpu-related setup which depends on it.
>>>     
>>
>> applied to tip/x86/urgent, thanks Jeremy.
>
> Thanks.  Curious to see if this causes any breakage, especially in 
> numa-ish type systems.

no badness so far.

	Ingo