* [PATCH] omapfb: panel-sony-acx565akm: constify attribute_group structures.
@ 2017-07-19 5:25 ` Arvind Yadav
2017-08-01 14:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-19 5:25 UTC (permalink / raw)
To: tomi.valkeinen, b.zolnierkie; +Cc: linux-omap, linux-fbdev, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5227 560 0 5787 169b panel-sony-acx565akm
File size After adding 'const':
text data bss dec hex filename
5291 496 0 5787 169b panel-sony-acx565akm.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
index 468560a..f2c2fef 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
@@ -509,7 +509,7 @@ static DEVICE_ATTR(cabc_available_modes, S_IRUGO,
NULL,
};
-static struct attribute_group bldev_attr_group = {
+static const struct attribute_group bldev_attr_group = {
.attrs = bldev_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omapfb: panel-sony-acx565akm: constify attribute_group structures.
2017-07-19 5:25 ` [PATCH] omapfb: panel-sony-acx565akm: constify attribute_group structures Arvind Yadav
@ 2017-08-01 14:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-01 14:04 UTC (permalink / raw)
To: Arvind Yadav; +Cc: tomi.valkeinen, linux-omap, linux-fbdev, linux-kernel
On Wednesday, July 19, 2017 10:55:57 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 5227 560 0 5787 169b panel-sony-acx565akm
>
> File size After adding 'const':
> text data bss dec hex filename
> 5291 496 0 5787 169b panel-sony-acx565akm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-01 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170719052638epcas3p38153e17e63deab45c6d39fd1c56e3af2@epcas3p3.samsung.com>
2017-07-19 5:25 ` [PATCH] omapfb: panel-sony-acx565akm: constify attribute_group structures Arvind Yadav
2017-08-01 14:04 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).