From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Potin Lai <potin.lai@quantatw.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Patrick Williams <patrick@stwcx.xyz>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: Add sample averaging property for ADM1275
Date: Wed, 23 Feb 2022 18:14:55 +0100 [thread overview]
Message-ID: <4896ee6e-3395-8d67-8926-4a09f02d7cdd@canonical.com> (raw)
In-Reply-To: <20220223163817.30583-3-potin.lai@quantatw.com>
On 23/02/2022 17:38, Potin Lai wrote:
> Add binding information for "pwr-avg" and "vi-avg" properties
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
> ---
> .../devicetree/bindings/hwmon/adi,adm1275.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> index 223393d7cafd..2525a67a880e 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -37,6 +37,14 @@ properties:
> description:
> Shunt resistor value in micro-Ohm.
>
> + vi-avg:
> + description:
> + Sample averaging for current and voltage.
Both do not look like generic properties, so you need:
- type
- vendor prefix ("adi,")
- maximum value?
It would be nice to actually explain what this value means - number of
readings for each averaging (unless it is obvious in the domain...)?
Does the hardware have default value?
> +
> + pwr-avg:
> + description:
> + Sample averaging for power.
> +
> required:
> - compatible
> - reg
> @@ -53,5 +61,7 @@ examples:
> compatible = "adi,adm1272";
> reg = <0x10>;
> shunt-resistor-micro-ohms = <500>;
> + vi-avg = <128>;
> + pwr-avg = <128>;
> };
> };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-23 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 16:38 [PATCH 0/2] hwmon: (adm1275) Add sample averaging binding support Potin Lai
2022-02-23 16:38 ` [PATCH 1/2] hwmon: (adm1275) Allow setting sample averaging Potin Lai
2022-02-23 17:10 ` Guenter Roeck
2022-02-23 16:38 ` [PATCH 2/2] dt-bindings: hwmon: Add sample averaging property for ADM1275 Potin Lai
2022-02-23 17:14 ` Krzysztof Kozlowski [this message]
2022-02-23 17:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4896ee6e-3395-8d67-8926-4a09f02d7cdd@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).