* [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN
@ 2008-08-18 22:06 roel kluin
2008-08-19 13:02 ` Kou Ishizaki
0 siblings, 1 reply; 3+ messages in thread
From: roel kluin @ 2008-08-18 22:06 UTC (permalink / raw)
To: kou.ishizaki, paulus, benh, linuxppc-dev, linux-kernel
untested, is it correct?
---
arch/powerpc/platforms/cell/celleb_scc.h:224:
#define SCC_UHC_USBEN 0x00010000
#define SCC_UHC_USBCEN 0x00020000
---
diff --git a/arch/powerpc/platforms/cell/celleb_scc_uhc.c b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
index d63b720..b086f33 100644
--- a/arch/powerpc/platforms/cell/celleb_scc_uhc.c
+++ b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
@@ -31,7 +31,7 @@
static inline int uhc_clkctrl_ready(u32 val)
{
- const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
+ const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
return((val & mask) == mask);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN
2008-08-18 22:06 [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN roel kluin
@ 2008-08-19 13:02 ` Kou Ishizaki
2008-08-19 15:43 ` [PATCH v2] " roel kluin
0 siblings, 1 reply; 3+ messages in thread
From: Kou Ishizaki @ 2008-08-19 13:02 UTC (permalink / raw)
To: roel.kluin; +Cc: paulus, benh, linuxppc-dev, linux-kernel
Roel,
> untested, is it correct?
Your patch is correct.
Thanks for your pointing it out and sending the patch. I tested your
patch and it works good.
Fortunately, this bug is not fatal because it seems that the SCC-UHC
sets SCC_UHC_USBEN and SCC_UHC_USBCEN at once.
Your patch does not contain 'Signed-off-by' line. Could you re-post it
with your sign?
> ---
> arch/powerpc/platforms/cell/celleb_scc.h:224:
> #define SCC_UHC_USBEN 0x00010000
> #define SCC_UHC_USBCEN 0x00020000
>
> ---
> diff --git a/arch/powerpc/platforms/cell/celleb_scc_uhc.c b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> index d63b720..b086f33 100644
> --- a/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> +++ b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> @@ -31,7 +31,7 @@
>
> static inline int uhc_clkctrl_ready(u32 val)
> {
> - const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
> + const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
> return((val & mask) == mask);
> }
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
Best regards,
Kou Ishizaki
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] powerpc, scc: duplicate SCC_UHC_USBCEN
2008-08-19 13:02 ` Kou Ishizaki
@ 2008-08-19 15:43 ` roel kluin
0 siblings, 0 replies; 3+ messages in thread
From: roel kluin @ 2008-08-19 15:43 UTC (permalink / raw)
To: Kou Ishizaki; +Cc: paulus, benh, linuxppc-dev, linux-kernel
Kou Ishizaki wrote:
>
> Roel,
>
>> untested, is it correct?
>
> Your patch is correct.
>
> Thanks for your pointing it out and sending the patch. I tested your
> patch and it works good.
>
> Fortunately, this bug is not fatal because it seems that the SCC-UHC
> sets SCC_UHC_USBEN and SCC_UHC_USBCEN at once.
>
>
> Your patch does not contain 'Signed-off-by' line. Could you re-post it
> with your sign?
Sorry for that and thanks for testing.
---
duplicate SCC_UHC_USBCEN
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/powerpc/platforms/cell/celleb_scc_uhc.c b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
index d63b720..b086f33 100644
--- a/arch/powerpc/platforms/cell/celleb_scc_uhc.c
+++ b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
@@ -31,7 +31,7 @@
static inline int uhc_clkctrl_ready(u32 val)
{
- const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
+ const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
return((val & mask) == mask);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-19 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-18 22:06 [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN roel kluin
2008-08-19 13:02 ` Kou Ishizaki
2008-08-19 15:43 ` [PATCH v2] " roel kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).