* [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/
@ 2008-10-17 11:12 Zhaolei
2008-10-17 14:58 ` Ralf Baechle
2008-10-17 15:05 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Zhaolei @ 2008-10-17 11:12 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, linux-kernel
Hi,
debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
arch/mips/math-emu/cp1emu.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index b08fc65..7ec0b21 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -1299,12 +1299,12 @@ static int __init debugfs_fpuemu(void)
if (!mips_debugfs_dir)
return -ENODEV;
dir = debugfs_create_dir("fpuemustats", mips_debugfs_dir);
- if (IS_ERR(dir))
- return PTR_ERR(dir);
+ if (!dir)
+ return -ENOMEM;
for (i = 0; i < ARRAY_SIZE(vars); i++) {
d = debugfs_create_u32(vars[i].name, S_IRUGO, dir, vars[i].v);
- if (IS_ERR(d))
- return PTR_ERR(d);
+ if (!d)
+ return -ENOMEM;
}
return 0;
}
--
1.5.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/ Zhaolei
@ 2008-10-17 14:58 ` Ralf Baechle
2008-10-17 15:05 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-10-17 14:58 UTC (permalink / raw)
To: Zhaolei; +Cc: linux-mips, linux-kernel
On Fri, Oct 17, 2008 at 07:12:30PM +0800, Zhaolei wrote:
> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/ Zhaolei
2008-10-17 14:58 ` Ralf Baechle
@ 2008-10-17 15:05 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-10-17 15:05 UTC (permalink / raw)
To: Zhaolei; +Cc: linux-mips, linux-kernel
On Fri, Oct 17, 2008 at 07:12:30PM +0800, Zhaolei wrote:
> debugfs_create_*() returns NULL if an error occurs, returns -ENODEV
> when debugfs is not enabled in the kernel.
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-17 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-17 11:12 [PATCH] Fix debugfs_create_*'s error checking method for mips/math-emu/ Zhaolei
2008-10-17 14:58 ` Ralf Baechle
2008-10-17 15:05 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).