linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
	Andi Shyti <andi.shyti@samsung.com>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS_CRITICAL
Date: Fri, 20 Jan 2017 11:00:38 -0300	[thread overview]
Message-ID: <48a2f141-4275-cb79-aafd-62191d747107@osg.samsung.com> (raw)
In-Reply-To: <0ffa0d28-1086-887c-dcfc-590b6146b03e@samsung.com>

Hello Sylwester,

On 01/20/2017 10:55 AM, Sylwester Nawrocki wrote:
> On 01/20/2017 01:32 PM, Sylwester Nawrocki wrote:
>> On 01/20/2017 11:41 AM, Javier Martinez Canillas wrote:
>>> On Exynos5800 SoC the SCALER block uses 2 input clocks: CLK_ACLK_300_GSCL
>>> and CLK_ACLK432_SCALER, so both needs to be ungated in order to access it.
>>>
>>> But Exynos5420 only has the CLK_ACLK_300_GSCL as gsc_pd clk. So just using
>>> this definition from exynos5420.dtsi in Exynos5800 leads to the following:
>> [...]
>>> So until a proper solution based on runtime PM gets merged, mark the clock
>>> as critical to prevent it to be gated.
>>>
>>> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> Oops, the $subject patch can be dropped since as Marek just pointed out
> to me the changes introduced by that patch are already included in a patch
> which is already in the v4.10 fixes queue:
> 
> https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=318fa46cc60d37fec1e87dbf03a82aca0f5ce695
> 

Yes, I just answered to Marek in the other thread saying the same.
He did mention the patch could fix the issue but for some reason I
didn't see the CLK_ACLK_300_GSCL in the clocks marked as critical...

Anyways, sorry for the noise.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

  reply	other threads:[~2017-01-20 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170120104148epcas5p11af0e630f0881092a9b3b43e8b5b1aac@epcas5p1.samsung.com>
2017-01-20 10:41 ` [PATCH] clk: samsung: exynos5420: Mark CLK_ACLK432_SCALER as CLK_IS_CRITICAL Javier Martinez Canillas
2017-01-20 12:32   ` Sylwester Nawrocki
2017-01-20 13:55     ` Sylwester Nawrocki
2017-01-20 14:00       ` Javier Martinez Canillas [this message]
2017-01-20 14:07         ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48a2f141-4275-cb79-aafd-62191d747107@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=andi.shyti@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).