* [PATCH] drm/hisilicon/hibmc: remove an unused variable
@ 2021-07-23 9:16 Arnd Bergmann
2021-07-23 18:20 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-07-23 9:16 UTC (permalink / raw)
To: Xinliang Liu, Tian Tao, David Airlie, Daniel Vetter,
Thomas Zimmermann, Maxime Ripard
Cc: Arnd Bergmann, John Stultz, Xinwei Kong, Chen Feng, Sam Ravnborg,
dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent patch left an unused variable in place that needs to be
removed:
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c: In function 'hibmc_unload':
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:252:35: error: unused variable 'priv' [-Werror=unused-variable]
252 | struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index f73a8e0ea12e..610fc8e135f9 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
static int hibmc_unload(struct drm_device *dev)
{
- struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
struct pci_dev *pdev = to_pci_dev(dev->dev);
drm_atomic_helper_shutdown(dev);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/hisilicon/hibmc: remove an unused variable
2021-07-23 9:16 [PATCH] drm/hisilicon/hibmc: remove an unused variable Arnd Bergmann
@ 2021-07-23 18:20 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2021-07-23 18:20 UTC (permalink / raw)
To: Arnd Bergmann, Xinliang Liu, Tian Tao, David Airlie,
Daniel Vetter, Maxime Ripard
Cc: Arnd Bergmann, John Stultz, Xinwei Kong, Chen Feng, Sam Ravnborg,
dri-devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 839 bytes --]
Hi
Am 23.07.21 um 11:16 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch left an unused variable in place that needs to be
> removed:
>
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c: In function 'hibmc_unload':
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c:252:35: error: unused variable 'priv' [-Werror=unused-variable]
> 252 | struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
>
> Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Thanks for the patch. The issue has meanwhile been fixed in drm-misc-next.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-23 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 9:16 [PATCH] drm/hisilicon/hibmc: remove an unused variable Arnd Bergmann
2021-07-23 18:20 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).