Re: [PATCH] Define DIE_OOPS in asm-generic

Re: [PATCH] Define DIE_OOPS in asm-generic

[Steven Rostedt]

Jonas Bonn wrote:
> DIE_OOPS is now used in the generic trace handling code so it needs to
> be defined for all architectures.  Define it in asm-generic so that it's
> available to all by default and doesn't cause build errors for
> architectures that rely on the generic implementation.
>
> Signed-off-by: Jonas Bonn <jonas.bonn@gmail.com>
> ---
>  include/asm-generic/kdebug.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>   

This will obsolete my other patch. (the one making the nmi handler weak)

Acked-by: Steven Rostedt <srostedt@redhat.com>

-- Steve

> diff --git a/include/asm-generic/kdebug.h b/include/asm-generic/kdebug.h
> index 2b799c9..11e57b6 100644
> --- a/include/asm-generic/kdebug.h
> +++ b/include/asm-generic/kdebug.h
> @@ -3,6 +3,7 @@
>  
>  enum die_val {
>  	DIE_UNUSED,
> +	DIE_OOPS=1
>  };
>  
>  #endif /* _ASM_GENERIC_KDEBUG_H */
>   

[PATCH] asm-generic: define DIE_OOPS in asm-generic

[Ingo Molnar]

* Steven Rostedt <srostedt@redhat.com> wrote:

> Jonas Bonn wrote:
>> DIE_OOPS is now used in the generic trace handling code so it needs to
>> be defined for all architectures.  Define it in asm-generic so that it's
>> available to all by default and doesn't cause build errors for
>> architectures that rely on the generic implementation.
>>
>> Signed-off-by: Jonas Bonn <jonas.bonn@gmail.com>
>> ---
>>  include/asm-generic/kdebug.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>   
>
> This will obsolete my other patch. (the one making the nmi handler weak)
>
> Acked-by: Steven Rostedt <srostedt@redhat.com>
>
> -- Steve

ok - i've queued up the patch below in tip/tracing/urgent, thanks 
guys.

	Ingo

>From 5209f08dc8e5f520ca81b87fa9a7142f58a109f4 Mon Sep 17 00:00:00 2001
From: Jonas Bonn <jonas.bonn@gmail.com>
Date: Sat, 25 Oct 2008 11:49:20 +0200
Subject: [PATCH] asm-generic: define DIE_OOPS in asm-generic

Impact: build fix

DIE_OOPS is now used in the generic trace handling code so it needs to
be defined for all architectures.  Define it in asm-generic so that it's
available to all by default and doesn't cause build errors for
architectures that rely on the generic implementation.

Signed-off-by: Jonas Bonn <jonas.bonn@gmail.com>
Acked-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-generic/kdebug.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/asm-generic/kdebug.h b/include/asm-generic/kdebug.h
index 2b799c9..11e57b6 100644
--- a/include/asm-generic/kdebug.h
+++ b/include/asm-generic/kdebug.h
@@ -3,6 +3,7 @@
 
 enum die_val {
 	DIE_UNUSED,
+	DIE_OOPS=1
 };
 
 #endif /* _ASM_GENERIC_KDEBUG_H */