* [PATCH v3 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time @ 2016-11-14 9:27 William Wu 2016-11-14 9:27 ` [PATCH v3 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu 2016-11-14 9:27 ` [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu 0 siblings, 2 replies; 5+ messages in thread From: William Wu @ 2016-11-14 9:27 UTC (permalink / raw) To: kishon, heiko Cc: linux-kernel, linux-arm-kernel, linux-rockchip, devicetree, robh+dt, frank.wang, huangtao, dianders, briannorris, groeck, wulf This series try to correct the 480MHz output clock of USB2 PHY clk_ops callback and fix the delay time. It aims to make the 480MHz clock gate more sensible and stable. Tested on rk3366/rk3399 EVB board. William Wu (2): phy: rockchip-inno-usb2: correct clk_ops callback phy: rockchip-inno-usb2: correct 480MHz output clock stable time drivers/phy/phy-rockchip-inno-usb2.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.0.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] phy: rockchip-inno-usb2: correct clk_ops callback 2016-11-14 9:27 [PATCH v3 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time William Wu @ 2016-11-14 9:27 ` William Wu 2016-11-14 9:27 ` [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu 1 sibling, 0 replies; 5+ messages in thread From: William Wu @ 2016-11-14 9:27 UTC (permalink / raw) To: kishon, heiko Cc: linux-kernel, linux-arm-kernel, linux-rockchip, devicetree, robh+dt, frank.wang, huangtao, dianders, briannorris, groeck, wulf Since we needs to delay ~1ms to wait for 480MHz output clock of USB2 PHY to become stable after turn on it, the delay time is pretty long for something that's supposed to be "atomic" like a clk_enable(). Consider that clk_enable() will disable interrupt and that a 1ms interrupt latency is not sensible. The 480MHz output clock should be handled in prepare callbacks which support gate a clk if the operation may sleep. Signed-off-by: William Wu <wulf@rock-chips.com> --- Changes in v3: - None Changes in v2: - None drivers/phy/phy-rockchip-inno-usb2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c index ac20310..365e077 100644 --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -153,7 +153,7 @@ static inline bool property_enabled(struct rockchip_usb2phy *rphy, return tmp == reg->enable; } -static int rockchip_usb2phy_clk480m_enable(struct clk_hw *hw) +static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw) { struct rockchip_usb2phy *rphy = container_of(hw, struct rockchip_usb2phy, clk480m_hw); @@ -172,7 +172,7 @@ static int rockchip_usb2phy_clk480m_enable(struct clk_hw *hw) return 0; } -static void rockchip_usb2phy_clk480m_disable(struct clk_hw *hw) +static void rockchip_usb2phy_clk480m_unprepare(struct clk_hw *hw) { struct rockchip_usb2phy *rphy = container_of(hw, struct rockchip_usb2phy, clk480m_hw); @@ -181,7 +181,7 @@ static void rockchip_usb2phy_clk480m_disable(struct clk_hw *hw) property_enable(rphy, &rphy->phy_cfg->clkout_ctl, false); } -static int rockchip_usb2phy_clk480m_enabled(struct clk_hw *hw) +static int rockchip_usb2phy_clk480m_prepared(struct clk_hw *hw) { struct rockchip_usb2phy *rphy = container_of(hw, struct rockchip_usb2phy, clk480m_hw); @@ -197,9 +197,9 @@ rockchip_usb2phy_clk480m_recalc_rate(struct clk_hw *hw, } static const struct clk_ops rockchip_usb2phy_clkout_ops = { - .enable = rockchip_usb2phy_clk480m_enable, - .disable = rockchip_usb2phy_clk480m_disable, - .is_enabled = rockchip_usb2phy_clk480m_enabled, + .prepare = rockchip_usb2phy_clk480m_prepare, + .unprepare = rockchip_usb2phy_clk480m_unprepare, + .is_prepared = rockchip_usb2phy_clk480m_prepared, .recalc_rate = rockchip_usb2phy_clk480m_recalc_rate, }; -- 2.0.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time 2016-11-14 9:27 [PATCH v3 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time William Wu 2016-11-14 9:27 ` [PATCH v3 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu @ 2016-11-14 9:27 ` William Wu 2016-11-14 18:17 ` Doug Anderson 1 sibling, 1 reply; 5+ messages in thread From: William Wu @ 2016-11-14 9:27 UTC (permalink / raw) To: kishon, heiko Cc: linux-kernel, linux-arm-kernel, linux-rockchip, devicetree, robh+dt, frank.wang, huangtao, dianders, briannorris, groeck, wulf We found that the system crashed due to 480MHz output clock of USB2 PHY was unstable after clock had been enabled by gpu module. Theoretically, 1 millisecond is a critical value for 480MHz output clock stable time, so we try to change the delay time to 1.2 millisecond to avoid this issue. And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct clk_ops callback") used prepare callbacks instead of enable callbacks to support gate a clk if the operation may sleep. So we can switch from delay to sleep functions. Signed-off-by: William Wu <wulf@rock-chips.com> --- Changes in v3: - fix kbuild test error: too few arguments to function 'usleep_range' Changes in v2: - use usleep_range() function instead of mdelay() drivers/phy/phy-rockchip-inno-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c index 365e077..0e52b25 100644 --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -166,7 +166,7 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw) return ret; /* waitting for the clk become stable */ - mdelay(1); + usleep_range(1200, 1300); } return 0; -- 2.0.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time 2016-11-14 9:27 ` [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu @ 2016-11-14 18:17 ` Doug Anderson 2016-11-15 3:23 ` wlf 0 siblings, 1 reply; 5+ messages in thread From: Doug Anderson @ 2016-11-14 18:17 UTC (permalink / raw) To: William Wu Cc: Kishon Vijay Abraham I, Heiko Stübner, linux-kernel, linux-arm-kernel, open list:ARM/Rockchip SoC..., devicetree, Rob Herring, Frank Wang, 黄涛, Brian Norris, Guenter Roeck William, On Mon, Nov 14, 2016 at 1:27 AM, William Wu <wulf@rock-chips.com> wrote: > We found that the system crashed due to 480MHz output clock of > USB2 PHY was unstable after clock had been enabled by gpu module. > > Theoretically, 1 millisecond is a critical value for 480MHz > output clock stable time, so we try to change the delay time > to 1.2 millisecond to avoid this issue. > > And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct > clk_ops callback") used prepare callbacks instead of enable > callbacks to support gate a clk if the operation may sleep. So > we can switch from delay to sleep functions. > > Signed-off-by: William Wu <wulf@rock-chips.com> > --- > Changes in v3: > - fix kbuild test error: too few arguments to function 'usleep_range' > > Changes in v2: > - use usleep_range() function instead of mdelay() > > drivers/phy/phy-rockchip-inno-usb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c > index 365e077..0e52b25 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -166,7 +166,7 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw) > return ret; > > /* waitting for the clk become stable */ > - mdelay(1); > + usleep_range(1200, 1300); Sight nit that you could also fix the spelling from "waitting" to "waiting". ...but that's pre-existing, so: Reviewed-by: Douglas Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time 2016-11-14 18:17 ` Doug Anderson @ 2016-11-15 3:23 ` wlf 0 siblings, 0 replies; 5+ messages in thread From: wlf @ 2016-11-15 3:23 UTC (permalink / raw) To: Doug Anderson Cc: Kishon Vijay Abraham I, Heiko Stübner, linux-kernel, linux-arm-kernel, open list:ARM/Rockchip SoC..., devicetree, Rob Herring, Frank Wang, 黄涛, Brian Norris, Guenter Roeck Hi Doug, 在 2016年11月15日 02:17, Doug Anderson 写道: > William, > > On Mon, Nov 14, 2016 at 1:27 AM, William Wu <wulf@rock-chips.com> wrote: >> We found that the system crashed due to 480MHz output clock of >> USB2 PHY was unstable after clock had been enabled by gpu module. >> >> Theoretically, 1 millisecond is a critical value for 480MHz >> output clock stable time, so we try to change the delay time >> to 1.2 millisecond to avoid this issue. >> >> And the commit ed907fb1d7c3 ("phy: rockchip-inno-usb2: correct >> clk_ops callback") used prepare callbacks instead of enable >> callbacks to support gate a clk if the operation may sleep. So >> we can switch from delay to sleep functions. >> >> Signed-off-by: William Wu <wulf@rock-chips.com> >> --- >> Changes in v3: >> - fix kbuild test error: too few arguments to function 'usleep_range' >> >> Changes in v2: >> - use usleep_range() function instead of mdelay() >> >> drivers/phy/phy-rockchip-inno-usb2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c >> index 365e077..0e52b25 100644 >> --- a/drivers/phy/phy-rockchip-inno-usb2.c >> +++ b/drivers/phy/phy-rockchip-inno-usb2.c >> @@ -166,7 +166,7 @@ static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw) >> return ret; >> >> /* waitting for the clk become stable */ >> - mdelay(1); >> + usleep_range(1200, 1300); > Sight nit that you could also fix the spelling from "waitting" to "waiting". > > ...but that's pre-existing, so: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks! I'll add Reviewed-by and fix the spelling issue. > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-15 3:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-11-14 9:27 [PATCH v3 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time William Wu 2016-11-14 9:27 ` [PATCH v3 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu 2016-11-14 9:27 ` [PATCH v3 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu 2016-11-14 18:17 ` Doug Anderson 2016-11-15 3:23 ` wlf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).