* [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"
@ 2019-04-17 10:55 Colin King
2019-04-17 11:07 ` Mukesh Ojha
2019-05-18 8:47 ` [tip:perf/core] perf test: Fix " tip-bot for Colin Ian King
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2019-04-17 10:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, Jiri Olsa, Namhyung Kim
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are a couple of spelling mistakes in test assert messages. Fix them.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/perf/tests/dso-data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 7f6c52021e41..946ab4b63acd 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}
@@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"
2019-04-17 10:55 [PATCH] perf test: fix spelling mistake "leadking" -> "leaking" Colin King
@ 2019-04-17 11:07 ` Mukesh Ojha
2019-04-17 11:09 ` Colin Ian King
2019-04-17 17:37 ` Arnaldo Carvalho de Melo
2019-05-18 8:47 ` [tip:perf/core] perf test: Fix " tip-bot for Colin Ian King
1 sibling, 2 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-04-17 11:07 UTC (permalink / raw)
To: Colin King, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, Jiri Olsa,
Namhyung Kim
Cc: kernel-janitors, linux-kernel
On 4/17/2019 4:25 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are a couple of spelling mistakes in test assert messages. Fix them.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Well, how are you shooting these mistakes one after the other?
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> tools/perf/tests/dso-data.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index 7f6c52021e41..946ab4b63acd 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }
>
> @@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"
2019-04-17 11:07 ` Mukesh Ojha
@ 2019-04-17 11:09 ` Colin Ian King
2019-04-17 17:37 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2019-04-17 11:09 UTC (permalink / raw)
To: Mukesh Ojha, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Alexander Shishkin, Jiri Olsa,
Namhyung Kim
Cc: kernel-janitors, linux-kernel
On 17/04/2019 12:07, Mukesh Ojha wrote:
>
> On 4/17/2019 4:25 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are a couple of spelling mistakes in test assert messages. Fix
>> them.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Well, how are you shooting these mistakes one after the other?
I've got a spelling checker and I'm working down a list of 65948
potential mistakes. I'm doing this between kernel build + debug cycles
while I'm waiting for kernels to build and tests to complete.
>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> Cheers,
> -Mukesh
>
>> ---
>> tools/perf/tests/dso-data.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
>> index 7f6c52021e41..946ab4b63acd 100644
>> --- a/tools/perf/tests/dso-data.c
>> +++ b/tools/perf/tests/dso-data.c
>> @@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test
>> __maybe_unused, int subtest __maybe_u
>> /* Make sure we did not leak any file descriptor. */
>> nr_end = open_files_cnt();
>> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
>> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
>> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
>> return 0;
>> }
>> @@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test
>> __maybe_unused, int subtest __maybe_
>> /* Make sure we did not leak any file descriptor. */
>> nr_end = open_files_cnt();
>> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
>> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
>> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
>> return 0;
>> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"
2019-04-17 11:07 ` Mukesh Ojha
2019-04-17 11:09 ` Colin Ian King
@ 2019-04-17 17:37 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-04-17 17:37 UTC (permalink / raw)
To: Mukesh Ojha
Cc: Colin King, Peter Zijlstra, Ingo Molnar, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, kernel-janitors, linux-kernel
Em Wed, Apr 17, 2019 at 04:37:24PM +0530, Mukesh Ojha escreveu:
>
> On 4/17/2019 4:25 PM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There are a couple of spelling mistakes in test assert messages. Fix them.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Well, how are you shooting these mistakes one after the other?
>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/core] perf test: Fix spelling mistake "leadking" -> "leaking"
2019-04-17 10:55 [PATCH] perf test: fix spelling mistake "leadking" -> "leaking" Colin King
2019-04-17 11:07 ` Mukesh Ojha
@ 2019-05-18 8:47 ` tip-bot for Colin Ian King
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Colin Ian King @ 2019-05-18 8:47 UTC (permalink / raw)
To: linux-tip-commits
Cc: alexander.shishkin, jolsa, hpa, namhyung, peterz, acme,
colin.king, mojha, linux-kernel, tglx, mingo
Commit-ID: 1455ea2391be5a5bf0a53258af94fa2abbd73cca
Gitweb: https://git.kernel.org/tip/1455ea2391be5a5bf0a53258af94fa2abbd73cca
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Wed, 17 Apr 2019 11:55:39 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 15 May 2019 16:36:46 -0300
perf test: Fix spelling mistake "leadking" -> "leaking"
There are a couple of spelling mistakes in test assert messages. Fix them.
Signed-off-by: Colin King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20190417105539.5902-1-colin.king@canonical.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/dso-data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 7f6c52021e41..946ab4b63acd 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}
@@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-18 8:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 10:55 [PATCH] perf test: fix spelling mistake "leadking" -> "leaking" Colin King
2019-04-17 11:07 ` Mukesh Ojha
2019-04-17 11:09 ` Colin Ian King
2019-04-17 17:37 ` Arnaldo Carvalho de Melo
2019-05-18 8:47 ` [tip:perf/core] perf test: Fix " tip-bot for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).