* [PATCH] p54usb: Fix regression when using LM87 firmware
@ 2008-12-20 19:01 Larry Finger
0 siblings, 0 replies; only message in thread
From: Larry Finger @ 2008-12-20 19:01 UTC (permalink / raw)
To: John W Linville; +Cc: rjw, linux-kernel, chunkeey, linux-wireless
From: Christian Lamparter <chunkeey@web.de>
Commit 2b80848e3818fb1c8ccddc105b065a86c68afa9d entitled "p54usb: support LM87
firmwares" resulted in a regression when LM87 firmware is used, as this
firmware needs an explicit termination "packet" to terminate the transmission.
If this is missing, the device stalls. This problem is reported as Bugzilla
Entry No. 12260.
The original patch was suitable for the wireless-testing.git tree. This version
is designed for 2.6.28-rc9.
Signed-off-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This patch should be sent to 2.6.28, preferably before release.
Larry
---
Index: linux-2.6/drivers/net/wireless/p54/p54usb.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/p54/p54usb.c
+++ linux-2.6/drivers/net/wireless/p54/p54usb.c
@@ -251,6 +251,7 @@ static void p54u_tx_lm87(struct ieee8021
usb_sndbulkpipe(priv->udev, P54U_PIPE_DATA), hdr,
len + sizeof(*hdr), free_on_tx ? p54u_tx_free_cb : p54u_tx_cb,
dev);
+ data_urb->transfer_flags |= URB_ZERO_PACKET;
usb_submit_urb(data_urb, GFP_ATOMIC);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-20 19:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-20 19:01 [PATCH] p54usb: Fix regression when using LM87 firmware Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).