linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch][trivial] dmaengine: update kerneldoc
@ 2009-02-11 15:47 Johannes Weiner
  2009-02-12  0:03 ` Dan Williams
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Weiner @ 2009-02-11 15:47 UTC (permalink / raw)
  To: Dan Williams; +Cc: linux-kernel

Some of the kerneldoc comments in the dmaengine header describe
already removed structure members.  Remove them.

Also add a short description for dma_device->device_is_tx_complete.

Signed-off-by: Johannes Weiner <jw@emlix.com>
---

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 3e68469..087e79a 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -97,7 +97,6 @@ typedef struct { DECLARE_BITMAP(bits, DMA_TX_TYPE_END); } dma_cap_mask_t;
 
 /**
  * struct dma_chan_percpu - the per-CPU part of struct dma_chan
- * @refcount: local_t used for open-coded "bigref" counting
  * @memcpy_count: transaction counter
  * @bytes_transferred: byte counter
  */
@@ -114,9 +113,6 @@ struct dma_chan_percpu {
  * @cookie: last cookie value returned to client
  * @chan_id: channel ID for sysfs
  * @dev: class device for sysfs
- * @refcount: kref, used in "bigref" slow-mode
- * @slow_ref: indicates that the DMA channel is free
- * @rcu: the DMA channel's RCU head
  * @device_node: used to add this to the device chan list
  * @local: per-cpu pointer to a struct dma_chan_percpu
  * @client-count: how many clients are using this channel
@@ -211,8 +207,6 @@ struct dma_async_tx_descriptor {
  * @global_node: list_head for global dma_device_list
  * @cap_mask: one or more dma_capability flags
  * @max_xor: maximum number of xor sources, 0 if no capability
- * @refcount: reference count
- * @done: IO completion struct
  * @dev_id: unique device ID
  * @dev: struct device reference for dma mapping api
  * @device_alloc_chan_resources: allocate resources and return the
@@ -225,6 +219,7 @@ struct dma_async_tx_descriptor {
  * @device_prep_dma_interrupt: prepares an end of chain interrupt operation
  * @device_prep_slave_sg: prepares a slave dma operation
  * @device_terminate_all: terminate all pending operations
+ * @device_is_tx_complete: poll for transaction completion
  * @device_issue_pending: push pending transactions to hardware
  */
 struct dma_device {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch][trivial] dmaengine: update kerneldoc
  2009-02-11 15:47 [patch][trivial] dmaengine: update kerneldoc Johannes Weiner
@ 2009-02-12  0:03 ` Dan Williams
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2009-02-12  0:03 UTC (permalink / raw)
  To: Johannes Weiner; +Cc: linux-kernel

Johannes Weiner wrote:
> Some of the kerneldoc comments in the dmaengine header describe
> already removed structure members.  Remove them.
> 
> Also add a short description for dma_device->device_is_tx_complete.
> 
> Signed-off-by: Johannes Weiner <jw@emlix.com>

Thanks, applied.

--
Dan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-12  0:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-11 15:47 [patch][trivial] dmaengine: update kerneldoc Johannes Weiner
2009-02-12  0:03 ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).