* [PATCH V10 1/2] scsi: ufs: set the device reference clock setting
[not found] <1535088810-20989-1-git-send-email-sayalil@codeaurora.org>
@ 2018-08-24 5:33 ` Sayali Lokhande
2018-08-24 5:33 ` [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning Sayali Lokhande
1 sibling, 0 replies; 9+ messages in thread
From: Sayali Lokhande @ 2018-08-24 5:33 UTC (permalink / raw)
To: subhashj, cang, vivek.gautam, rnayak, vinholikatti, jejb,
martin.petersen, asutoshd, evgreen, riteshh
Cc: adrian.hunter, linux-scsi, Sayali Lokhande, open list
From: Subhash Jadavani <subhashj@codeaurora.org>
UFS host supplies the reference clock to UFS device and UFS device
specification allows host to provide one of the 4 frequencies (19.2 MHz,
26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the
device reference clock frequency setting in the device based on what
frequency it is supplying to UFS device.
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
---
drivers/scsi/ufs/ufs.h | 14 +++++++
drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +
drivers/scsi/ufs/ufshcd.c | 90 ++++++++++++++++++++++++++++++++++++++++
drivers/scsi/ufs/ufshcd.h | 2 +
4 files changed, 108 insertions(+)
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index 14e5bf7..a2e76b1 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -378,6 +378,20 @@ enum query_opcode {
UPIU_QUERY_OPCODE_TOGGLE_FLAG = 0x8,
};
+/* bRefClkFreq attribute values */
+enum ufs_ref_clk_freq {
+ REF_CLK_FREQ_19_2_MHZ = 0,
+ REF_CLK_FREQ_26_MHZ = 1,
+ REF_CLK_FREQ_38_4_MHZ = 2,
+ REF_CLK_FREQ_52_MHZ = 3,
+ REF_CLK_FREQ_INVAL = -1,
+};
+
+struct ufs_ref_clk {
+ u32 freq_hz;
+ enum ufs_ref_clk_freq val;
+};
+
/* Query response result code */
enum {
QUERY_RESULT_SUCCESS = 0x00,
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index e82bde0..0953563 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -343,6 +343,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
pm_runtime_set_active(&pdev->dev);
pm_runtime_enable(&pdev->dev);
+ ufshcd_parse_dev_ref_clk_freq(hba);
+
ufshcd_init_lanes_per_dir(hba);
err = ufshcd_init(hba, mmio_base, irq);
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c5b1bf1..e01cdc0 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6296,6 +6296,89 @@ static void ufshcd_def_desc_sizes(struct ufs_hba *hba)
hba->desc_size.hlth_desc = QUERY_DESC_HEALTH_DEF_SIZE;
}
+static struct ufs_ref_clk ufs_ref_clk_freqs[] = {
+ {19200000, REF_CLK_FREQ_19_2_MHZ},
+ {26000000, REF_CLK_FREQ_26_MHZ},
+ {38400000, REF_CLK_FREQ_38_4_MHZ},
+ {52000000, REF_CLK_FREQ_52_MHZ},
+ {0, REF_CLK_FREQ_INVAL},
+};
+
+static inline enum ufs_ref_clk_freq
+ufs_get_bref_clk_from_hz(u32 freq)
+{
+ int i = 0;
+
+ while (ufs_ref_clk_freqs[i].freq_hz != freq) {
+ if (!ufs_ref_clk_freqs[i].freq_hz)
+ return REF_CLK_FREQ_INVAL;
+ i++;
+ }
+
+ return ufs_ref_clk_freqs[i].val;
+}
+
+void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba)
+{
+ struct device *dev = hba->dev;
+ struct device_node *np = dev->of_node;
+ struct clk *refclk = NULL;
+ u32 freq = 0;
+
+ if (!np)
+ return;
+
+ refclk = of_clk_get_by_name(np, "ref_clk");
+ if (!refclk)
+ return;
+
+ freq = clk_get_rate(refclk);
+
+ hba->dev_ref_clk_freq =
+ ufs_get_bref_clk_from_hz(freq);
+
+ if (hba->dev_ref_clk_freq == REF_CLK_FREQ_INVAL)
+ dev_err(hba->dev,
+ "%s: invalid ref_clk setting = %d\n",
+ __func__, freq);
+}
+
+static int ufshcd_set_dev_ref_clk(struct ufs_hba *hba)
+{
+ int err, ref_clk = -1;
+ u32 freq = hba->dev_ref_clk_freq;
+
+ err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
+ QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, &ref_clk);
+
+ if (err) {
+ dev_err(hba->dev, "%s: failed reading bRefClkFreq. err = %d\n",
+ __func__, err);
+ goto out;
+ }
+
+ if (ref_clk == hba->dev_ref_clk_freq)
+ goto out; /* nothing to update */
+
+ err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
+ QUERY_ATTR_IDN_REF_CLK_FREQ, 0, 0, &freq);
+
+ if (err) {
+ dev_err(hba->dev, "%s: bRefClkFreq setting to %u Hz failed\n",
+ __func__, ufs_ref_clk_freqs[freq].freq_hz);
+ goto out;
+ }
+ /*
+ * It is good to print this out here to debug any later failures
+ * related to gear switch.
+ */
+ dev_dbg(hba->dev, "%s: bRefClkFreq setting to %u Hz succeeded\n",
+ __func__, ufs_ref_clk_freqs[freq].freq_hz);
+
+out:
+ return err;
+}
+
/**
* ufshcd_probe_hba - probe hba to detect device and initialize
* @hba: per-adapter instance
@@ -6361,6 +6444,12 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
"%s: Failed getting max supported power mode\n",
__func__);
} else {
+ /*
+ * Set the right value to bRefClkFreq before attempting to
+ * switch to HS gears.
+ */
+ if (hba->dev_ref_clk_freq != REF_CLK_FREQ_INVAL)
+ ufshcd_set_dev_ref_clk(hba);
ret = ufshcd_config_pwr_mode(hba, &hba->max_pwr_info.info);
if (ret) {
dev_err(hba->dev, "%s: Failed setting power mode, err = %d\n",
@@ -7690,6 +7779,7 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle)
hba->host = host;
hba->dev = dev;
*hba_handle = hba;
+ hba->dev_ref_clk_freq = REF_CLK_FREQ_INVAL;
INIT_LIST_HEAD(&hba->clk_list_head);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 8110dcd..45013b6 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -548,6 +548,7 @@ struct ufs_hba {
void *priv;
unsigned int irq;
bool is_irq_enabled;
+ enum ufs_ref_clk_freq dev_ref_clk_freq;
/* Interrupt aggregation support is broken */
#define UFSHCD_QUIRK_BROKEN_INTR_AGGR 0x1
@@ -746,6 +747,7 @@ static inline void ufshcd_rmwl(struct ufs_hba *hba, u32 mask, u32 val, u32 reg)
int ufshcd_wait_for_register(struct ufs_hba *hba, u32 reg, u32 mask,
u32 val, unsigned long interval_us,
unsigned long timeout_ms, bool can_sleep);
+void ufshcd_parse_dev_ref_clk_freq(struct ufs_hba *hba);
static inline void check_upiu_size(void)
{
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
[not found] <1535088810-20989-1-git-send-email-sayalil@codeaurora.org>
2018-08-24 5:33 ` [PATCH V10 1/2] scsi: ufs: set the device reference clock setting Sayali Lokhande
@ 2018-08-24 5:33 ` Sayali Lokhande
2018-08-24 8:45 ` Adrian Hunter
1 sibling, 1 reply; 9+ messages in thread
From: Sayali Lokhande @ 2018-08-24 5:33 UTC (permalink / raw)
To: subhashj, cang, vivek.gautam, rnayak, vinholikatti, jejb,
martin.petersen, asutoshd, evgreen, riteshh
Cc: adrian.hunter, linux-scsi, Sayali Lokhande, open list
This patch adds configfs support to provision UFS device at
runtime. This feature can be primarily useful in factory or
assembly line as some devices may be required to be configured
multiple times during initial system development phase.
Configuration Descriptors can be written multiple times until
bConfigDescrLock attribute is zero.
Configuration descriptor buffer consists of Device and Unit
descriptor configurable parameters which are parsed from vendor
specific provisioning file and then passed via configfs node at
runtime to provision ufs device.
CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
Usage:
1) To read current configuration descriptor :
cat /config/XXXX.ufshc/ufs_provision
2) To provision ufs device:
echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
---
Documentation/ABI/testing/configfs-driver-ufs | 18 +++
drivers/scsi/ufs/Kconfig | 10 ++
drivers/scsi/ufs/Makefile | 1 +
drivers/scsi/ufs/ufs-configfs.c | 155 ++++++++++++++++++++++++++
drivers/scsi/ufs/ufshcd.c | 3 +-
drivers/scsi/ufs/ufshcd.h | 17 +++
6 files changed, 203 insertions(+), 1 deletion(-)
create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
create mode 100644 drivers/scsi/ufs/ufs-configfs.c
diff --git a/Documentation/ABI/testing/configfs-driver-ufs b/Documentation/ABI/testing/configfs-driver-ufs
new file mode 100644
index 0000000..eeee499c
--- /dev/null
+++ b/Documentation/ABI/testing/configfs-driver-ufs
@@ -0,0 +1,18 @@
+What: /config/ufshcd/ufs_provision
+Date: Jun 2018
+KernelVersion: 4.14
+Description:
+ This file shows the current ufs configuration descriptor set in device.
+ This can be used to provision ufs device if bConfigDescrLock is 0.
+ For more details, refer 14.1.6.3 Configuration Descriptor and
+ Table 14-12 - Unit Descriptor configurable parameters from specs for
+ description of each configuration descriptor parameter.
+ Configuration descriptor buffer needs to be passed in space separated
+ format specificied as below:
+ echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
+ <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
+ <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
+ <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
+ <bMemoryType> <dNumAllocUnits> <bDataReliability> <bLogicalBlockSize>
+ <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
+ > /config/XXXX.ufshc/ufs_provision
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index e27b4d4..a9a0a58 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
Select this if you have UFS controller on QCOM chipset.
If unsure, say N.
+
+config UFS_PROVISION
+ tristate "Runtime UFS Provisioning support"
+ depends on SCSI_UFSHCD && CONFIGFS_FS
+ help
+ This enables runtime UFS provisioning support. This can be used
+ primarily during assembly line as some devices may be required to
+ be configured multiple times during initial development phase.
+
+ If unsure, say N.
diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
index 918f579..00110ea 100644
--- a/drivers/scsi/ufs/Makefile
+++ b/drivers/scsi/ufs/Makefile
@@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
ufshcd-core-objs := ufshcd.o ufs-sysfs.o
+obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
diff --git a/drivers/scsi/ufs/ufs-configfs.c b/drivers/scsi/ufs/ufs-configfs.c
new file mode 100644
index 0000000..74563a4
--- /dev/null
+++ b/drivers/scsi/ufs/ufs-configfs.c
@@ -0,0 +1,155 @@
+// SPDX-License-Identifier: GPL-2.0+
+// Copyright (c) 2018, Linux Foundation.
+
+#include <linux/configfs.h>
+#include <linux/err.h>
+#include <linux/string.h>
+
+#include "ufs.h"
+#include "ufshcd.h"
+
+static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
+{
+ struct config_group *group = to_config_group(item);
+ struct configfs_subsystem *subsys = to_configfs_subsystem(group);
+ struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
+
+ return subsys ? hba : NULL;
+}
+
+static ssize_t ufs_provision_show(struct config_item *item, char *buf)
+{
+ u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
+ int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
+ int i, ret, curr_len = 0;
+ struct ufs_hba *hba = config_item_to_hba(item);
+
+ ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
+ QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
+
+ if (ret)
+ return ret;
+
+ for (i = 0; i < desc_buf_len; i++)
+ curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
+ "0x%x ", desc_buf[i]);
+
+ return curr_len;
+}
+
+ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
+ const char *buf, size_t count)
+{
+ char *strbuf;
+ char *strbuf_copy;
+ u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
+ int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
+ char *token;
+ int i, ret, value;
+ u32 config_desc_lock = 0;
+
+ /* reserve one byte for null termination */
+ strbuf = kmalloc(count + 1, GFP_KERNEL);
+ if (!strbuf)
+ return -ENOMEM;
+
+ strbuf_copy = strbuf;
+ strlcpy(strbuf, buf, count + 1);
+
+ /* Just return if bConfigDescrLock is already set */
+ ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
+ QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
+ if (ret)
+ goto out;
+
+ if (config_desc_lock) {
+ dev_err(hba->dev, "%s: bConfigDescrLock already set to %u, cannot re-provision device!\n",
+ __func__, config_desc_lock);
+ ret = -EINVAL;
+ goto out;
+ }
+
+ for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
+ token = strsep(&strbuf, " ");
+ if (!token && i)
+ break;
+
+ ret = kstrtoint(token, 0, &value);
+ if (ret) {
+ dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
+ __func__, ret, token);
+ ret = -EINVAL;
+ goto out;
+ }
+ desc_buf[i] = (u8)value;
+ }
+
+ /* Write configuration descriptor to provision ufs */
+ ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
+ QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
+
+ if (!ret)
+ dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
+ __func__);
+
+out:
+ kfree(strbuf_copy);
+ if (ret)
+ return ret;
+ return count;
+}
+
+static ssize_t ufs_provision_store(struct config_item *item,
+ const char *buf, size_t count)
+{
+ struct ufs_hba *hba = config_item_to_hba(item);
+
+ return ufshcd_desc_configfs_store(hba, buf, count);
+}
+
+static struct configfs_attribute ufshcd_attr_provision = {
+ .ca_name = "ufs_provision",
+ .ca_mode = 0644,
+ .ca_owner = THIS_MODULE,
+ .show = ufs_provision_show,
+ .store = ufs_provision_store,
+};
+
+static struct configfs_attribute *ufshcd_attrs[] = {
+ &ufshcd_attr_provision,
+ NULL,
+};
+
+static struct config_item_type ufscfg_type = {
+ .ct_attrs = ufshcd_attrs,
+ .ct_owner = THIS_MODULE,
+};
+
+static struct configfs_subsystem ufscfg_subsys = {
+ .su_group = {
+ .cg_item = {
+ .ci_type = &ufscfg_type,
+ },
+ },
+};
+
+void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
+{
+ int ret;
+ struct configfs_subsystem *subsys = &hba->subsys;
+
+ strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
+ subsys->su_group = ufscfg_subsys.su_group;
+ config_group_init(&subsys->su_group);
+ mutex_init(&subsys->su_mutex);
+ ret = configfs_register_subsystem(subsys);
+ if (ret)
+ pr_err("Error %d while registering subsystem %s\n",
+ ret,
+ subsys->su_group.cg_item.ci_namebuf);
+}
+
+void ufshcd_configfs_exit(void)
+{
+ configfs_unregister_subsystem(&ufscfg_subsys);
+}
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e01cdc0..32a67b0 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
void ufshcd_remove(struct ufs_hba *hba)
{
ufs_sysfs_remove_nodes(hba->dev);
+ ufshcd_configfs_exit();
scsi_remove_host(hba->host);
/* disable interrupts */
ufshcd_disable_intr(hba, hba->intr_mask);
@@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
async_schedule(ufshcd_async_scan, hba);
ufs_sysfs_add_nodes(hba->dev);
-
+ ufshcd_configfs_init(hba, dev_name(hba->dev));
return 0;
out_remove_scsi_host:
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 45013b6..2275032 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -37,6 +37,7 @@
#ifndef _UFSHCD_H
#define _UFSHCD_H
+#include <linux/configfs.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/init.h>
@@ -515,6 +516,9 @@ struct ufs_hba {
struct Scsi_Host *host;
struct device *dev;
+#ifdef CONFIG_UFS_PROVISION
+ struct configfs_subsystem subsys;
+#endif
/*
* This field is to keep a reference to "scsi_device" corresponding to
* "UFS device" W-LU.
@@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index,
int ufshcd_hold(struct ufs_hba *hba, bool async);
void ufshcd_release(struct ufs_hba *hba);
+/* Expose UFS configfs API's */
+#ifndef CONFIG_UFS_PROVISION
+static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
+{
+}
+static inline void ufshcd_configfs_exit(void)
+{
+}
+#else
+void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
+void ufshcd_configfs_exit(void);
+#endif
+
int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn desc_id,
int *desc_length);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-24 5:33 ` [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning Sayali Lokhande
@ 2018-08-24 8:45 ` Adrian Hunter
2018-08-28 10:23 ` Sayali Lokhande
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Hunter @ 2018-08-24 8:45 UTC (permalink / raw)
To: Sayali Lokhande, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 24/08/18 08:33, Sayali Lokhande wrote:
> This patch adds configfs support to provision UFS device at
> runtime. This feature can be primarily useful in factory or
> assembly line as some devices may be required to be configured
> multiple times during initial system development phase.
> Configuration Descriptors can be written multiple times until
> bConfigDescrLock attribute is zero.
>
> Configuration descriptor buffer consists of Device and Unit
> descriptor configurable parameters which are parsed from vendor
> specific provisioning file and then passed via configfs node at
> runtime to provision ufs device.
> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>
> Usage:
> 1) To read current configuration descriptor :
> cat /config/XXXX.ufshc/ufs_provision
> 2) To provision ufs device:
> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>
> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
> ---
> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
> drivers/scsi/ufs/Kconfig | 10 ++
> drivers/scsi/ufs/Makefile | 1 +
> drivers/scsi/ufs/ufs-configfs.c | 155 ++++++++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.c | 3 +-
> drivers/scsi/ufs/ufshcd.h | 17 +++
> 6 files changed, 203 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>
> diff --git a/Documentation/ABI/testing/configfs-driver-ufs b/Documentation/ABI/testing/configfs-driver-ufs
> new file mode 100644
> index 0000000..eeee499c
> --- /dev/null
> +++ b/Documentation/ABI/testing/configfs-driver-ufs
> @@ -0,0 +1,18 @@
> +What: /config/ufshcd/ufs_provision
You are using the device name as the config subsystem name, so this is really:
What: /config/*/ufs_provision
> +Date: Jun 2018
> +KernelVersion: 4.14
4.19 maybe
> +Description:
> + This file shows the current ufs configuration descriptor set in device.
It is only the first config descriptor though isn't it? There is no support
for the other 3. Shouldn't we support config descriptors fully?
> + This can be used to provision ufs device if bConfigDescrLock is 0.
> + For more details, refer 14.1.6.3 Configuration Descriptor and
> + Table 14-12 - Unit Descriptor configurable parameters from specs for
> + description of each configuration descriptor parameter.
> + Configuration descriptor buffer needs to be passed in space separated
> + format specificied as below:
specificied -> specified
> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
> + <bMemoryType> <dNumAllocUnits> <bDataReliability> <bLogicalBlockSize>
> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
This format is not exactly correct anymore because each byte has to be
represented separately. Also theoretically it can be change, so maybe
better just to refer the user to the UFS specification.
> + > /config/XXXX.ufshc/ufs_provision
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index e27b4d4..a9a0a58 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>
> Select this if you have UFS controller on QCOM chipset.
> If unsure, say N.
> +
> +config UFS_PROVISION
> + tristate "Runtime UFS Provisioning support"
> + depends on SCSI_UFSHCD && CONFIGFS_FS
> + help
> + This enables runtime UFS provisioning support. This can be used
> + primarily during assembly line as some devices may be required to
> + be configured multiple times during initial development phase.
> +
> + If unsure, say N.
> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
> index 918f579..00110ea 100644
> --- a/drivers/scsi/ufs/Makefile
> +++ b/drivers/scsi/ufs/Makefile
> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
> diff --git a/drivers/scsi/ufs/ufs-configfs.c b/drivers/scsi/ufs/ufs-configfs.c
> new file mode 100644
> index 0000000..74563a4
> --- /dev/null
> +++ b/drivers/scsi/ufs/ufs-configfs.c
> @@ -0,0 +1,155 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright (c) 2018, Linux Foundation.
> +
> +#include <linux/configfs.h>
> +#include <linux/err.h>
> +#include <linux/string.h>
> +
> +#include "ufs.h"
> +#include "ufshcd.h"
> +
> +static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
> +{
> + struct config_group *group = to_config_group(item);
> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
> +
> + return subsys ? hba : NULL;
> +}
> +
> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
> +{
> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
Is it really ok to hard-code the descriptor size?
> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
> + int i, ret, curr_len = 0;
> + struct ufs_hba *hba = config_item_to_hba(item);
> +
> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
> +
> + if (ret)
> + return ret;
> +
> + for (i = 0; i < desc_buf_len; i++)
> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
> + "0x%x ", desc_buf[i]);
> +
> + return curr_len;
> +}
> +
> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
> + const char *buf, size_t count)
> +{
> + char *strbuf;
> + char *strbuf_copy;
> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
> + char *token;
> + int i, ret, value;
> + u32 config_desc_lock = 0;
> +
> + /* reserve one byte for null termination */
> + strbuf = kmalloc(count + 1, GFP_KERNEL);
> + if (!strbuf)
> + return -ENOMEM;
> +
> + strbuf_copy = strbuf;
> + strlcpy(strbuf, buf, count + 1);
> +
> + /* Just return if bConfigDescrLock is already set */
> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
> + if (ret)
> + goto out;
> +
> + if (config_desc_lock) {
> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u, cannot re-provision device!\n",
> + __func__, config_desc_lock);
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
> + token = strsep(&strbuf, " ");
> + if (!token && i)
> + break;
> +
> + ret = kstrtoint(token, 0, &value);
> + if (ret) {
> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
> + __func__, ret, token);
> + ret = -EINVAL;
> + goto out;
> + }
> + desc_buf[i] = (u8)value;
> + }
> +
> + /* Write configuration descriptor to provision ufs */
> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
> +
> + if (!ret)
> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
That is not necessarily true - bConfDescContinue might have been used or
bConfigDescrLock might need to be set. Better just to say that
configuration descriptor 0 was written.
> + __func__);
> +
> +out:
> + kfree(strbuf_copy);
> + if (ret)
> + return ret;
> + return count;
> +}
> +
> +static ssize_t ufs_provision_store(struct config_item *item,
> + const char *buf, size_t count)
> +{
> + struct ufs_hba *hba = config_item_to_hba(item);
> +
> + return ufshcd_desc_configfs_store(hba, buf, count);
> +}
> +
> +static struct configfs_attribute ufshcd_attr_provision = {
> + .ca_name = "ufs_provision",
> + .ca_mode = 0644,
> + .ca_owner = THIS_MODULE,
> + .show = ufs_provision_show,
> + .store = ufs_provision_store,
> +};
> +
> +static struct configfs_attribute *ufshcd_attrs[] = {
> + &ufshcd_attr_provision,
> + NULL,
> +};
> +
> +static struct config_item_type ufscfg_type = {
> + .ct_attrs = ufshcd_attrs,
> + .ct_owner = THIS_MODULE,
> +};
> +
> +static struct configfs_subsystem ufscfg_subsys = {
> + .su_group = {
> + .cg_item = {
> + .ci_type = &ufscfg_type,
> + },
> + },
> +};
> +
> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
> +{
> + int ret;
> + struct configfs_subsystem *subsys = &hba->subsys;
> +
> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
> + subsys->su_group = ufscfg_subsys.su_group;
configfs_subsystem cannot share su_group with other configfs_subsystem i.e
you are not allowing for there being more than 1 hba
> + config_group_init(&subsys->su_group);
> + mutex_init(&subsys->su_mutex);
> + ret = configfs_register_subsystem(subsys);
> + if (ret)
> + pr_err("Error %d while registering subsystem %s\n",
> + ret,
> + subsys->su_group.cg_item.ci_namebuf);
> +}
> +
> +void ufshcd_configfs_exit(void)
> +{
> + configfs_unregister_subsystem(&ufscfg_subsys);
> +}
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e01cdc0..32a67b0 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
> void ufshcd_remove(struct ufs_hba *hba)
> {
> ufs_sysfs_remove_nodes(hba->dev);
> + ufshcd_configfs_exit();
> scsi_remove_host(hba->host);
> /* disable interrupts */
> ufshcd_disable_intr(hba, hba->intr_mask);
> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
>
> async_schedule(ufshcd_async_scan, hba);
> ufs_sysfs_add_nodes(hba->dev);
> -
> + ufshcd_configfs_init(hba, dev_name(hba->dev));
> return 0;
>
> out_remove_scsi_host:
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 45013b6..2275032 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -37,6 +37,7 @@
> #ifndef _UFSHCD_H
> #define _UFSHCD_H
>
> +#include <linux/configfs.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> @@ -515,6 +516,9 @@ struct ufs_hba {
>
> struct Scsi_Host *host;
> struct device *dev;
> +#ifdef CONFIG_UFS_PROVISION
> + struct configfs_subsystem subsys;
> +#endif
> /*
> * This field is to keep a reference to "scsi_device" corresponding to
> * "UFS device" W-LU.
> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index,
> int ufshcd_hold(struct ufs_hba *hba, bool async);
> void ufshcd_release(struct ufs_hba *hba);
>
> +/* Expose UFS configfs API's */
> +#ifndef CONFIG_UFS_PROVISION
> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
> +{
> +}
> +static inline void ufshcd_configfs_exit(void)
> +{
> +}
> +#else
> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
> +void ufshcd_configfs_exit(void);
> +#endif
> +
> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn desc_id,
> int *desc_length);
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-24 8:45 ` Adrian Hunter
@ 2018-08-28 10:23 ` Sayali Lokhande
2018-08-28 10:50 ` Adrian Hunter
2018-08-28 11:26 ` Adrian Hunter
0 siblings, 2 replies; 9+ messages in thread
From: Sayali Lokhande @ 2018-08-28 10:23 UTC (permalink / raw)
To: Adrian Hunter, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
Hi Adrian,
On 8/24/2018 2:15 PM, Adrian Hunter wrote:
> On 24/08/18 08:33, Sayali Lokhande wrote:
>> This patch adds configfs support to provision UFS device at
>> runtime. This feature can be primarily useful in factory or
>> assembly line as some devices may be required to be configured
>> multiple times during initial system development phase.
>> Configuration Descriptors can be written multiple times until
>> bConfigDescrLock attribute is zero.
>>
>> Configuration descriptor buffer consists of Device and Unit
>> descriptor configurable parameters which are parsed from vendor
>> specific provisioning file and then passed via configfs node at
>> runtime to provision ufs device.
>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>
>> Usage:
>> 1) To read current configuration descriptor :
>> cat /config/XXXX.ufshc/ufs_provision
>> 2) To provision ufs device:
>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>
>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>> ---
>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>> drivers/scsi/ufs/Kconfig | 10 ++
>> drivers/scsi/ufs/Makefile | 1 +
>> drivers/scsi/ufs/ufs-configfs.c | 155 ++++++++++++++++++++++++++
>> drivers/scsi/ufs/ufshcd.c | 3 +-
>> drivers/scsi/ufs/ufshcd.h | 17 +++
>> 6 files changed, 203 insertions(+), 1 deletion(-)
>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>
>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs b/Documentation/ABI/testing/configfs-driver-ufs
>> new file mode 100644
>> index 0000000..eeee499c
>> --- /dev/null
>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>> @@ -0,0 +1,18 @@
>> +What: /config/ufshcd/ufs_provision
> You are using the device name as the config subsystem name, so this is really:
>
> What: /config/*/ufs_provision
Agree. Will update.
>> +Date: Jun 2018
>> +KernelVersion: 4.14
> 4.19 maybe
Done.
>> +Description:
>> + This file shows the current ufs configuration descriptor set in device.
> It is only the first config descriptor though isn't it? There is no support
> for the other 3. Shouldn't we support config descriptors fully?
Yes, we should support config descriptors fully. My current
implementation only supports config desc (index = 00h).
I m thinking I can add separate "index" field along with "ufs_provision"
field and can use this index (instead of hard coding to 0)
to write repective config_desc. In this way, we should first set the
"index" and then read/write to "ufs_provision".
Let me know if you have any concern with this approach ?
>> + This can be used to provision ufs device if bConfigDescrLock is 0.
>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>> + Table 14-12 - Unit Descriptor configurable parameters from specs for
>> + description of each configuration descriptor parameter.
>> + Configuration descriptor buffer needs to be passed in space separated
>> + format specificied as below:
> specificied -> specified
Done
>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>> + <bMemoryType> <dNumAllocUnits> <bDataReliability> <bLogicalBlockSize>
>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
> This format is not exactly correct anymore because each byte has to be
> represented separately. Also theoretically it can be change, so maybe
> better just to refer the user to the UFS specification.
Agree. Will update to just refer to UFS spec (for Config_desc format).
>> + > /config/XXXX.ufshc/ufs_provision
>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>> index e27b4d4..a9a0a58 100644
>> --- a/drivers/scsi/ufs/Kconfig
>> +++ b/drivers/scsi/ufs/Kconfig
>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>
>> Select this if you have UFS controller on QCOM chipset.
>> If unsure, say N.
>> +
>> +config UFS_PROVISION
>> + tristate "Runtime UFS Provisioning support"
>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>> + help
>> + This enables runtime UFS provisioning support. This can be used
>> + primarily during assembly line as some devices may be required to
>> + be configured multiple times during initial development phase.
>> +
>> + If unsure, say N.
>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>> index 918f579..00110ea 100644
>> --- a/drivers/scsi/ufs/Makefile
>> +++ b/drivers/scsi/ufs/Makefile
>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>> diff --git a/drivers/scsi/ufs/ufs-configfs.c b/drivers/scsi/ufs/ufs-configfs.c
>> new file mode 100644
>> index 0000000..74563a4
>> --- /dev/null
>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>> @@ -0,0 +1,155 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +// Copyright (c) 2018, Linux Foundation.
>> +
>> +#include <linux/configfs.h>
>> +#include <linux/err.h>
>> +#include <linux/string.h>
>> +
>> +#include "ufs.h"
>> +#include "ufshcd.h"
>> +
>> +static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
>> +{
>> + struct config_group *group = to_config_group(item);
>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>> +
>> + return subsys ? hba : NULL;
>> +}
>> +
>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>> +{
>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
> Is it really ok to hard-code the descriptor size?
I will use ufshcd_read_desc_length() api for each index as required.
Will remove this hard-code.
>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>> + int i, ret, curr_len = 0;
>> + struct ufs_hba *hba = config_item_to_hba(item);
>> +
>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>> +
>> + if (ret)
>> + return ret;
>> +
>> + for (i = 0; i < desc_buf_len; i++)
>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>> + "0x%x ", desc_buf[i]);
>> +
>> + return curr_len;
>> +}
>> +
>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>> + const char *buf, size_t count)
>> +{
>> + char *strbuf;
>> + char *strbuf_copy;
>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>> + char *token;
>> + int i, ret, value;
>> + u32 config_desc_lock = 0;
>> +
>> + /* reserve one byte for null termination */
>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>> + if (!strbuf)
>> + return -ENOMEM;
>> +
>> + strbuf_copy = strbuf;
>> + strlcpy(strbuf, buf, count + 1);
>> +
>> + /* Just return if bConfigDescrLock is already set */
>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>> + if (ret)
>> + goto out;
>> +
>> + if (config_desc_lock) {
>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u, cannot re-provision device!\n",
>> + __func__, config_desc_lock);
>> + ret = -EINVAL;
>> + goto out;
>> + }
>> +
>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>> + token = strsep(&strbuf, " ");
>> + if (!token && i)
>> + break;
>> +
>> + ret = kstrtoint(token, 0, &value);
>> + if (ret) {
>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>> + __func__, ret, token);
>> + ret = -EINVAL;
>> + goto out;
>> + }
>> + desc_buf[i] = (u8)value;
>> + }
>> +
>> + /* Write configuration descriptor to provision ufs */
>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>> +
>> + if (!ret)
>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
> That is not necessarily true - bConfDescContinue might have been used or
> bConfigDescrLock might need to be set. Better just to say that
> configuration descriptor 0 was written.
Agree. Will update.
>
>> + __func__);
>> +
>> +out:
>> + kfree(strbuf_copy);
>> + if (ret)
>> + return ret;
>> + return count;
>> +}
>> +
>> +static ssize_t ufs_provision_store(struct config_item *item,
>> + const char *buf, size_t count)
>> +{
>> + struct ufs_hba *hba = config_item_to_hba(item);
>> +
>> + return ufshcd_desc_configfs_store(hba, buf, count);
>> +}
>> +
>> +static struct configfs_attribute ufshcd_attr_provision = {
>> + .ca_name = "ufs_provision",
>> + .ca_mode = 0644,
>> + .ca_owner = THIS_MODULE,
>> + .show = ufs_provision_show,
>> + .store = ufs_provision_store,
>> +};
>> +
>> +static struct configfs_attribute *ufshcd_attrs[] = {
>> + &ufshcd_attr_provision,
>> + NULL,
>> +};
>> +
>> +static struct config_item_type ufscfg_type = {
>> + .ct_attrs = ufshcd_attrs,
>> + .ct_owner = THIS_MODULE,
>> +};
>> +
>> +static struct configfs_subsystem ufscfg_subsys = {
>> + .su_group = {
>> + .cg_item = {
>> + .ci_type = &ufscfg_type,
>> + },
>> + },
>> +};
>> +
>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>> +{
>> + int ret;
>> + struct configfs_subsystem *subsys = &hba->subsys;
>> +
>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
>> + subsys->su_group = ufscfg_subsys.su_group;
> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
> you are not allowing for there being more than 1 hba
Agree. I think I will have to move above
declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h
file (to make it per ufs hba/probe).
Will check and update.
>> + config_group_init(&subsys->su_group);
>> + mutex_init(&subsys->su_mutex);
>> + ret = configfs_register_subsystem(subsys);
>> + if (ret)
>> + pr_err("Error %d while registering subsystem %s\n",
>> + ret,
>> + subsys->su_group.cg_item.ci_namebuf);
>> +}
>> +
>> +void ufshcd_configfs_exit(void)
>> +{
>> + configfs_unregister_subsystem(&ufscfg_subsys);
>> +}
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index e01cdc0..32a67b0 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>> void ufshcd_remove(struct ufs_hba *hba)
>> {
>> ufs_sysfs_remove_nodes(hba->dev);
>> + ufshcd_configfs_exit();
>> scsi_remove_host(hba->host);
>> /* disable interrupts */
>> ufshcd_disable_intr(hba, hba->intr_mask);
>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
>>
>> async_schedule(ufshcd_async_scan, hba);
>> ufs_sysfs_add_nodes(hba->dev);
>> -
>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>> return 0;
>>
>> out_remove_scsi_host:
>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>> index 45013b6..2275032 100644
>> --- a/drivers/scsi/ufs/ufshcd.h
>> +++ b/drivers/scsi/ufs/ufshcd.h
>> @@ -37,6 +37,7 @@
>> #ifndef _UFSHCD_H
>> #define _UFSHCD_H
>>
>> +#include <linux/configfs.h>
>> #include <linux/module.h>
>> #include <linux/kernel.h>
>> #include <linux/init.h>
>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>
>> struct Scsi_Host *host;
>> struct device *dev;
>> +#ifdef CONFIG_UFS_PROVISION
>> + struct configfs_subsystem subsys;
>> +#endif
>> /*
>> * This field is to keep a reference to "scsi_device" corresponding to
>> * "UFS device" W-LU.
>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index,
>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>> void ufshcd_release(struct ufs_hba *hba);
>>
>> +/* Expose UFS configfs API's */
>> +#ifndef CONFIG_UFS_PROVISION
>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>> +{
>> +}
>> +static inline void ufshcd_configfs_exit(void)
>> +{
>> +}
>> +#else
>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>> +void ufshcd_configfs_exit(void);
>> +#endif
>> +
>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn desc_id,
>> int *desc_length);
>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-28 10:23 ` Sayali Lokhande
@ 2018-08-28 10:50 ` Adrian Hunter
2018-08-28 11:26 ` Adrian Hunter
1 sibling, 0 replies; 9+ messages in thread
From: Adrian Hunter @ 2018-08-28 10:50 UTC (permalink / raw)
To: Sayali Lokhande, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 28/08/18 13:23, Sayali Lokhande wrote:
> Hi Adrian,
Hi Sayali
I see you sent version V10.1. Should I look at that or are you about to
make a V11
>
> On 8/24/2018 2:15 PM, Adrian Hunter wrote:
>> On 24/08/18 08:33, Sayali Lokhande wrote:
>>> This patch adds configfs support to provision UFS device at
>>> runtime. This feature can be primarily useful in factory or
>>> assembly line as some devices may be required to be configured
>>> multiple times during initial system development phase.
>>> Configuration Descriptors can be written multiple times until
>>> bConfigDescrLock attribute is zero.
>>>
>>> Configuration descriptor buffer consists of Device and Unit
>>> descriptor configurable parameters which are parsed from vendor
>>> specific provisioning file and then passed via configfs node at
>>> runtime to provision ufs device.
>>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>>
>>> Usage:
>>> 1) To read current configuration descriptor :
>>> cat /config/XXXX.ufshc/ufs_provision
>>> 2) To provision ufs device:
>>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>>
>>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>>> ---
>>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>>> drivers/scsi/ufs/Kconfig | 10 ++
>>> drivers/scsi/ufs/Makefile | 1 +
>>> drivers/scsi/ufs/ufs-configfs.c | 155
>>> ++++++++++++++++++++++++++
>>> drivers/scsi/ufs/ufshcd.c | 3 +-
>>> drivers/scsi/ufs/ufshcd.h | 17 +++
>>> 6 files changed, 203 insertions(+), 1 deletion(-)
>>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>>
>>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs
>>> b/Documentation/ABI/testing/configfs-driver-ufs
>>> new file mode 100644
>>> index 0000000..eeee499c
>>> --- /dev/null
>>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>>> @@ -0,0 +1,18 @@
>>> +What: /config/ufshcd/ufs_provision
>> You are using the device name as the config subsystem name, so this is
>> really:
>>
>> What: /config/*/ufs_provision
> Agree. Will update.
>>> +Date: Jun 2018
>>> +KernelVersion: 4.14
>> 4.19 maybe
> Done.
>>> +Description:
>>> + This file shows the current ufs configuration descriptor set in
>>> device.
>> It is only the first config descriptor though isn't it? There is no support
>> for the other 3. Shouldn't we support config descriptors fully?
> Yes, we should support config descriptors fully. My current implementation
> only supports config desc (index = 00h).
> I m thinking I can add separate "index" field along with "ufs_provision"
> field and can use this index (instead of hard coding to 0)
> to write repective config_desc. In this way, we should first set the "index"
> and then read/write to "ufs_provision".
> Let me know if you have any concern with this approach ?
>
>>> + This can be used to provision ufs device if bConfigDescrLock is 0.
>>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>>> + Table 14-12 - Unit Descriptor configurable parameters from specs
>>> for
>>> + description of each configuration descriptor parameter.
>>> + Configuration descriptor buffer needs to be passed in space
>>> separated
>>> + format specificied as below:
>> specificied -> specified
> Done
>>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>>> + <bMemoryType> <dNumAllocUnits> <bDataReliability>
>>> <bLogicalBlockSize>
>>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
>> This format is not exactly correct anymore because each byte has to be
>> represented separately. Also theoretically it can be change, so maybe
>> better just to refer the user to the UFS specification.
> Agree. Will update to just refer to UFS spec (for Config_desc format).
>
>>> + > /config/XXXX.ufshc/ufs_provision
>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>> index e27b4d4..a9a0a58 100644
>>> --- a/drivers/scsi/ufs/Kconfig
>>> +++ b/drivers/scsi/ufs/Kconfig
>>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>> Select this if you have UFS controller on QCOM chipset.
>>> If unsure, say N.
>>> +
>>> +config UFS_PROVISION
>>> + tristate "Runtime UFS Provisioning support"
>>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>>> + help
>>> + This enables runtime UFS provisioning support. This can be used
>>> + primarily during assembly line as some devices may be required to
>>> + be configured multiple times during initial development phase.
>>> +
>>> + If unsure, say N.
>>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>>> index 918f579..00110ea 100644
>>> --- a/drivers/scsi/ufs/Makefile
>>> +++ b/drivers/scsi/ufs/Makefile
>>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
>>> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>>> diff --git a/drivers/scsi/ufs/ufs-configfs.c
>>> b/drivers/scsi/ufs/ufs-configfs.c
>>> new file mode 100644
>>> index 0000000..74563a4
>>> --- /dev/null
>>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>>> @@ -0,0 +1,155 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +// Copyright (c) 2018, Linux Foundation.
>>> +
>>> +#include <linux/configfs.h>
>>> +#include <linux/err.h>
>>> +#include <linux/string.h>
>>> +
>>> +#include "ufs.h"
>>> +#include "ufshcd.h"
>>> +
>>> +static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
>>> +{
>>> + struct config_group *group = to_config_group(item);
>>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>>> +
>>> + return subsys ? hba : NULL;
>>> +}
>>> +
>>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>>> +{
>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>> Is it really ok to hard-code the descriptor size?
> I will use ufshcd_read_desc_length() api for each index as required. Will
> remove this hard-code.
>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>> + int i, ret, curr_len = 0;
>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>> +
>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>> +
>>> + if (ret)
>>> + return ret;
>>> +
>>> + for (i = 0; i < desc_buf_len; i++)
>>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>>> + "0x%x ", desc_buf[i]);
>>> +
>>> + return curr_len;
>>> +}
>>> +
>>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>>> + const char *buf, size_t count)
>>> +{
>>> + char *strbuf;
>>> + char *strbuf_copy;
>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>> + char *token;
>>> + int i, ret, value;
>>> + u32 config_desc_lock = 0;
>>> +
>>> + /* reserve one byte for null termination */
>>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>>> + if (!strbuf)
>>> + return -ENOMEM;
>>> +
>>> + strbuf_copy = strbuf;
>>> + strlcpy(strbuf, buf, count + 1);
>>> +
>>> + /* Just return if bConfigDescrLock is already set */
>>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>>> + if (ret)
>>> + goto out;
>>> +
>>> + if (config_desc_lock) {
>>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u,
>>> cannot re-provision device!\n",
>>> + __func__, config_desc_lock);
>>> + ret = -EINVAL;
>>> + goto out;
>>> + }
>>> +
>>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>>> + token = strsep(&strbuf, " ");
>>> + if (!token && i)
>>> + break;
>>> +
>>> + ret = kstrtoint(token, 0, &value);
>>> + if (ret) {
>>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>>> + __func__, ret, token);
>>> + ret = -EINVAL;
>>> + goto out;
>>> + }
>>> + desc_buf[i] = (u8)value;
>>> + }
>>> +
>>> + /* Write configuration descriptor to provision ufs */
>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>> +
>>> + if (!ret)
>>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
>> That is not necessarily true - bConfDescContinue might have been used or
>> bConfigDescrLock might need to be set. Better just to say that
>> configuration descriptor 0 was written.
> Agree. Will update.
>>
>>> + __func__);
>>> +
>>> +out:
>>> + kfree(strbuf_copy);
>>> + if (ret)
>>> + return ret;
>>> + return count;
>>> +}
>>> +
>>> +static ssize_t ufs_provision_store(struct config_item *item,
>>> + const char *buf, size_t count)
>>> +{
>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>> +
>>> + return ufshcd_desc_configfs_store(hba, buf, count);
>>> +}
>>> +
>>> +static struct configfs_attribute ufshcd_attr_provision = {
>>> + .ca_name = "ufs_provision",
>>> + .ca_mode = 0644,
>>> + .ca_owner = THIS_MODULE,
>>> + .show = ufs_provision_show,
>>> + .store = ufs_provision_store,
>>> +};
>>> +
>>> +static struct configfs_attribute *ufshcd_attrs[] = {
>>> + &ufshcd_attr_provision,
>>> + NULL,
>>> +};
>>> +
>>> +static struct config_item_type ufscfg_type = {
>>> + .ct_attrs = ufshcd_attrs,
>>> + .ct_owner = THIS_MODULE,
>>> +};
>>> +
>>> +static struct configfs_subsystem ufscfg_subsys = {
>>> + .su_group = {
>>> + .cg_item = {
>>> + .ci_type = &ufscfg_type,
>>> + },
>>> + },
>>> +};
>>> +
>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>>> +{
>>> + int ret;
>>> + struct configfs_subsystem *subsys = &hba->subsys;
>>> +
>>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
>>> + subsys->su_group = ufscfg_subsys.su_group;
>> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
>> you are not allowing for there being more than 1 hba
> Agree. I think I will have to move above
> declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h file
> (to make it per ufs hba/probe).
> Will check and update.
>>> + config_group_init(&subsys->su_group);
>>> + mutex_init(&subsys->su_mutex);
>>> + ret = configfs_register_subsystem(subsys);
>>> + if (ret)
>>> + pr_err("Error %d while registering subsystem %s\n",
>>> + ret,
>>> + subsys->su_group.cg_item.ci_namebuf);
>>> +}
>>> +
>>> +void ufshcd_configfs_exit(void)
>>> +{
>>> + configfs_unregister_subsystem(&ufscfg_subsys);
>>> +}
>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>> index e01cdc0..32a67b0 100644
>>> --- a/drivers/scsi/ufs/ufshcd.c
>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>>> void ufshcd_remove(struct ufs_hba *hba)
>>> {
>>> ufs_sysfs_remove_nodes(hba->dev);
>>> + ufshcd_configfs_exit();
>>> scsi_remove_host(hba->host);
>>> /* disable interrupts */
>>> ufshcd_disable_intr(hba, hba->intr_mask);
>>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
>>> *mmio_base, unsigned int irq)
>>> async_schedule(ufshcd_async_scan, hba);
>>> ufs_sysfs_add_nodes(hba->dev);
>>> -
>>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>>> return 0;
>>> out_remove_scsi_host:
>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>> index 45013b6..2275032 100644
>>> --- a/drivers/scsi/ufs/ufshcd.h
>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>> @@ -37,6 +37,7 @@
>>> #ifndef _UFSHCD_H
>>> #define _UFSHCD_H
>>> +#include <linux/configfs.h>
>>> #include <linux/module.h>
>>> #include <linux/kernel.h>
>>> #include <linux/init.h>
>>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>> struct Scsi_Host *host;
>>> struct device *dev;
>>> +#ifdef CONFIG_UFS_PROVISION
>>> + struct configfs_subsystem subsys;
>>> +#endif
>>> /*
>>> * This field is to keep a reference to "scsi_device" corresponding to
>>> * "UFS device" W-LU.
>>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int
>>> desc_index,
>>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>>> void ufshcd_release(struct ufs_hba *hba);
>>> +/* Expose UFS configfs API's */
>>> +#ifndef CONFIG_UFS_PROVISION
>>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char
>>> *name)
>>> +{
>>> +}
>>> +static inline void ufshcd_configfs_exit(void)
>>> +{
>>> +}
>>> +#else
>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>>> +void ufshcd_configfs_exit(void);
>>> +#endif
>>> +
>>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn
>>> desc_id,
>>> int *desc_length);
>>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-28 10:23 ` Sayali Lokhande
2018-08-28 10:50 ` Adrian Hunter
@ 2018-08-28 11:26 ` Adrian Hunter
2018-08-28 11:40 ` Sayali Lokhande
1 sibling, 1 reply; 9+ messages in thread
From: Adrian Hunter @ 2018-08-28 11:26 UTC (permalink / raw)
To: Sayali Lokhande, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 28/08/18 13:23, Sayali Lokhande wrote:
> Hi Adrian,
>
> On 8/24/2018 2:15 PM, Adrian Hunter wrote:
>> On 24/08/18 08:33, Sayali Lokhande wrote:
>>> This patch adds configfs support to provision UFS device at
>>> runtime. This feature can be primarily useful in factory or
>>> assembly line as some devices may be required to be configured
>>> multiple times during initial system development phase.
>>> Configuration Descriptors can be written multiple times until
>>> bConfigDescrLock attribute is zero.
>>>
>>> Configuration descriptor buffer consists of Device and Unit
>>> descriptor configurable parameters which are parsed from vendor
>>> specific provisioning file and then passed via configfs node at
>>> runtime to provision ufs device.
>>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>>
>>> Usage:
>>> 1) To read current configuration descriptor :
>>> cat /config/XXXX.ufshc/ufs_provision
>>> 2) To provision ufs device:
>>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>>
>>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>>> ---
>>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>>> drivers/scsi/ufs/Kconfig | 10 ++
>>> drivers/scsi/ufs/Makefile | 1 +
>>> drivers/scsi/ufs/ufs-configfs.c | 155
>>> ++++++++++++++++++++++++++
>>> drivers/scsi/ufs/ufshcd.c | 3 +-
>>> drivers/scsi/ufs/ufshcd.h | 17 +++
>>> 6 files changed, 203 insertions(+), 1 deletion(-)
>>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>>
>>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs
>>> b/Documentation/ABI/testing/configfs-driver-ufs
>>> new file mode 100644
>>> index 0000000..eeee499c
>>> --- /dev/null
>>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>>> @@ -0,0 +1,18 @@
>>> +What: /config/ufshcd/ufs_provision
>> You are using the device name as the config subsystem name, so this is
>> really:
>>
>> What: /config/*/ufs_provision
> Agree. Will update.
>>> +Date: Jun 2018
>>> +KernelVersion: 4.14
>> 4.19 maybe
> Done.
>>> +Description:
>>> + This file shows the current ufs configuration descriptor set in
>>> device.
>> It is only the first config descriptor though isn't it? There is no support
>> for the other 3. Shouldn't we support config descriptors fully?
> Yes, we should support config descriptors fully. My current implementation
> only supports config desc (index = 00h).
> I m thinking I can add separate "index" field along with "ufs_provision"
> field and can use this index (instead of hard coding to 0)
> to write repective config_desc. In this way, we should first set the "index"
> and then read/write to "ufs_provision".
> Let me know if you have any concern with this approach ?
One file for each config descriptor would seem more normal.
>
>>> + This can be used to provision ufs device if bConfigDescrLock is 0.
>>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>>> + Table 14-12 - Unit Descriptor configurable parameters from specs
>>> for
>>> + description of each configuration descriptor parameter.
>>> + Configuration descriptor buffer needs to be passed in space
>>> separated
>>> + format specificied as below:
>> specificied -> specified
> Done
>>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>>> + <bMemoryType> <dNumAllocUnits> <bDataReliability>
>>> <bLogicalBlockSize>
>>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
>> This format is not exactly correct anymore because each byte has to be
>> represented separately. Also theoretically it can be change, so maybe
>> better just to refer the user to the UFS specification.
> Agree. Will update to just refer to UFS spec (for Config_desc format).
>
>>> + > /config/XXXX.ufshc/ufs_provision
>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>> index e27b4d4..a9a0a58 100644
>>> --- a/drivers/scsi/ufs/Kconfig
>>> +++ b/drivers/scsi/ufs/Kconfig
>>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>> Select this if you have UFS controller on QCOM chipset.
>>> If unsure, say N.
>>> +
>>> +config UFS_PROVISION
>>> + tristate "Runtime UFS Provisioning support"
>>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>>> + help
>>> + This enables runtime UFS provisioning support. This can be used
>>> + primarily during assembly line as some devices may be required to
>>> + be configured multiple times during initial development phase.
>>> +
>>> + If unsure, say N.
>>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>>> index 918f579..00110ea 100644
>>> --- a/drivers/scsi/ufs/Makefile
>>> +++ b/drivers/scsi/ufs/Makefile
>>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
>>> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>>> diff --git a/drivers/scsi/ufs/ufs-configfs.c
>>> b/drivers/scsi/ufs/ufs-configfs.c
>>> new file mode 100644
>>> index 0000000..74563a4
>>> --- /dev/null
>>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>>> @@ -0,0 +1,155 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +// Copyright (c) 2018, Linux Foundation.
>>> +
>>> +#include <linux/configfs.h>
>>> +#include <linux/err.h>
>>> +#include <linux/string.h>
>>> +
>>> +#include "ufs.h"
>>> +#include "ufshcd.h"
>>> +
>>> +static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
>>> +{
>>> + struct config_group *group = to_config_group(item);
>>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>>> +
>>> + return subsys ? hba : NULL;
>>> +}
>>> +
>>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>>> +{
>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>> Is it really ok to hard-code the descriptor size?
> I will use ufshcd_read_desc_length() api for each index as required. Will
> remove this hard-code.
Alternatively, I see there is already hba->desc_size.conf_desc
>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>> + int i, ret, curr_len = 0;
>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>> +
>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>> +
>>> + if (ret)
>>> + return ret;
>>> +
>>> + for (i = 0; i < desc_buf_len; i++)
>>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>>> + "0x%x ", desc_buf[i]);
>>> +
>>> + return curr_len;
>>> +}
>>> +
>>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>>> + const char *buf, size_t count)
>>> +{
>>> + char *strbuf;
>>> + char *strbuf_copy;
>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>> + char *token;
>>> + int i, ret, value;
>>> + u32 config_desc_lock = 0;
>>> +
>>> + /* reserve one byte for null termination */
>>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>>> + if (!strbuf)
>>> + return -ENOMEM;
>>> +
>>> + strbuf_copy = strbuf;
>>> + strlcpy(strbuf, buf, count + 1);
>>> +
>>> + /* Just return if bConfigDescrLock is already set */
>>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>>> + if (ret)
>>> + goto out;
>>> +
>>> + if (config_desc_lock) {
>>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u,
>>> cannot re-provision device!\n",
>>> + __func__, config_desc_lock);
>>> + ret = -EINVAL;
>>> + goto out;
>>> + }
>>> +
>>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>>> + token = strsep(&strbuf, " ");
>>> + if (!token && i)
>>> + break;
>>> +
>>> + ret = kstrtoint(token, 0, &value);
>>> + if (ret) {
>>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>>> + __func__, ret, token);
>>> + ret = -EINVAL;
>>> + goto out;
>>> + }
>>> + desc_buf[i] = (u8)value;
>>> + }
>>> +
>>> + /* Write configuration descriptor to provision ufs */
>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>> +
>>> + if (!ret)
>>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
>> That is not necessarily true - bConfDescContinue might have been used or
>> bConfigDescrLock might need to be set. Better just to say that
>> configuration descriptor 0 was written.
> Agree. Will update.
>>
>>> + __func__);
>>> +
>>> +out:
>>> + kfree(strbuf_copy);
>>> + if (ret)
>>> + return ret;
>>> + return count;
>>> +}
>>> +
>>> +static ssize_t ufs_provision_store(struct config_item *item,
>>> + const char *buf, size_t count)
>>> +{
>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>> +
>>> + return ufshcd_desc_configfs_store(hba, buf, count);
>>> +}
>>> +
>>> +static struct configfs_attribute ufshcd_attr_provision = {
>>> + .ca_name = "ufs_provision",
>>> + .ca_mode = 0644,
>>> + .ca_owner = THIS_MODULE,
>>> + .show = ufs_provision_show,
>>> + .store = ufs_provision_store,
>>> +};
>>> +
>>> +static struct configfs_attribute *ufshcd_attrs[] = {
>>> + &ufshcd_attr_provision,
>>> + NULL,
>>> +};
>>> +
>>> +static struct config_item_type ufscfg_type = {
>>> + .ct_attrs = ufshcd_attrs,
>>> + .ct_owner = THIS_MODULE,
>>> +};
>>> +
>>> +static struct configfs_subsystem ufscfg_subsys = {
>>> + .su_group = {
>>> + .cg_item = {
>>> + .ci_type = &ufscfg_type,
>>> + },
>>> + },
>>> +};
>>> +
>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>>> +{
>>> + int ret;
>>> + struct configfs_subsystem *subsys = &hba->subsys;
>>> +
>>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
>>> + subsys->su_group = ufscfg_subsys.su_group;
>> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
>> you are not allowing for there being more than 1 hba
> Agree. I think I will have to move above
> declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h file
> (to make it per ufs hba/probe).
> Will check and update.
>>> + config_group_init(&subsys->su_group);
>>> + mutex_init(&subsys->su_mutex);
>>> + ret = configfs_register_subsystem(subsys);
>>> + if (ret)
>>> + pr_err("Error %d while registering subsystem %s\n",
>>> + ret,
>>> + subsys->su_group.cg_item.ci_namebuf);
>>> +}
>>> +
>>> +void ufshcd_configfs_exit(void)
>>> +{
>>> + configfs_unregister_subsystem(&ufscfg_subsys);
>>> +}
>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>> index e01cdc0..32a67b0 100644
>>> --- a/drivers/scsi/ufs/ufshcd.c
>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>>> void ufshcd_remove(struct ufs_hba *hba)
>>> {
>>> ufs_sysfs_remove_nodes(hba->dev);
>>> + ufshcd_configfs_exit();
>>> scsi_remove_host(hba->host);
>>> /* disable interrupts */
>>> ufshcd_disable_intr(hba, hba->intr_mask);
>>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
>>> *mmio_base, unsigned int irq)
>>> async_schedule(ufshcd_async_scan, hba);
>>> ufs_sysfs_add_nodes(hba->dev);
>>> -
>>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>>> return 0;
>>> out_remove_scsi_host:
>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>> index 45013b6..2275032 100644
>>> --- a/drivers/scsi/ufs/ufshcd.h
>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>> @@ -37,6 +37,7 @@
>>> #ifndef _UFSHCD_H
>>> #define _UFSHCD_H
>>> +#include <linux/configfs.h>
>>> #include <linux/module.h>
>>> #include <linux/kernel.h>
>>> #include <linux/init.h>
>>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>> struct Scsi_Host *host;
>>> struct device *dev;
>>> +#ifdef CONFIG_UFS_PROVISION
>>> + struct configfs_subsystem subsys;
>>> +#endif
>>> /*
>>> * This field is to keep a reference to "scsi_device" corresponding to
>>> * "UFS device" W-LU.
>>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int
>>> desc_index,
>>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>>> void ufshcd_release(struct ufs_hba *hba);
>>> +/* Expose UFS configfs API's */
>>> +#ifndef CONFIG_UFS_PROVISION
>>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char
>>> *name)
>>> +{
>>> +}
>>> +static inline void ufshcd_configfs_exit(void)
>>> +{
>>> +}
>>> +#else
>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>>> +void ufshcd_configfs_exit(void);
>>> +#endif
>>> +
>>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn
>>> desc_id,
>>> int *desc_length);
>>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-28 11:26 ` Adrian Hunter
@ 2018-08-28 11:40 ` Sayali Lokhande
2018-08-28 12:06 ` Adrian Hunter
0 siblings, 1 reply; 9+ messages in thread
From: Sayali Lokhande @ 2018-08-28 11:40 UTC (permalink / raw)
To: Adrian Hunter, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 8/28/2018 4:56 PM, Adrian Hunter wrote:
> On 28/08/18 13:23, Sayali Lokhande wrote:
>> Hi Adrian,
>>
>> On 8/24/2018 2:15 PM, Adrian Hunter wrote:
>>> On 24/08/18 08:33, Sayali Lokhande wrote:
>>>> This patch adds configfs support to provision UFS device at
>>>> runtime. This feature can be primarily useful in factory or
>>>> assembly line as some devices may be required to be configured
>>>> multiple times during initial system development phase.
>>>> Configuration Descriptors can be written multiple times until
>>>> bConfigDescrLock attribute is zero.
>>>>
>>>> Configuration descriptor buffer consists of Device and Unit
>>>> descriptor configurable parameters which are parsed from vendor
>>>> specific provisioning file and then passed via configfs node at
>>>> runtime to provision ufs device.
>>>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>>>
>>>> Usage:
>>>> 1) To read current configuration descriptor :
>>>> cat /config/XXXX.ufshc/ufs_provision
>>>> 2) To provision ufs device:
>>>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>>>
>>>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>>>> ---
>>>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>>>> drivers/scsi/ufs/Kconfig | 10 ++
>>>> drivers/scsi/ufs/Makefile | 1 +
>>>> drivers/scsi/ufs/ufs-configfs.c | 155
>>>> ++++++++++++++++++++++++++
>>>> drivers/scsi/ufs/ufshcd.c | 3 +-
>>>> drivers/scsi/ufs/ufshcd.h | 17 +++
>>>> 6 files changed, 203 insertions(+), 1 deletion(-)
>>>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>>>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>>>
>>>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs
>>>> b/Documentation/ABI/testing/configfs-driver-ufs
>>>> new file mode 100644
>>>> index 0000000..eeee499c
>>>> --- /dev/null
>>>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>>>> @@ -0,0 +1,18 @@
>>>> +What: /config/ufshcd/ufs_provision
>>> You are using the device name as the config subsystem name, so this is
>>> really:
>>>
>>> What: /config/*/ufs_provision
>> Agree. Will update.
>>>> +Date: Jun 2018
>>>> +KernelVersion: 4.14
>>> 4.19 maybe
>> Done.
>>>> +Description:
>>>> + This file shows the current ufs configuration descriptor set in
>>>> device.
>>> It is only the first config descriptor though isn't it? There is no support
>>> for the other 3. Shouldn't we support config descriptors fully?
>> Yes, we should support config descriptors fully. My current implementation
>> only supports config desc (index = 00h).
>> I m thinking I can add separate "index" field along with "ufs_provision"
>> field and can use this index (instead of hard coding to 0)
>> to write repective config_desc. In this way, we should first set the "index"
>> and then read/write to "ufs_provision".
>> Let me know if you have any concern with this approach ?
> One file for each config descriptor would seem more normal.
I can make separate file for each config descriptor index(say
ufs_provision_0/1/2/3), but still show() and store() api's can remain
common.
Will try it out and update.
>>>> + This can be used to provision ufs device if bConfigDescrLock is 0.
>>>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>>>> + Table 14-12 - Unit Descriptor configurable parameters from specs
>>>> for
>>>> + description of each configuration descriptor parameter.
>>>> + Configuration descriptor buffer needs to be passed in space
>>>> separated
>>>> + format specificied as below:
>>> specificied -> specified
>> Done
>>>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>>>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>>>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>>>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>>>> + <bMemoryType> <dNumAllocUnits> <bDataReliability>
>>>> <bLogicalBlockSize>
>>>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
>>> This format is not exactly correct anymore because each byte has to be
>>> represented separately. Also theoretically it can be change, so maybe
>>> better just to refer the user to the UFS specification.
>> Agree. Will update to just refer to UFS spec (for Config_desc format).
>>
>>>> + > /config/XXXX.ufshc/ufs_provision
>>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>>> index e27b4d4..a9a0a58 100644
>>>> --- a/drivers/scsi/ufs/Kconfig
>>>> +++ b/drivers/scsi/ufs/Kconfig
>>>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>>> Select this if you have UFS controller on QCOM chipset.
>>>> If unsure, say N.
>>>> +
>>>> +config UFS_PROVISION
>>>> + tristate "Runtime UFS Provisioning support"
>>>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>>>> + help
>>>> + This enables runtime UFS provisioning support. This can be used
>>>> + primarily during assembly line as some devices may be required to
>>>> + be configured multiple times during initial development phase.
>>>> +
>>>> + If unsure, say N.
>>>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>>>> index 918f579..00110ea 100644
>>>> --- a/drivers/scsi/ufs/Makefile
>>>> +++ b/drivers/scsi/ufs/Makefile
>>>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
>>>> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>>>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>>>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>>>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>>>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>>>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>>>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>>>> diff --git a/drivers/scsi/ufs/ufs-configfs.c
>>>> b/drivers/scsi/ufs/ufs-configfs.c
>>>> new file mode 100644
>>>> index 0000000..74563a4
>>>> --- /dev/null
>>>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>>>> @@ -0,0 +1,155 @@
>>>> +// SPDX-License-Identifier: GPL-2.0+
>>>> +// Copyright (c) 2018, Linux Foundation.
>>>> +
>>>> +#include <linux/configfs.h>
>>>> +#include <linux/err.h>
>>>> +#include <linux/string.h>
>>>> +
>>>> +#include "ufs.h"
>>>> +#include "ufshcd.h"
>>>> +
>>>> +static inline struct ufs_hba *config_item_to_hba(struct config_item *item)
>>>> +{
>>>> + struct config_group *group = to_config_group(item);
>>>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>>>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>>>> +
>>>> + return subsys ? hba : NULL;
>>>> +}
>>>> +
>>>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>>>> +{
>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>> Is it really ok to hard-code the descriptor size?
>> I will use ufshcd_read_desc_length() api for each index as required. Will
>> remove this hard-code.
> Alternatively, I see there is already hba->desc_size.conf_desc
hba->desc_size.conf_desc is actually size for index 0. I thought what if
desc size various per index.
So better to read for each index. What say ?
>
>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>> + int i, ret, curr_len = 0;
>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>> +
>>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>> +
>>>> + if (ret)
>>>> + return ret;
>>>> +
>>>> + for (i = 0; i < desc_buf_len; i++)
>>>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>>>> + "0x%x ", desc_buf[i]);
>>>> +
>>>> + return curr_len;
>>>> +}
>>>> +
>>>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>>>> + const char *buf, size_t count)
>>>> +{
>>>> + char *strbuf;
>>>> + char *strbuf_copy;
>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>> + char *token;
>>>> + int i, ret, value;
>>>> + u32 config_desc_lock = 0;
>>>> +
>>>> + /* reserve one byte for null termination */
>>>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>>>> + if (!strbuf)
>>>> + return -ENOMEM;
>>>> +
>>>> + strbuf_copy = strbuf;
>>>> + strlcpy(strbuf, buf, count + 1);
>>>> +
>>>> + /* Just return if bConfigDescrLock is already set */
>>>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>>>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>>>> + if (ret)
>>>> + goto out;
>>>> +
>>>> + if (config_desc_lock) {
>>>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u,
>>>> cannot re-provision device!\n",
>>>> + __func__, config_desc_lock);
>>>> + ret = -EINVAL;
>>>> + goto out;
>>>> + }
>>>> +
>>>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>>>> + token = strsep(&strbuf, " ");
>>>> + if (!token && i)
>>>> + break;
>>>> +
>>>> + ret = kstrtoint(token, 0, &value);
>>>> + if (ret) {
>>>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>>>> + __func__, ret, token);
>>>> + ret = -EINVAL;
>>>> + goto out;
>>>> + }
>>>> + desc_buf[i] = (u8)value;
>>>> + }
>>>> +
>>>> + /* Write configuration descriptor to provision ufs */
>>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_WRITE_DESC,
>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>> +
>>>> + if (!ret)
>>>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
>>> That is not necessarily true - bConfDescContinue might have been used or
>>> bConfigDescrLock might need to be set. Better just to say that
>>> configuration descriptor 0 was written.
>> Agree. Will update.
>>>> + __func__);
>>>> +
>>>> +out:
>>>> + kfree(strbuf_copy);
>>>> + if (ret)
>>>> + return ret;
>>>> + return count;
>>>> +}
>>>> +
>>>> +static ssize_t ufs_provision_store(struct config_item *item,
>>>> + const char *buf, size_t count)
>>>> +{
>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>> +
>>>> + return ufshcd_desc_configfs_store(hba, buf, count);
>>>> +}
>>>> +
>>>> +static struct configfs_attribute ufshcd_attr_provision = {
>>>> + .ca_name = "ufs_provision",
>>>> + .ca_mode = 0644,
>>>> + .ca_owner = THIS_MODULE,
>>>> + .show = ufs_provision_show,
>>>> + .store = ufs_provision_store,
>>>> +};
>>>> +
>>>> +static struct configfs_attribute *ufshcd_attrs[] = {
>>>> + &ufshcd_attr_provision,
>>>> + NULL,
>>>> +};
>>>> +
>>>> +static struct config_item_type ufscfg_type = {
>>>> + .ct_attrs = ufshcd_attrs,
>>>> + .ct_owner = THIS_MODULE,
>>>> +};
>>>> +
>>>> +static struct configfs_subsystem ufscfg_subsys = {
>>>> + .su_group = {
>>>> + .cg_item = {
>>>> + .ci_type = &ufscfg_type,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>>>> +{
>>>> + int ret;
>>>> + struct configfs_subsystem *subsys = &hba->subsys;
>>>> +
>>>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name, strlen(name));
>>>> + subsys->su_group = ufscfg_subsys.su_group;
>>> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
>>> you are not allowing for there being more than 1 hba
>> Agree. I think I will have to move above
>> declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h file
>> (to make it per ufs hba/probe).
>> Will check and update.
>>>> + config_group_init(&subsys->su_group);
>>>> + mutex_init(&subsys->su_mutex);
>>>> + ret = configfs_register_subsystem(subsys);
>>>> + if (ret)
>>>> + pr_err("Error %d while registering subsystem %s\n",
>>>> + ret,
>>>> + subsys->su_group.cg_item.ci_namebuf);
>>>> +}
>>>> +
>>>> +void ufshcd_configfs_exit(void)
>>>> +{
>>>> + configfs_unregister_subsystem(&ufscfg_subsys);
>>>> +}
>>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>>> index e01cdc0..32a67b0 100644
>>>> --- a/drivers/scsi/ufs/ufshcd.c
>>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>>>> void ufshcd_remove(struct ufs_hba *hba)
>>>> {
>>>> ufs_sysfs_remove_nodes(hba->dev);
>>>> + ufshcd_configfs_exit();
>>>> scsi_remove_host(hba->host);
>>>> /* disable interrupts */
>>>> ufshcd_disable_intr(hba, hba->intr_mask);
>>>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
>>>> *mmio_base, unsigned int irq)
>>>> async_schedule(ufshcd_async_scan, hba);
>>>> ufs_sysfs_add_nodes(hba->dev);
>>>> -
>>>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>>>> return 0;
>>>> out_remove_scsi_host:
>>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>>> index 45013b6..2275032 100644
>>>> --- a/drivers/scsi/ufs/ufshcd.h
>>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>>> @@ -37,6 +37,7 @@
>>>> #ifndef _UFSHCD_H
>>>> #define _UFSHCD_H
>>>> +#include <linux/configfs.h>
>>>> #include <linux/module.h>
>>>> #include <linux/kernel.h>
>>>> #include <linux/init.h>
>>>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>>> struct Scsi_Host *host;
>>>> struct device *dev;
>>>> +#ifdef CONFIG_UFS_PROVISION
>>>> + struct configfs_subsystem subsys;
>>>> +#endif
>>>> /*
>>>> * This field is to keep a reference to "scsi_device" corresponding to
>>>> * "UFS device" W-LU.
>>>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int
>>>> desc_index,
>>>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>>>> void ufshcd_release(struct ufs_hba *hba);
>>>> +/* Expose UFS configfs API's */
>>>> +#ifndef CONFIG_UFS_PROVISION
>>>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char
>>>> *name)
>>>> +{
>>>> +}
>>>> +static inline void ufshcd_configfs_exit(void)
>>>> +{
>>>> +}
>>>> +#else
>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>>>> +void ufshcd_configfs_exit(void);
>>>> +#endif
>>>> +
>>>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn
>>>> desc_id,
>>>> int *desc_length);
>>>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-28 11:40 ` Sayali Lokhande
@ 2018-08-28 12:06 ` Adrian Hunter
2018-08-28 12:38 ` Sayali Lokhande
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Hunter @ 2018-08-28 12:06 UTC (permalink / raw)
To: Sayali Lokhande, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 28/08/18 14:40, Sayali Lokhande wrote:
>
> On 8/28/2018 4:56 PM, Adrian Hunter wrote:
>> On 28/08/18 13:23, Sayali Lokhande wrote:
>>> Hi Adrian,
>>>
>>> On 8/24/2018 2:15 PM, Adrian Hunter wrote:
>>>> On 24/08/18 08:33, Sayali Lokhande wrote:
>>>>> This patch adds configfs support to provision UFS device at
>>>>> runtime. This feature can be primarily useful in factory or
>>>>> assembly line as some devices may be required to be configured
>>>>> multiple times during initial system development phase.
>>>>> Configuration Descriptors can be written multiple times until
>>>>> bConfigDescrLock attribute is zero.
>>>>>
>>>>> Configuration descriptor buffer consists of Device and Unit
>>>>> descriptor configurable parameters which are parsed from vendor
>>>>> specific provisioning file and then passed via configfs node at
>>>>> runtime to provision ufs device.
>>>>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>>>>
>>>>> Usage:
>>>>> 1) To read current configuration descriptor :
>>>>> cat /config/XXXX.ufshc/ufs_provision
>>>>> 2) To provision ufs device:
>>>>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>>>>
>>>>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>>>>> ---
>>>>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>>>>> drivers/scsi/ufs/Kconfig | 10 ++
>>>>> drivers/scsi/ufs/Makefile | 1 +
>>>>> drivers/scsi/ufs/ufs-configfs.c | 155
>>>>> ++++++++++++++++++++++++++
>>>>> drivers/scsi/ufs/ufshcd.c | 3 +-
>>>>> drivers/scsi/ufs/ufshcd.h | 17 +++
>>>>> 6 files changed, 203 insertions(+), 1 deletion(-)
>>>>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>>>>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>>>>
>>>>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs
>>>>> b/Documentation/ABI/testing/configfs-driver-ufs
>>>>> new file mode 100644
>>>>> index 0000000..eeee499c
>>>>> --- /dev/null
>>>>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>>>>> @@ -0,0 +1,18 @@
>>>>> +What: /config/ufshcd/ufs_provision
>>>> You are using the device name as the config subsystem name, so this is
>>>> really:
>>>>
>>>> What: /config/*/ufs_provision
>>> Agree. Will update.
>>>>> +Date: Jun 2018
>>>>> +KernelVersion: 4.14
>>>> 4.19 maybe
>>> Done.
>>>>> +Description:
>>>>> + This file shows the current ufs configuration descriptor set in
>>>>> device.
>>>> It is only the first config descriptor though isn't it? There is no
>>>> support
>>>> for the other 3. Shouldn't we support config descriptors fully?
>>> Yes, we should support config descriptors fully. My current implementation
>>> only supports config desc (index = 00h).
>>> I m thinking I can add separate "index" field along with "ufs_provision"
>>> field and can use this index (instead of hard coding to 0)
>>> to write repective config_desc. In this way, we should first set the "index"
>>> and then read/write to "ufs_provision".
>>> Let me know if you have any concern with this approach ?
>> One file for each config descriptor would seem more normal.
> I can make separate file for each config descriptor index(say
> ufs_provision_0/1/2/3), but still show() and store() api's can remain common.
> Will try it out and update.
>>>>> + This can be used to provision ufs device if bConfigDescrLock
>>>>> is 0.
>>>>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>>>>> + Table 14-12 - Unit Descriptor configurable parameters from specs
>>>>> for
>>>>> + description of each configuration descriptor parameter.
>>>>> + Configuration descriptor buffer needs to be passed in space
>>>>> separated
>>>>> + format specificied as below:
>>>> specificied -> specified
>>> Done
>>>>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>>>>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>>>>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>>>>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>>>>> + <bMemoryType> <dNumAllocUnits> <bDataReliability>
>>>>> <bLogicalBlockSize>
>>>>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
>>>> This format is not exactly correct anymore because each byte has to be
>>>> represented separately. Also theoretically it can be change, so maybe
>>>> better just to refer the user to the UFS specification.
>>> Agree. Will update to just refer to UFS spec (for Config_desc format).
>>>
>>>>> + > /config/XXXX.ufshc/ufs_provision
>>>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>>>> index e27b4d4..a9a0a58 100644
>>>>> --- a/drivers/scsi/ufs/Kconfig
>>>>> +++ b/drivers/scsi/ufs/Kconfig
>>>>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>>>> Select this if you have UFS controller on QCOM chipset.
>>>>> If unsure, say N.
>>>>> +
>>>>> +config UFS_PROVISION
>>>>> + tristate "Runtime UFS Provisioning support"
>>>>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>>>>> + help
>>>>> + This enables runtime UFS provisioning support. This can be used
>>>>> + primarily during assembly line as some devices may be required to
>>>>> + be configured multiple times during initial development phase.
>>>>> +
>>>>> + If unsure, say N.
>>>>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>>>>> index 918f579..00110ea 100644
>>>>> --- a/drivers/scsi/ufs/Makefile
>>>>> +++ b/drivers/scsi/ufs/Makefile
>>>>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
>>>>> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>>>>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>>>>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>>>>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>>>>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>>>>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>>>>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>>>>> diff --git a/drivers/scsi/ufs/ufs-configfs.c
>>>>> b/drivers/scsi/ufs/ufs-configfs.c
>>>>> new file mode 100644
>>>>> index 0000000..74563a4
>>>>> --- /dev/null
>>>>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>>>>> @@ -0,0 +1,155 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0+
>>>>> +// Copyright (c) 2018, Linux Foundation.
>>>>> +
>>>>> +#include <linux/configfs.h>
>>>>> +#include <linux/err.h>
>>>>> +#include <linux/string.h>
>>>>> +
>>>>> +#include "ufs.h"
>>>>> +#include "ufshcd.h"
>>>>> +
>>>>> +static inline struct ufs_hba *config_item_to_hba(struct config_item
>>>>> *item)
>>>>> +{
>>>>> + struct config_group *group = to_config_group(item);
>>>>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>>>>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>>>>> +
>>>>> + return subsys ? hba : NULL;
>>>>> +}
>>>>> +
>>>>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>>>>> +{
>>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>>> Is it really ok to hard-code the descriptor size?
>>> I will use ufshcd_read_desc_length() api for each index as required. Will
>>> remove this hard-code.
>> Alternatively, I see there is already hba->desc_size.conf_desc
> hba->desc_size.conf_desc is actually size for index 0. I thought what if
> desc size various per index.
> So better to read for each index. What say ?
Based on the 'B' and 'L' values defined in the spec., all configuration
descriptors have the same length.
>>
>>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>>> + int i, ret, curr_len = 0;
>>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>>> +
>>>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>>> +
>>>>> + if (ret)
>>>>> + return ret;
>>>>> +
>>>>> + for (i = 0; i < desc_buf_len; i++)
>>>>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>>>>> + "0x%x ", desc_buf[i]);
>>>>> +
>>>>> + return curr_len;
>>>>> +}
>>>>> +
>>>>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>>>>> + const char *buf, size_t count)
>>>>> +{
>>>>> + char *strbuf;
>>>>> + char *strbuf_copy;
>>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>>> + char *token;
>>>>> + int i, ret, value;
>>>>> + u32 config_desc_lock = 0;
>>>>> +
>>>>> + /* reserve one byte for null termination */
>>>>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>>>>> + if (!strbuf)
>>>>> + return -ENOMEM;
>>>>> +
>>>>> + strbuf_copy = strbuf;
>>>>> + strlcpy(strbuf, buf, count + 1);
>>>>> +
>>>>> + /* Just return if bConfigDescrLock is already set */
>>>>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>>>>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>>>>> + if (ret)
>>>>> + goto out;
>>>>> +
>>>>> + if (config_desc_lock) {
>>>>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u,
>>>>> cannot re-provision device!\n",
>>>>> + __func__, config_desc_lock);
>>>>> + ret = -EINVAL;
>>>>> + goto out;
>>>>> + }
>>>>> +
>>>>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>>>>> + token = strsep(&strbuf, " ");
>>>>> + if (!token && i)
>>>>> + break;
>>>>> +
>>>>> + ret = kstrtoint(token, 0, &value);
>>>>> + if (ret) {
>>>>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>>>>> + __func__, ret, token);
>>>>> + ret = -EINVAL;
>>>>> + goto out;
>>>>> + }
>>>>> + desc_buf[i] = (u8)value;
>>>>> + }
>>>>> +
>>>>> + /* Write configuration descriptor to provision ufs */
>>>>> + ret = ufshcd_query_descriptor_retry(hba,
>>>>> UPIU_QUERY_OPCODE_WRITE_DESC,
>>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>>> +
>>>>> + if (!ret)
>>>>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
>>>> That is not necessarily true - bConfDescContinue might have been used or
>>>> bConfigDescrLock might need to be set. Better just to say that
>>>> configuration descriptor 0 was written.
>>> Agree. Will update.
>>>>> + __func__);
>>>>> +
>>>>> +out:
>>>>> + kfree(strbuf_copy);
>>>>> + if (ret)
>>>>> + return ret;
>>>>> + return count;
>>>>> +}
>>>>> +
>>>>> +static ssize_t ufs_provision_store(struct config_item *item,
>>>>> + const char *buf, size_t count)
>>>>> +{
>>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>>> +
>>>>> + return ufshcd_desc_configfs_store(hba, buf, count);
>>>>> +}
>>>>> +
>>>>> +static struct configfs_attribute ufshcd_attr_provision = {
>>>>> + .ca_name = "ufs_provision",
>>>>> + .ca_mode = 0644,
>>>>> + .ca_owner = THIS_MODULE,
>>>>> + .show = ufs_provision_show,
>>>>> + .store = ufs_provision_store,
>>>>> +};
>>>>> +
>>>>> +static struct configfs_attribute *ufshcd_attrs[] = {
>>>>> + &ufshcd_attr_provision,
>>>>> + NULL,
>>>>> +};
>>>>> +
>>>>> +static struct config_item_type ufscfg_type = {
>>>>> + .ct_attrs = ufshcd_attrs,
>>>>> + .ct_owner = THIS_MODULE,
>>>>> +};
>>>>> +
>>>>> +static struct configfs_subsystem ufscfg_subsys = {
>>>>> + .su_group = {
>>>>> + .cg_item = {
>>>>> + .ci_type = &ufscfg_type,
>>>>> + },
>>>>> + },
>>>>> +};
>>>>> +
>>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>>>>> +{
>>>>> + int ret;
>>>>> + struct configfs_subsystem *subsys = &hba->subsys;
>>>>> +
>>>>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name,
>>>>> strlen(name));
>>>>> + subsys->su_group = ufscfg_subsys.su_group;
>>>> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
>>>> you are not allowing for there being more than 1 hba
>>> Agree. I think I will have to move above
>>> declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h file
>>> (to make it per ufs hba/probe).
>>> Will check and update.
>>>>> + config_group_init(&subsys->su_group);
>>>>> + mutex_init(&subsys->su_mutex);
>>>>> + ret = configfs_register_subsystem(subsys);
>>>>> + if (ret)
>>>>> + pr_err("Error %d while registering subsystem %s\n",
>>>>> + ret,
>>>>> + subsys->su_group.cg_item.ci_namebuf);
>>>>> +}
>>>>> +
>>>>> +void ufshcd_configfs_exit(void)
>>>>> +{
>>>>> + configfs_unregister_subsystem(&ufscfg_subsys);
>>>>> +}
>>>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>>>> index e01cdc0..32a67b0 100644
>>>>> --- a/drivers/scsi/ufs/ufshcd.c
>>>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>>>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>>>>> void ufshcd_remove(struct ufs_hba *hba)
>>>>> {
>>>>> ufs_sysfs_remove_nodes(hba->dev);
>>>>> + ufshcd_configfs_exit();
>>>>> scsi_remove_host(hba->host);
>>>>> /* disable interrupts */
>>>>> ufshcd_disable_intr(hba, hba->intr_mask);
>>>>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
>>>>> *mmio_base, unsigned int irq)
>>>>> async_schedule(ufshcd_async_scan, hba);
>>>>> ufs_sysfs_add_nodes(hba->dev);
>>>>> -
>>>>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>>>>> return 0;
>>>>> out_remove_scsi_host:
>>>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>>>> index 45013b6..2275032 100644
>>>>> --- a/drivers/scsi/ufs/ufshcd.h
>>>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>>>> @@ -37,6 +37,7 @@
>>>>> #ifndef _UFSHCD_H
>>>>> #define _UFSHCD_H
>>>>> +#include <linux/configfs.h>
>>>>> #include <linux/module.h>
>>>>> #include <linux/kernel.h>
>>>>> #include <linux/init.h>
>>>>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>>>> struct Scsi_Host *host;
>>>>> struct device *dev;
>>>>> +#ifdef CONFIG_UFS_PROVISION
>>>>> + struct configfs_subsystem subsys;
>>>>> +#endif
>>>>> /*
>>>>> * This field is to keep a reference to "scsi_device"
>>>>> corresponding to
>>>>> * "UFS device" W-LU.
>>>>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int
>>>>> desc_index,
>>>>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>>>>> void ufshcd_release(struct ufs_hba *hba);
>>>>> +/* Expose UFS configfs API's */
>>>>> +#ifndef CONFIG_UFS_PROVISION
>>>>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char
>>>>> *name)
>>>>> +{
>>>>> +}
>>>>> +static inline void ufshcd_configfs_exit(void)
>>>>> +{
>>>>> +}
>>>>> +#else
>>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>>>>> +void ufshcd_configfs_exit(void);
>>>>> +#endif
>>>>> +
>>>>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn
>>>>> desc_id,
>>>>> int *desc_length);
>>>>>
>>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning
2018-08-28 12:06 ` Adrian Hunter
@ 2018-08-28 12:38 ` Sayali Lokhande
0 siblings, 0 replies; 9+ messages in thread
From: Sayali Lokhande @ 2018-08-28 12:38 UTC (permalink / raw)
To: Adrian Hunter, subhashj, cang, vivek.gautam, rnayak,
vinholikatti, jejb, martin.petersen, asutoshd, evgreen, riteshh
Cc: linux-scsi, open list
On 8/28/2018 5:36 PM, Adrian Hunter wrote:
> On 28/08/18 14:40, Sayali Lokhande wrote:
>> On 8/28/2018 4:56 PM, Adrian Hunter wrote:
>>> On 28/08/18 13:23, Sayali Lokhande wrote:
>>>> Hi Adrian,
>>>>
>>>> On 8/24/2018 2:15 PM, Adrian Hunter wrote:
>>>>> On 24/08/18 08:33, Sayali Lokhande wrote:
>>>>>> This patch adds configfs support to provision UFS device at
>>>>>> runtime. This feature can be primarily useful in factory or
>>>>>> assembly line as some devices may be required to be configured
>>>>>> multiple times during initial system development phase.
>>>>>> Configuration Descriptors can be written multiple times until
>>>>>> bConfigDescrLock attribute is zero.
>>>>>>
>>>>>> Configuration descriptor buffer consists of Device and Unit
>>>>>> descriptor configurable parameters which are parsed from vendor
>>>>>> specific provisioning file and then passed via configfs node at
>>>>>> runtime to provision ufs device.
>>>>>> CONFIG_CONFIGFS_FS needs to be enabled for using this feature.
>>>>>>
>>>>>> Usage:
>>>>>> 1) To read current configuration descriptor :
>>>>>> cat /config/XXXX.ufshc/ufs_provision
>>>>>> 2) To provision ufs device:
>>>>>> echo <config_desc_buf> > /config/XXXX.ufshc/ufs_provision
>>>>>>
>>>>>> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>>>>>> ---
>>>>>> Documentation/ABI/testing/configfs-driver-ufs | 18 +++
>>>>>> drivers/scsi/ufs/Kconfig | 10 ++
>>>>>> drivers/scsi/ufs/Makefile | 1 +
>>>>>> drivers/scsi/ufs/ufs-configfs.c | 155
>>>>>> ++++++++++++++++++++++++++
>>>>>> drivers/scsi/ufs/ufshcd.c | 3 +-
>>>>>> drivers/scsi/ufs/ufshcd.h | 17 +++
>>>>>> 6 files changed, 203 insertions(+), 1 deletion(-)
>>>>>> create mode 100644 Documentation/ABI/testing/configfs-driver-ufs
>>>>>> create mode 100644 drivers/scsi/ufs/ufs-configfs.c
>>>>>>
>>>>>> diff --git a/Documentation/ABI/testing/configfs-driver-ufs
>>>>>> b/Documentation/ABI/testing/configfs-driver-ufs
>>>>>> new file mode 100644
>>>>>> index 0000000..eeee499c
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/ABI/testing/configfs-driver-ufs
>>>>>> @@ -0,0 +1,18 @@
>>>>>> +What: /config/ufshcd/ufs_provision
>>>>> You are using the device name as the config subsystem name, so this is
>>>>> really:
>>>>>
>>>>> What: /config/*/ufs_provision
>>>> Agree. Will update.
>>>>>> +Date: Jun 2018
>>>>>> +KernelVersion: 4.14
>>>>> 4.19 maybe
>>>> Done.
>>>>>> +Description:
>>>>>> + This file shows the current ufs configuration descriptor set in
>>>>>> device.
>>>>> It is only the first config descriptor though isn't it? There is no
>>>>> support
>>>>> for the other 3. Shouldn't we support config descriptors fully?
>>>> Yes, we should support config descriptors fully. My current implementation
>>>> only supports config desc (index = 00h).
>>>> I m thinking I can add separate "index" field along with "ufs_provision"
>>>> field and can use this index (instead of hard coding to 0)
>>>> to write repective config_desc. In this way, we should first set the "index"
>>>> and then read/write to "ufs_provision".
>>>> Let me know if you have any concern with this approach ?
>>> One file for each config descriptor would seem more normal.
>> I can make separate file for each config descriptor index(say
>> ufs_provision_0/1/2/3), but still show() and store() api's can remain common.
>> Will try it out and update.
>>>>>> + This can be used to provision ufs device if bConfigDescrLock
>>>>>> is 0.
>>>>>> + For more details, refer 14.1.6.3 Configuration Descriptor and
>>>>>> + Table 14-12 - Unit Descriptor configurable parameters from specs
>>>>>> for
>>>>>> + description of each configuration descriptor parameter.
>>>>>> + Configuration descriptor buffer needs to be passed in space
>>>>>> separated
>>>>>> + format specificied as below:
>>>>> specificied -> specified
>>>> Done
>>>>>> + echo <bLength> <bDescriptorIDN> <bConfDescContinue> <bBootEnable>
>>>>>> + <bDescrAccessEn> <bInitPowerMode> <bHighPriorityLUN>
>>>>>> + <bSecureRemovalType> <bInitActiveICCLevel> <wPeriodicRTCUpdate>
>>>>>> + <0Bh:0Fh_ReservedAs_0> <bLUEnable> <bBootLunID> <bLUWriteProtect>
>>>>>> + <bMemoryType> <dNumAllocUnits> <bDataReliability>
>>>>>> <bLogicalBlockSize>
>>>>>> + <bProvisioningType> <wContextCapabilities> <0Dh:0Fh_ReservedAs_0>
>>>>> This format is not exactly correct anymore because each byte has to be
>>>>> represented separately. Also theoretically it can be change, so maybe
>>>>> better just to refer the user to the UFS specification.
>>>> Agree. Will update to just refer to UFS spec (for Config_desc format).
>>>>
>>>>>> + > /config/XXXX.ufshc/ufs_provision
>>>>>> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
>>>>>> index e27b4d4..a9a0a58 100644
>>>>>> --- a/drivers/scsi/ufs/Kconfig
>>>>>> +++ b/drivers/scsi/ufs/Kconfig
>>>>>> @@ -100,3 +100,13 @@ config SCSI_UFS_QCOM
>>>>>> Select this if you have UFS controller on QCOM chipset.
>>>>>> If unsure, say N.
>>>>>> +
>>>>>> +config UFS_PROVISION
>>>>>> + tristate "Runtime UFS Provisioning support"
>>>>>> + depends on SCSI_UFSHCD && CONFIGFS_FS
>>>>>> + help
>>>>>> + This enables runtime UFS provisioning support. This can be used
>>>>>> + primarily during assembly line as some devices may be required to
>>>>>> + be configured multiple times during initial development phase.
>>>>>> +
>>>>>> + If unsure, say N.
>>>>>> diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
>>>>>> index 918f579..00110ea 100644
>>>>>> --- a/drivers/scsi/ufs/Makefile
>>>>>> +++ b/drivers/scsi/ufs/Makefile
>>>>>> @@ -5,5 +5,6 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
>>>>>> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
>>>>>> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
>>>>>> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
>>>>>> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
>>>>>> +obj-$(CONFIG_UFS_PROVISION) += ufs-configfs.o
>>>>>> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
>>>>>> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
>>>>>> diff --git a/drivers/scsi/ufs/ufs-configfs.c
>>>>>> b/drivers/scsi/ufs/ufs-configfs.c
>>>>>> new file mode 100644
>>>>>> index 0000000..74563a4
>>>>>> --- /dev/null
>>>>>> +++ b/drivers/scsi/ufs/ufs-configfs.c
>>>>>> @@ -0,0 +1,155 @@
>>>>>> +// SPDX-License-Identifier: GPL-2.0+
>>>>>> +// Copyright (c) 2018, Linux Foundation.
>>>>>> +
>>>>>> +#include <linux/configfs.h>
>>>>>> +#include <linux/err.h>
>>>>>> +#include <linux/string.h>
>>>>>> +
>>>>>> +#include "ufs.h"
>>>>>> +#include "ufshcd.h"
>>>>>> +
>>>>>> +static inline struct ufs_hba *config_item_to_hba(struct config_item
>>>>>> *item)
>>>>>> +{
>>>>>> + struct config_group *group = to_config_group(item);
>>>>>> + struct configfs_subsystem *subsys = to_configfs_subsystem(group);
>>>>>> + struct ufs_hba *hba = container_of(subsys, struct ufs_hba, subsys);
>>>>>> +
>>>>>> + return subsys ? hba : NULL;
>>>>>> +}
>>>>>> +
>>>>>> +static ssize_t ufs_provision_show(struct config_item *item, char *buf)
>>>>>> +{
>>>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>>>> Is it really ok to hard-code the descriptor size?
>>>> I will use ufshcd_read_desc_length() api for each index as required. Will
>>>> remove this hard-code.
>>> Alternatively, I see there is already hba->desc_size.conf_desc
>> hba->desc_size.conf_desc is actually size for index 0. I thought what if
>> desc size various per index.
>> So better to read for each index. What say ?
> Based on the 'B' and 'L' values defined in the spec., all configuration
> descriptors have the same length.
Ok. Got it. Then I will just use "hba->desc_size.conf_desc" as desc length.
>>>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>>>> + int i, ret, curr_len = 0;
>>>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>>>> +
>>>>>> + ret = ufshcd_query_descriptor_retry(hba, UPIU_QUERY_OPCODE_READ_DESC,
>>>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>>>> +
>>>>>> + if (ret)
>>>>>> + return ret;
>>>>>> +
>>>>>> + for (i = 0; i < desc_buf_len; i++)
>>>>>> + curr_len += snprintf((buf + curr_len), (PAGE_SIZE - curr_len),
>>>>>> + "0x%x ", desc_buf[i]);
>>>>>> +
>>>>>> + return curr_len;
>>>>>> +}
>>>>>> +
>>>>>> +ssize_t ufshcd_desc_configfs_store(struct ufs_hba *hba,
>>>>>> + const char *buf, size_t count)
>>>>>> +{
>>>>>> + char *strbuf;
>>>>>> + char *strbuf_copy;
>>>>>> + u8 desc_buf[QUERY_DESC_CONFIGURATION_DEF_SIZE] = {0};
>>>>>> + int desc_buf_len = QUERY_DESC_CONFIGURATION_DEF_SIZE;
>>>>>> + char *token;
>>>>>> + int i, ret, value;
>>>>>> + u32 config_desc_lock = 0;
>>>>>> +
>>>>>> + /* reserve one byte for null termination */
>>>>>> + strbuf = kmalloc(count + 1, GFP_KERNEL);
>>>>>> + if (!strbuf)
>>>>>> + return -ENOMEM;
>>>>>> +
>>>>>> + strbuf_copy = strbuf;
>>>>>> + strlcpy(strbuf, buf, count + 1);
>>>>>> +
>>>>>> + /* Just return if bConfigDescrLock is already set */
>>>>>> + ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>>>>>> + QUERY_ATTR_IDN_CONF_DESC_LOCK, 0, 0, &config_desc_lock);
>>>>>> + if (ret)
>>>>>> + goto out;
>>>>>> +
>>>>>> + if (config_desc_lock) {
>>>>>> + dev_err(hba->dev, "%s: bConfigDescrLock already set to %u,
>>>>>> cannot re-provision device!\n",
>>>>>> + __func__, config_desc_lock);
>>>>>> + ret = -EINVAL;
>>>>>> + goto out;
>>>>>> + }
>>>>>> +
>>>>>> + for (i = 0; i < QUERY_DESC_CONFIGURATION_DEF_SIZE; i++) {
>>>>>> + token = strsep(&strbuf, " ");
>>>>>> + if (!token && i)
>>>>>> + break;
>>>>>> +
>>>>>> + ret = kstrtoint(token, 0, &value);
>>>>>> + if (ret) {
>>>>>> + dev_err(hba->dev, "%s: kstrtoint failed %d %s\n",
>>>>>> + __func__, ret, token);
>>>>>> + ret = -EINVAL;
>>>>>> + goto out;
>>>>>> + }
>>>>>> + desc_buf[i] = (u8)value;
>>>>>> + }
>>>>>> +
>>>>>> + /* Write configuration descriptor to provision ufs */
>>>>>> + ret = ufshcd_query_descriptor_retry(hba,
>>>>>> UPIU_QUERY_OPCODE_WRITE_DESC,
>>>>>> + QUERY_DESC_IDN_CONFIGURATION, 0, 0, desc_buf, &desc_buf_len);
>>>>>> +
>>>>>> + if (!ret)
>>>>>> + dev_info(hba->dev, "%s: UFS Provisioning done, reboot now!\n",
>>>>> That is not necessarily true - bConfDescContinue might have been used or
>>>>> bConfigDescrLock might need to be set. Better just to say that
>>>>> configuration descriptor 0 was written.
>>>> Agree. Will update.
>>>>>> + __func__);
>>>>>> +
>>>>>> +out:
>>>>>> + kfree(strbuf_copy);
>>>>>> + if (ret)
>>>>>> + return ret;
>>>>>> + return count;
>>>>>> +}
>>>>>> +
>>>>>> +static ssize_t ufs_provision_store(struct config_item *item,
>>>>>> + const char *buf, size_t count)
>>>>>> +{
>>>>>> + struct ufs_hba *hba = config_item_to_hba(item);
>>>>>> +
>>>>>> + return ufshcd_desc_configfs_store(hba, buf, count);
>>>>>> +}
>>>>>> +
>>>>>> +static struct configfs_attribute ufshcd_attr_provision = {
>>>>>> + .ca_name = "ufs_provision",
>>>>>> + .ca_mode = 0644,
>>>>>> + .ca_owner = THIS_MODULE,
>>>>>> + .show = ufs_provision_show,
>>>>>> + .store = ufs_provision_store,
>>>>>> +};
>>>>>> +
>>>>>> +static struct configfs_attribute *ufshcd_attrs[] = {
>>>>>> + &ufshcd_attr_provision,
>>>>>> + NULL,
>>>>>> +};
>>>>>> +
>>>>>> +static struct config_item_type ufscfg_type = {
>>>>>> + .ct_attrs = ufshcd_attrs,
>>>>>> + .ct_owner = THIS_MODULE,
>>>>>> +};
>>>>>> +
>>>>>> +static struct configfs_subsystem ufscfg_subsys = {
>>>>>> + .su_group = {
>>>>>> + .cg_item = {
>>>>>> + .ci_type = &ufscfg_type,
>>>>>> + },
>>>>>> + },
>>>>>> +};
>>>>>> +
>>>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name)
>>>>>> +{
>>>>>> + int ret;
>>>>>> + struct configfs_subsystem *subsys = &hba->subsys;
>>>>>> +
>>>>>> + strncpy(ufscfg_subsys.su_group.cg_item.ci_namebuf, name,
>>>>>> strlen(name));
>>>>>> + subsys->su_group = ufscfg_subsys.su_group;
>>>>> configfs_subsystem cannot share su_group with other configfs_subsystem i.e
>>>>> you are not allowing for there being more than 1 hba
>>>> Agree. I think I will have to move above
>>>> declarations(ufscfg_subsys/ufscfg_type/ufshcd_attrs) in driver .c/.h file
>>>> (to make it per ufs hba/probe).
>>>> Will check and update.
>>>>>> + config_group_init(&subsys->su_group);
>>>>>> + mutex_init(&subsys->su_mutex);
>>>>>> + ret = configfs_register_subsystem(subsys);
>>>>>> + if (ret)
>>>>>> + pr_err("Error %d while registering subsystem %s\n",
>>>>>> + ret,
>>>>>> + subsys->su_group.cg_item.ci_namebuf);
>>>>>> +}
>>>>>> +
>>>>>> +void ufshcd_configfs_exit(void)
>>>>>> +{
>>>>>> + configfs_unregister_subsystem(&ufscfg_subsys);
>>>>>> +}
>>>>>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>>>>>> index e01cdc0..32a67b0 100644
>>>>>> --- a/drivers/scsi/ufs/ufshcd.c
>>>>>> +++ b/drivers/scsi/ufs/ufshcd.c
>>>>>> @@ -7711,6 +7711,7 @@ int ufshcd_shutdown(struct ufs_hba *hba)
>>>>>> void ufshcd_remove(struct ufs_hba *hba)
>>>>>> {
>>>>>> ufs_sysfs_remove_nodes(hba->dev);
>>>>>> + ufshcd_configfs_exit();
>>>>>> scsi_remove_host(hba->host);
>>>>>> /* disable interrupts */
>>>>>> ufshcd_disable_intr(hba, hba->intr_mask);
>>>>>> @@ -7965,7 +7966,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
>>>>>> *mmio_base, unsigned int irq)
>>>>>> async_schedule(ufshcd_async_scan, hba);
>>>>>> ufs_sysfs_add_nodes(hba->dev);
>>>>>> -
>>>>>> + ufshcd_configfs_init(hba, dev_name(hba->dev));
>>>>>> return 0;
>>>>>> out_remove_scsi_host:
>>>>>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
>>>>>> index 45013b6..2275032 100644
>>>>>> --- a/drivers/scsi/ufs/ufshcd.h
>>>>>> +++ b/drivers/scsi/ufs/ufshcd.h
>>>>>> @@ -37,6 +37,7 @@
>>>>>> #ifndef _UFSHCD_H
>>>>>> #define _UFSHCD_H
>>>>>> +#include <linux/configfs.h>
>>>>>> #include <linux/module.h>
>>>>>> #include <linux/kernel.h>
>>>>>> #include <linux/init.h>
>>>>>> @@ -515,6 +516,9 @@ struct ufs_hba {
>>>>>> struct Scsi_Host *host;
>>>>>> struct device *dev;
>>>>>> +#ifdef CONFIG_UFS_PROVISION
>>>>>> + struct configfs_subsystem subsys;
>>>>>> +#endif
>>>>>> /*
>>>>>> * This field is to keep a reference to "scsi_device"
>>>>>> corresponding to
>>>>>> * "UFS device" W-LU.
>>>>>> @@ -868,6 +872,19 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int
>>>>>> desc_index,
>>>>>> int ufshcd_hold(struct ufs_hba *hba, bool async);
>>>>>> void ufshcd_release(struct ufs_hba *hba);
>>>>>> +/* Expose UFS configfs API's */
>>>>>> +#ifndef CONFIG_UFS_PROVISION
>>>>>> +static inline void ufshcd_configfs_init(struct ufs_hba *hba, const char
>>>>>> *name)
>>>>>> +{
>>>>>> +}
>>>>>> +static inline void ufshcd_configfs_exit(void)
>>>>>> +{
>>>>>> +}
>>>>>> +#else
>>>>>> +void ufshcd_configfs_init(struct ufs_hba *hba, const char *name);
>>>>>> +void ufshcd_configfs_exit(void);
>>>>>> +#endif
>>>>>> +
>>>>>> int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn
>>>>>> desc_id,
>>>>>> int *desc_length);
>>>>>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-08-28 12:38 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1535088810-20989-1-git-send-email-sayalil@codeaurora.org>
2018-08-24 5:33 ` [PATCH V10 1/2] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-08-24 5:33 ` [PATCH V10 2/2] scsi: ufs: Add configfs support for UFS provisioning Sayali Lokhande
2018-08-24 8:45 ` Adrian Hunter
2018-08-28 10:23 ` Sayali Lokhande
2018-08-28 10:50 ` Adrian Hunter
2018-08-28 11:26 ` Adrian Hunter
2018-08-28 11:40 ` Sayali Lokhande
2018-08-28 12:06 ` Adrian Hunter
2018-08-28 12:38 ` Sayali Lokhande
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).