* [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac
@ 2018-09-10 18:39 Neil Armstrong
2018-09-10 18:44 ` Martin Blumenstingl
2018-09-13 4:56 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-09-10 18:39 UTC (permalink / raw)
To: khilman; +Cc: Neil Armstrong, linux-amlogic, linux-arm-kernel, linux-kernel
Use the correct compatible for the AXG ethernet mac node.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 32f6dca..75f4ca7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -525,7 +525,7 @@
};
ethmac: ethernet@ff3f0000 {
- compatible = "amlogic,meson-gxbb-dwmac", "snps,dwmac";
+ compatible = "amlogic,meson-axg-dwmac", "snps,dwmac";
reg = <0x0 0xff3f0000 0x0 0x10000
0x0 0xff634540 0x0 0x8>;
interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac
2018-09-10 18:39 [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac Neil Armstrong
@ 2018-09-10 18:44 ` Martin Blumenstingl
2018-09-11 13:27 ` Neil Armstrong
2018-09-13 4:56 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Martin Blumenstingl @ 2018-09-10 18:44 UTC (permalink / raw)
To: Neil Armstrong; +Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
On Mon, Sep 10, 2018 at 8:39 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Use the correct compatible for the AXG ethernet mac node.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I wonder if you should add a "Fixes" tag. apart from that:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac
2018-09-10 18:44 ` Martin Blumenstingl
@ 2018-09-11 13:27 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2018-09-11 13:27 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: khilman, linux-amlogic, linux-kernel, linux-arm-kernel
On 10/09/2018 20:44, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:39 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Use the correct compatible for the AXG ethernet mac node.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I wonder if you should add a "Fixes" tag. apart from that:
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Hi Martin,
I'm not sure when the dwmac changes has been merged, and anyway the only board upstreamed uses RGMII which has the same bits for the glue register.
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac
2018-09-10 18:39 [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac Neil Armstrong
2018-09-10 18:44 ` Martin Blumenstingl
@ 2018-09-13 4:56 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2018-09-13 4:56 UTC (permalink / raw)
To: Neil Armstrong; +Cc: linux-amlogic, linux-arm-kernel, linux-kernel
Neil Armstrong <narmstrong@baylibre.com> writes:
> Use the correct compatible for the AXG ethernet mac node.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Applied to v4.20/dt64 with Martin's ack,
Thanks,
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-13 4:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 18:39 [PATCH] arm64: dts: meson-axg: use the proper compatible for ethmac Neil Armstrong
2018-09-10 18:44 ` Martin Blumenstingl
2018-09-11 13:27 ` Neil Armstrong
2018-09-13 4:56 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).