From: Dmitry Osipenko <digetx@gmail.com>
To: Yejune Deng <yejune.deng@gmail.com>,
balbi@kernel.org, gregkh@linuxfoundation.org,
p.zabel@pengutronix.de
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: Replace of_reset_control_array_get()
Date: Thu, 7 Jan 2021 22:33:00 +0300 [thread overview]
Message-ID: <49ee0444-4e0f-1dbe-c59a-74c72b34b140@gmail.com> (raw)
In-Reply-To: <1604395500-8086-1-git-send-email-yejune.deng@gmail.com>
03.11.2020 12:25, Yejune Deng пишет:
> of_reset_control_array_get_optional_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index e62ecd2..e358ff0 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -52,8 +52,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> simple->need_reset = true;
>
> - simple->resets = of_reset_control_array_get(np, false, true,
> - true);
> + simple->resets = of_reset_control_array_get_optional_exclusive(np);
> if (IS_ERR(simple->resets)) {
> ret = PTR_ERR(simple->resets);
> dev_err(dev, "failed to get device resets, err=%d\n", ret);
>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
prev parent reply other threads:[~2021-01-07 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 9:25 [PATCH] usb: dwc3: Replace of_reset_control_array_get() Yejune Deng
2021-01-07 19:33 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ee0444-4e0f-1dbe-c59a-74c72b34b140@gmail.com \
--to=digetx@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=yejune.deng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).