* [PATCH] Bluetooth: Remove trailing semicolon in macros
@ 2021-03-20 7:19 Meng Yu
2021-03-22 16:06 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Meng Yu @ 2021-03-20 7:19 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz
Cc: linux-bluetooth, wangzhou1, yumeng18, linux-kernel
1. remove trailing semicolon in macros;
2. fix some coding style.
Signed-off-by: Meng Yu <yumeng18@huawei.com>
---
net/bluetooth/smp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
index 26e8cfad..07a193e 100644
--- a/net/bluetooth/smp.c
+++ b/net/bluetooth/smp.c
@@ -55,7 +55,7 @@
#define SMP_ALLOW_CMD(smp, code) set_bit(code, &smp->allow_cmd)
/* Keys which are not distributed with Secure Connections */
-#define SMP_SC_NO_DIST (SMP_DIST_ENC_KEY | SMP_DIST_LINK_KEY);
+#define SMP_SC_NO_DIST (SMP_DIST_ENC_KEY | SMP_DIST_LINK_KEY)
#define SMP_TIMEOUT msecs_to_jiffies(30000)
@@ -403,7 +403,7 @@ static int smp_e(const u8 *k, u8 *r)
SMP_DBG("r %16phN", r);
- memzero_explicit(&ctx, sizeof (ctx));
+ memzero_explicit(&ctx, sizeof(ctx));
return err;
}
@@ -866,7 +866,7 @@ static int tk_request(struct l2cap_conn *conn, u8 remote_oob, u8 auth,
memset(smp->tk, 0, sizeof(smp->tk));
clear_bit(SMP_FLAG_TK_VALID, &smp->flags);
- BT_DBG("tk_request: auth:%d lcl:%d rem:%d", auth, local_io, remote_io);
+ BT_DBG("%s: auth:%d lcl:%d rem:%d", __func__, auth, local_io, remote_io);
/* If neither side wants MITM, either "just" confirm an incoming
* request or use just-works for outgoing ones. The JUST_CFM
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: Remove trailing semicolon in macros
2021-03-20 7:19 [PATCH] Bluetooth: Remove trailing semicolon in macros Meng Yu
@ 2021-03-22 16:06 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-03-22 16:06 UTC (permalink / raw)
To: Meng Yu
Cc: Johan Hedberg, Luiz Augusto von Dentz, linux-bluetooth,
wangzhou1, linux-kernel
Hi Meng,
> 1. remove trailing semicolon in macros;
> 2. fix some coding style.
>
> Signed-off-by: Meng Yu <yumeng18@huawei.com>
> ---
> net/bluetooth/smp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
the patch doesn’t apply to bluetooth-next, please re-base and send again.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-22 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-20 7:19 [PATCH] Bluetooth: Remove trailing semicolon in macros Meng Yu
2021-03-22 16:06 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).