* [PATCH 0/2] Regex fixes for mips and x86 cross-compile
@ 2021-07-08 8:57 H. Nikolaus Schaller
2021-07-08 8:57 ` [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp H. Nikolaus Schaller
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: H. Nikolaus Schaller @ 2021-07-08 8:57 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Nick Desaulniers
Cc: letux-kernel, H. Peter Anvin, linux-mips, linux-kernel, kernel,
H. Nikolaus Schaller
Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
compilation environment) leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
and when cross compiling a MIPS kernel on a BSD based HOSTCC
we get errors like
SYNC include/config/auto.conf.cmd - due to: .config
egrep: empty (sub)expression
UPD include/config/kernel.release
HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that relocs.c on x86 uses patterns like
"something(|_end)"
while MIPS uses egrep with
(|MINOR_|PATCHLEVEL_)
In both cases it is not valid syntax or gives undefined results
according to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regcmp() or egrep
implementation while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Test Linux:
root@letux:~# echo foo | egrep '^(|foo)$'
foo
root@letux:~# echo fool | egrep '^(foo)?$'
root@letux:~# echo fun | egrep '^(|foo)$'
root@letux:~# echo f | egrep '^(|foo)$'
root@letux:~# echo | egrep '^(|foo)$'
root@letux:~# echo foo | egrep '^(foo)?$'
foo
root@letux:~# echo fool | egrep '^(foo)?$'
root@letux:~# echo fun | egrep '^(foo)?$'
root@letux:~# echo f | egrep '^(foo)?$'
root@letux:~# echo | egrep '^(foo)?$'
root@letux:~#
Test BSD:
iMac:master hns$ echo foo | egrep '^(|foo)$'
egrep: empty (sub)expression
iMac:master hns$ echo fool | egrep '^(foo)?$'
egrep: empty (sub)expression
iMac:master hns$ echo fun | egrep '^(|foo)$'
egrep: empty (sub)expression
iMac:master hns$ echo f | egrep '^(|foo)$'
egrep: empty (sub)expression
iMac:master hns$ echo | egrep '^(|foo)$'
egrep: empty (sub)expression
iMac:master hns$ echo foo | egrep '^(foo)?$'
foo
iMac:master hns$ echo fool | egrep '^(foo)?$'
iMac:master hns$ echo fun | egrep '^(foo)?$'
iMac:master hns$ echo f | egrep '^(foo)?$'
iMac:master hns$ echo | egrep '^(foo)?$'
iMac:master hns$
H. Nikolaus Schaller (2):
x86/tools/relocs: Fix non-POSIX regexp
arch: mips: Fix non-POSIX regexp
arch/mips/Makefile | 2 +-
arch/x86/tools/relocs.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp
2021-07-08 8:57 [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
@ 2021-07-08 8:57 ` H. Nikolaus Schaller
2021-08-05 11:52 ` Masahiro Yamada
2021-07-08 8:57 ` [PATCH 2/2] arch: mips: " H. Nikolaus Schaller
2021-07-19 19:04 ` [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2 siblings, 1 reply; 9+ messages in thread
From: H. Nikolaus Schaller @ 2021-07-08 8:57 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Nick Desaulniers
Cc: letux-kernel, H. Peter Anvin, linux-mips, linux-kernel, kernel,
H. Nikolaus Schaller
Trying to run a cross-compiled x86 relocs tool on a BSD based
HOSTCC leads to errors like
VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
It turns out that relocs.c uses patterns like
"something(|_end)"
This is not valid syntax or gives undefined results according
to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux regexp() implementation
while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Fixes: fd952815307f ("x86-32, relocs: Whitelist more symbols for ld bug workaround")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
arch/x86/tools/relocs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index 04c5a44b96827..9ba700dc47de4 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -57,12 +57,12 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
[S_REL] =
"^(__init_(begin|end)|"
"__x86_cpu_dev_(start|end)|"
- "(__parainstructions|__alt_instructions)(|_end)|"
- "(__iommu_table|__apicdrivers|__smp_locks)(|_end)|"
+ "(__parainstructions|__alt_instructions)(_end)?|"
+ "(__iommu_table|__apicdrivers|__smp_locks)(_end)?|"
"__(start|end)_pci_.*|"
"__(start|end)_builtin_fw|"
- "__(start|stop)___ksymtab(|_gpl)|"
- "__(start|stop)___kcrctab(|_gpl)|"
+ "__(start|stop)___ksymtab(_gpl)?|"
+ "__(start|stop)___kcrctab(_gpl)?|"
"__(start|stop)___param|"
"__(start|stop)___modver|"
"__(start|stop)___bug_table|"
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp
2021-07-08 8:57 ` [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp H. Nikolaus Schaller
@ 2021-08-05 11:52 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2021-08-05 11:52 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, X86 ML, Jessica Yu, Miroslav Benes,
Emil Velikov, Nick Desaulniers,
Discussions about the Letux Kernel, H. Peter Anvin,
open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List,
kernel
On Thu, Jul 8, 2021 at 5:57 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Trying to run a cross-compiled x86 relocs tool on a BSD based
> HOSTCC leads to errors like
>
> VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
> CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
> OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
> RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
> empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
>
> It turns out that relocs.c uses patterns like
>
> "something(|_end)"
>
> This is not valid syntax or gives undefined results according
> to POSIX 9.5.3 ERE Grammar
>
> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
>
> It seems to be silently accepted by the Linux regexp() implementation
> while a BSD host complains.
>
> Such patterns can be replaced by a transformation like
>
> "(|p1|p2)" -> "(p1|p2)?"
>
> Fixes: fd952815307f ("x86-32, relocs: Whitelist more symbols for ld bug workaround")
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
Applied to linux-kbuild/fixes.
Thanks.
> arch/x86/tools/relocs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
> index 04c5a44b96827..9ba700dc47de4 100644
> --- a/arch/x86/tools/relocs.c
> +++ b/arch/x86/tools/relocs.c
> @@ -57,12 +57,12 @@ static const char * const sym_regex_kernel[S_NSYMTYPES] = {
> [S_REL] =
> "^(__init_(begin|end)|"
> "__x86_cpu_dev_(start|end)|"
> - "(__parainstructions|__alt_instructions)(|_end)|"
> - "(__iommu_table|__apicdrivers|__smp_locks)(|_end)|"
> + "(__parainstructions|__alt_instructions)(_end)?|"
> + "(__iommu_table|__apicdrivers|__smp_locks)(_end)?|"
> "__(start|end)_pci_.*|"
> "__(start|end)_builtin_fw|"
> - "__(start|stop)___ksymtab(|_gpl)|"
> - "__(start|stop)___kcrctab(|_gpl)|"
> + "__(start|stop)___ksymtab(_gpl)?|"
> + "__(start|stop)___kcrctab(_gpl)?|"
> "__(start|stop)___param|"
> "__(start|stop)___modver|"
> "__(start|stop)___bug_table|"
> --
> 2.31.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arch: mips: Fix non-POSIX regexp
2021-07-08 8:57 [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2021-07-08 8:57 ` [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp H. Nikolaus Schaller
@ 2021-07-08 8:57 ` H. Nikolaus Schaller
2021-08-05 11:53 ` Masahiro Yamada
2021-07-19 19:04 ` [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2 siblings, 1 reply; 9+ messages in thread
From: H. Nikolaus Schaller @ 2021-07-08 8:57 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Nick Desaulniers
Cc: letux-kernel, H. Peter Anvin, linux-mips, linux-kernel, kernel,
H. Nikolaus Schaller
When cross compiling a MIPS kernel on a BSD based HOSTCC leads
to errors like
SYNC include/config/auto.conf.cmd - due to: .config
egrep: empty (sub)expression
UPD include/config/kernel.release
HOSTCC scripts/dtc/dtc.o - due to target missing
It turns out that egrep uses this egrep pattern:
(|MINOR_|PATCHLEVEL_)
This is not valid syntax or gives undefined results according
to POSIX 9.5.3 ERE Grammar
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
It seems to be silently accepted by the Linux egrep implementation
while a BSD host complains.
Such patterns can be replaced by a transformation like
"(|p1|p2)" -> "(p1|p2)?"
Fixes: 48c35b2d245f ("[MIPS] There is no __GNUC_MAJOR__")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
arch/mips/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 258234c35a096..674f68d16a73f 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -321,7 +321,7 @@ KBUILD_LDFLAGS += -m $(ld-emul)
ifdef CONFIG_MIPS
CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
- egrep -vw '__GNUC_(|MINOR_|PATCHLEVEL_)_' | \
+ egrep -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
endif
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] arch: mips: Fix non-POSIX regexp
2021-07-08 8:57 ` [PATCH 2/2] arch: mips: " H. Nikolaus Schaller
@ 2021-08-05 11:53 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2021-08-05 11:53 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, X86 ML, Jessica Yu, Miroslav Benes,
Emil Velikov, Nick Desaulniers,
Discussions about the Letux Kernel, H. Peter Anvin,
open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List,
kernel
On Thu, Jul 8, 2021 at 5:57 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> When cross compiling a MIPS kernel on a BSD based HOSTCC leads
> to errors like
>
> SYNC include/config/auto.conf.cmd - due to: .config
> egrep: empty (sub)expression
> UPD include/config/kernel.release
> HOSTCC scripts/dtc/dtc.o - due to target missing
>
> It turns out that egrep uses this egrep pattern:
>
> (|MINOR_|PATCHLEVEL_)
>
> This is not valid syntax or gives undefined results according
> to POSIX 9.5.3 ERE Grammar
>
> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
>
> It seems to be silently accepted by the Linux egrep implementation
> while a BSD host complains.
>
> Such patterns can be replaced by a transformation like
>
> "(|p1|p2)" -> "(p1|p2)?"
>
> Fixes: 48c35b2d245f ("[MIPS] There is no __GNUC_MAJOR__")
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
Applied to linux-kbuild/fixes.
Thanks.
> arch/mips/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 258234c35a096..674f68d16a73f 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -321,7 +321,7 @@ KBUILD_LDFLAGS += -m $(ld-emul)
>
> ifdef CONFIG_MIPS
> CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
> - egrep -vw '__GNUC_(|MINOR_|PATCHLEVEL_)_' | \
> + egrep -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
> sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
> endif
>
> --
> 2.31.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Regex fixes for mips and x86 cross-compile
2021-07-08 8:57 [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2021-07-08 8:57 ` [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp H. Nikolaus Schaller
2021-07-08 8:57 ` [PATCH 2/2] arch: mips: " H. Nikolaus Schaller
@ 2021-07-19 19:04 ` H. Nikolaus Schaller
2021-07-19 20:37 ` Nick Desaulniers
2 siblings, 1 reply; 9+ messages in thread
From: H. Nikolaus Schaller @ 2021-07-19 19:04 UTC (permalink / raw)
To: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Nick Desaulniers
Cc: Discussions about the Letux Kernel, H. Peter Anvin, linux-mips,
linux-kernel, kernel
Any chance that it gets merged?
> Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>
> Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
> compilation environment) leads to errors like
>
> VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
> CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
> OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
> RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
> empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
>
> and when cross compiling a MIPS kernel on a BSD based HOSTCC
> we get errors like
>
> SYNC include/config/auto.conf.cmd - due to: .config
> egrep: empty (sub)expression
> UPD include/config/kernel.release
> HOSTCC scripts/dtc/dtc.o - due to target missing
>
> It turns out that relocs.c on x86 uses patterns like
>
> "something(|_end)"
>
> while MIPS uses egrep with
>
> (|MINOR_|PATCHLEVEL_)
>
> In both cases it is not valid syntax or gives undefined results
> according to POSIX 9.5.3 ERE Grammar
>
> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
>
> It seems to be silently accepted by the Linux regcmp() or egrep
> implementation while a BSD host complains.
>
> Such patterns can be replaced by a transformation like
>
> "(|p1|p2)" -> "(p1|p2)?"
>
> Test Linux:
>
> root@letux:~# echo foo | egrep '^(|foo)$'
> foo
> root@letux:~# echo fool | egrep '^(foo)?$'
> root@letux:~# echo fun | egrep '^(|foo)$'
> root@letux:~# echo f | egrep '^(|foo)$'
> root@letux:~# echo | egrep '^(|foo)$'
>
> root@letux:~# echo foo | egrep '^(foo)?$'
> foo
> root@letux:~# echo fool | egrep '^(foo)?$'
> root@letux:~# echo fun | egrep '^(foo)?$'
> root@letux:~# echo f | egrep '^(foo)?$'
> root@letux:~# echo | egrep '^(foo)?$'
>
> root@letux:~#
>
> Test BSD:
>
> iMac:master hns$ echo foo | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo fool | egrep '^(foo)?$'
> egrep: empty (sub)expression
> iMac:master hns$ echo fun | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo f | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo | egrep '^(|foo)$'
> egrep: empty (sub)expression
> iMac:master hns$ echo foo | egrep '^(foo)?$'
> foo
> iMac:master hns$ echo fool | egrep '^(foo)?$'
> iMac:master hns$ echo fun | egrep '^(foo)?$'
> iMac:master hns$ echo f | egrep '^(foo)?$'
> iMac:master hns$ echo | egrep '^(foo)?$'
>
> iMac:master hns$
>
>
> H. Nikolaus Schaller (2):
> x86/tools/relocs: Fix non-POSIX regexp
> arch: mips: Fix non-POSIX regexp
>
> arch/mips/Makefile | 2 +-
> arch/x86/tools/relocs.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Regex fixes for mips and x86 cross-compile
2021-07-19 19:04 ` [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
@ 2021-07-19 20:37 ` Nick Desaulniers
2021-08-03 15:58 ` H. Nikolaus Schaller
0 siblings, 1 reply; 9+ messages in thread
From: Nick Desaulniers @ 2021-07-19 20:37 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Discussions about the Letux Kernel, H. Peter Anvin, linux-mips,
linux-kernel, kernel, Masahiro Yamada, Linux Kbuild mailing list
+ Masahiro, linux-kbuild (EOM)
On Mon, Jul 19, 2021 at 12:07 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Any chance that it gets merged?
>
> > Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
> >
> > Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
> > compilation environment) leads to errors like
> >
> > VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
> > CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
> > OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
> > RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
> > empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> > make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
> >
> > and when cross compiling a MIPS kernel on a BSD based HOSTCC
> > we get errors like
> >
> > SYNC include/config/auto.conf.cmd - due to: .config
> > egrep: empty (sub)expression
> > UPD include/config/kernel.release
> > HOSTCC scripts/dtc/dtc.o - due to target missing
> >
> > It turns out that relocs.c on x86 uses patterns like
> >
> > "something(|_end)"
> >
> > while MIPS uses egrep with
> >
> > (|MINOR_|PATCHLEVEL_)
> >
> > In both cases it is not valid syntax or gives undefined results
> > according to POSIX 9.5.3 ERE Grammar
> >
> > https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
> >
> > It seems to be silently accepted by the Linux regcmp() or egrep
> > implementation while a BSD host complains.
> >
> > Such patterns can be replaced by a transformation like
> >
> > "(|p1|p2)" -> "(p1|p2)?"
> >
> > Test Linux:
> >
> > root@letux:~# echo foo | egrep '^(|foo)$'
> > foo
> > root@letux:~# echo fool | egrep '^(foo)?$'
> > root@letux:~# echo fun | egrep '^(|foo)$'
> > root@letux:~# echo f | egrep '^(|foo)$'
> > root@letux:~# echo | egrep '^(|foo)$'
> >
> > root@letux:~# echo foo | egrep '^(foo)?$'
> > foo
> > root@letux:~# echo fool | egrep '^(foo)?$'
> > root@letux:~# echo fun | egrep '^(foo)?$'
> > root@letux:~# echo f | egrep '^(foo)?$'
> > root@letux:~# echo | egrep '^(foo)?$'
> >
> > root@letux:~#
> >
> > Test BSD:
> >
> > iMac:master hns$ echo foo | egrep '^(|foo)$'
> > egrep: empty (sub)expression
> > iMac:master hns$ echo fool | egrep '^(foo)?$'
> > egrep: empty (sub)expression
> > iMac:master hns$ echo fun | egrep '^(|foo)$'
> > egrep: empty (sub)expression
> > iMac:master hns$ echo f | egrep '^(|foo)$'
> > egrep: empty (sub)expression
> > iMac:master hns$ echo | egrep '^(|foo)$'
> > egrep: empty (sub)expression
> > iMac:master hns$ echo foo | egrep '^(foo)?$'
> > foo
> > iMac:master hns$ echo fool | egrep '^(foo)?$'
> > iMac:master hns$ echo fun | egrep '^(foo)?$'
> > iMac:master hns$ echo f | egrep '^(foo)?$'
> > iMac:master hns$ echo | egrep '^(foo)?$'
> >
> > iMac:master hns$
> >
> >
> > H. Nikolaus Schaller (2):
> > x86/tools/relocs: Fix non-POSIX regexp
> > arch: mips: Fix non-POSIX regexp
> >
> > arch/mips/Makefile | 2 +-
> > arch/x86/tools/relocs.c | 8 ++++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > --
> > 2.31.1
> >
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Regex fixes for mips and x86 cross-compile
2021-07-19 20:37 ` Nick Desaulniers
@ 2021-08-03 15:58 ` H. Nikolaus Schaller
2021-08-05 11:54 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: H. Nikolaus Schaller @ 2021-08-03 15:58 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, x86, Jessica Yu, Miroslav Benes, Emil Velikov,
Discussions about the Letux Kernel, H. Peter Anvin, linux-mips,
Linux Kernel Mailing List, kernel, Linux Kbuild mailing list,
Nick Desaulniers
Hi all,
any chance to get that reviewed and merged into v5.15-rc1 and backported to stable?
Thank you,
Nikolaus Schaller
> Am 19.07.2021 um 22:37 schrieb Nick Desaulniers <ndesaulniers@google.com>:
>
> + Masahiro, linux-kbuild (EOM)
>
> On Mon, Jul 19, 2021 at 12:07 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>>
>> Any chance that it gets merged?
>>
>>> Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>>
>>> Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
>>> compilation environment) leads to errors like
>>>
>>> VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
>>> CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
>>> OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
>>> RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
>>> empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
>>> make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
>>>
>>> and when cross compiling a MIPS kernel on a BSD based HOSTCC
>>> we get errors like
>>>
>>> SYNC include/config/auto.conf.cmd - due to: .config
>>> egrep: empty (sub)expression
>>> UPD include/config/kernel.release
>>> HOSTCC scripts/dtc/dtc.o - due to target missing
>>>
>>> It turns out that relocs.c on x86 uses patterns like
>>>
>>> "something(|_end)"
>>>
>>> while MIPS uses egrep with
>>>
>>> (|MINOR_|PATCHLEVEL_)
>>>
>>> In both cases it is not valid syntax or gives undefined results
>>> according to POSIX 9.5.3 ERE Grammar
>>>
>>> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
>>>
>>> It seems to be silently accepted by the Linux regcmp() or egrep
>>> implementation while a BSD host complains.
>>>
>>> Such patterns can be replaced by a transformation like
>>>
>>> "(|p1|p2)" -> "(p1|p2)?"
>>>
>>> Test Linux:
>>>
>>> root@letux:~# echo foo | egrep '^(|foo)$'
>>> foo
>>> root@letux:~# echo fool | egrep '^(foo)?$'
>>> root@letux:~# echo fun | egrep '^(|foo)$'
>>> root@letux:~# echo f | egrep '^(|foo)$'
>>> root@letux:~# echo | egrep '^(|foo)$'
>>>
>>> root@letux:~# echo foo | egrep '^(foo)?$'
>>> foo
>>> root@letux:~# echo fool | egrep '^(foo)?$'
>>> root@letux:~# echo fun | egrep '^(foo)?$'
>>> root@letux:~# echo f | egrep '^(foo)?$'
>>> root@letux:~# echo | egrep '^(foo)?$'
>>>
>>> root@letux:~#
>>>
>>> Test BSD:
>>>
>>> iMac:master hns$ echo foo | egrep '^(|foo)$'
>>> egrep: empty (sub)expression
>>> iMac:master hns$ echo fool | egrep '^(foo)?$'
>>> egrep: empty (sub)expression
>>> iMac:master hns$ echo fun | egrep '^(|foo)$'
>>> egrep: empty (sub)expression
>>> iMac:master hns$ echo f | egrep '^(|foo)$'
>>> egrep: empty (sub)expression
>>> iMac:master hns$ echo | egrep '^(|foo)$'
>>> egrep: empty (sub)expression
>>> iMac:master hns$ echo foo | egrep '^(foo)?$'
>>> foo
>>> iMac:master hns$ echo fool | egrep '^(foo)?$'
>>> iMac:master hns$ echo fun | egrep '^(foo)?$'
>>> iMac:master hns$ echo f | egrep '^(foo)?$'
>>> iMac:master hns$ echo | egrep '^(foo)?$'
>>>
>>> iMac:master hns$
>>>
>>>
>>> H. Nikolaus Schaller (2):
>>> x86/tools/relocs: Fix non-POSIX regexp
>>> arch: mips: Fix non-POSIX regexp
>>>
>>> arch/mips/Makefile | 2 +-
>>> arch/x86/tools/relocs.c | 8 ++++----
>>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> --
>>> 2.31.1
>>>
>>
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] Regex fixes for mips and x86 cross-compile
2021-08-03 15:58 ` H. Nikolaus Schaller
@ 2021-08-05 11:54 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2021-08-05 11:54 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Thomas Bogendoerfer, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, X86 ML, Jessica Yu, Miroslav Benes,
Emil Velikov, Discussions about the Letux Kernel, H. Peter Anvin,
linux-mips, Linux Kernel Mailing List, kernel,
Linux Kbuild mailing list, Nick Desaulniers
On Wed, Aug 4, 2021 at 12:59 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Hi all,
> any chance to get that reviewed and merged into v5.15-rc1 and backported to stable?
> Thank you,
> Nikolaus Schaller
I have a macbook (macOS catalina), and was able to
reproduce this issue.
I applied both to kbuild tree.
Thanks.
>
> > Am 19.07.2021 um 22:37 schrieb Nick Desaulniers <ndesaulniers@google.com>:
> >
> > + Masahiro, linux-kbuild (EOM)
> >
> > On Mon, Jul 19, 2021 at 12:07 PM H. Nikolaus Schaller <hns@goldelico.com> wrote:
> >>
> >> Any chance that it gets merged?
> >>
> >>> Am 08.07.2021 um 10:57 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
> >>>
> >>> Trying to run the x86 relocs tool on a BSD based HOSTCC (cross
> >>> compilation environment) leads to errors like
> >>>
> >>> VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
> >>> CC arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
> >>> OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
> >>> RELOCS arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
> >>> empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
> >>> make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1
> >>>
> >>> and when cross compiling a MIPS kernel on a BSD based HOSTCC
> >>> we get errors like
> >>>
> >>> SYNC include/config/auto.conf.cmd - due to: .config
> >>> egrep: empty (sub)expression
> >>> UPD include/config/kernel.release
> >>> HOSTCC scripts/dtc/dtc.o - due to target missing
> >>>
> >>> It turns out that relocs.c on x86 uses patterns like
> >>>
> >>> "something(|_end)"
> >>>
> >>> while MIPS uses egrep with
> >>>
> >>> (|MINOR_|PATCHLEVEL_)
> >>>
> >>> In both cases it is not valid syntax or gives undefined results
> >>> according to POSIX 9.5.3 ERE Grammar
> >>>
> >>> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
> >>>
> >>> It seems to be silently accepted by the Linux regcmp() or egrep
> >>> implementation while a BSD host complains.
> >>>
> >>> Such patterns can be replaced by a transformation like
> >>>
> >>> "(|p1|p2)" -> "(p1|p2)?"
> >>>
> >>> Test Linux:
> >>>
> >>> root@letux:~# echo foo | egrep '^(|foo)$'
> >>> foo
> >>> root@letux:~# echo fool | egrep '^(foo)?$'
> >>> root@letux:~# echo fun | egrep '^(|foo)$'
> >>> root@letux:~# echo f | egrep '^(|foo)$'
> >>> root@letux:~# echo | egrep '^(|foo)$'
> >>>
> >>> root@letux:~# echo foo | egrep '^(foo)?$'
> >>> foo
> >>> root@letux:~# echo fool | egrep '^(foo)?$'
> >>> root@letux:~# echo fun | egrep '^(foo)?$'
> >>> root@letux:~# echo f | egrep '^(foo)?$'
> >>> root@letux:~# echo | egrep '^(foo)?$'
> >>>
> >>> root@letux:~#
> >>>
> >>> Test BSD:
> >>>
> >>> iMac:master hns$ echo foo | egrep '^(|foo)$'
> >>> egrep: empty (sub)expression
> >>> iMac:master hns$ echo fool | egrep '^(foo)?$'
> >>> egrep: empty (sub)expression
> >>> iMac:master hns$ echo fun | egrep '^(|foo)$'
> >>> egrep: empty (sub)expression
> >>> iMac:master hns$ echo f | egrep '^(|foo)$'
> >>> egrep: empty (sub)expression
> >>> iMac:master hns$ echo | egrep '^(|foo)$'
> >>> egrep: empty (sub)expression
> >>> iMac:master hns$ echo foo | egrep '^(foo)?$'
> >>> foo
> >>> iMac:master hns$ echo fool | egrep '^(foo)?$'
> >>> iMac:master hns$ echo fun | egrep '^(foo)?$'
> >>> iMac:master hns$ echo f | egrep '^(foo)?$'
> >>> iMac:master hns$ echo | egrep '^(foo)?$'
> >>>
> >>> iMac:master hns$
> >>>
> >>>
> >>> H. Nikolaus Schaller (2):
> >>> x86/tools/relocs: Fix non-POSIX regexp
> >>> arch: mips: Fix non-POSIX regexp
> >>>
> >>> arch/mips/Makefile | 2 +-
> >>> arch/x86/tools/relocs.c | 8 ++++----
> >>> 2 files changed, 5 insertions(+), 5 deletions(-)
> >>>
> >>> --
> >>> 2.31.1
> >>>
> >>
> >
> >
> > --
> > Thanks,
> > ~Nick Desaulniers
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-08-05 11:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 8:57 [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2021-07-08 8:57 ` [PATCH 1/2] x86/tools/relocs: Fix non-POSIX regexp H. Nikolaus Schaller
2021-08-05 11:52 ` Masahiro Yamada
2021-07-08 8:57 ` [PATCH 2/2] arch: mips: " H. Nikolaus Schaller
2021-08-05 11:53 ` Masahiro Yamada
2021-07-19 19:04 ` [PATCH 0/2] Regex fixes for mips and x86 cross-compile H. Nikolaus Schaller
2021-07-19 20:37 ` Nick Desaulniers
2021-08-03 15:58 ` H. Nikolaus Schaller
2021-08-05 11:54 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).