* [PATCH] fs/ext4: test the i_flags field of the right structure
@ 2009-11-02 20:58 Julia Lawall
2009-11-02 21:22 ` Eric Sandeen
2009-11-15 1:53 ` Theodore Tso
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2009-11-02 20:58 UTC (permalink / raw)
To: sandeen, cmm, Theodore Ts'o, Andreas Dilger, linux-ext4,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
than inode->i_flags.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
fs/ext4/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 5c5bc5d..c0e34ab 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2787,7 +2787,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode)
* number of contiguous block. So we will limit
* number of contiguous block to a sane value
*/
- if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
+ if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) &&
(max_blocks > EXT4_MAX_TRANS_DATA))
max_blocks = EXT4_MAX_TRANS_DATA;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ext4: test the i_flags field of the right structure
2009-11-02 20:58 [PATCH] fs/ext4: test the i_flags field of the right structure Julia Lawall
@ 2009-11-02 21:22 ` Eric Sandeen
2009-11-15 1:53 ` Theodore Tso
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2009-11-02 21:22 UTC (permalink / raw)
To: Julia Lawall
Cc: cmm, Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel,
kernel-janitors
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
> than inode->i_flags.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> ---
> fs/ext4/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 5c5bc5d..c0e34ab 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2787,7 +2787,7 @@ static int ext4_da_writepages_trans_blocks(struct inode *inode)
> * number of contiguous block. So we will limit
> * number of contiguous block to a sane value
> */
> - if (!(inode->i_flags & EXT4_EXTENTS_FL) &&
> + if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) &&
> (max_blocks > EXT4_MAX_TRANS_DATA))
> max_blocks = EXT4_MAX_TRANS_DATA;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ext4: test the i_flags field of the right structure
2009-11-02 20:58 [PATCH] fs/ext4: test the i_flags field of the right structure Julia Lawall
2009-11-02 21:22 ` Eric Sandeen
@ 2009-11-15 1:53 ` Theodore Tso
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Tso @ 2009-11-15 1:53 UTC (permalink / raw)
To: Julia Lawall
Cc: sandeen, cmm, Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors
On Mon, Nov 02, 2009 at 09:58:47PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, EXT4_EXTENTS_FL is combined with EXT4_I(inode)->i_flags, rather
> than inode->i_flags.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied to the ext4 patch queue, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-15 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-02 20:58 [PATCH] fs/ext4: test the i_flags field of the right structure Julia Lawall
2009-11-02 21:22 ` Eric Sandeen
2009-11-15 1:53 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).