* [PATCH v4l/dvb] firedtv: add forgotten __exit annotation
@ 2009-12-26 0:45 Stefan Richter
2010-01-10 15:12 ` Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Richter @ 2009-12-26 0:45 UTC (permalink / raw)
To: linux-media; +Cc: linux1394-devel, linux-kernel
fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/media/dvb/firewire/firedtv-fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
===================================================================
--- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
+++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
@@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
return driver_register(&fdtv_driver.driver);
}
-void fdtv_fw_exit(void)
+void __exit fdtv_fw_exit(void)
{
driver_unregister(&fdtv_driver.driver);
fw_core_remove_address_handler(&fcp_handler);
--
Stefan Richter
-=====-==--= ==-- ==-=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation
2009-12-26 0:45 [PATCH v4l/dvb] firedtv: add forgotten __exit annotation Stefan Richter
@ 2010-01-10 15:12 ` Stefan Richter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2010-01-10 15:12 UTC (permalink / raw)
To: linux-media; +Cc: linux1394-devel, linux-kernel
Stefan Richter wrote on 2009-12-26:
> fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
...
> --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
> +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
> @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
> return driver_register(&fdtv_driver.driver);
> }
>
> -void fdtv_fw_exit(void)
> +void __exit fdtv_fw_exit(void)
> {
> driver_unregister(&fdtv_driver.driver);
> fw_core_remove_address_handler(&fcp_handler);
>
This patch is bogus. fdtv_fw_exit() is also called from firedtv's init.
--
Stefan Richter
-=====-==-=- ---= -=-=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-10 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-26 0:45 [PATCH v4l/dvb] firedtv: add forgotten __exit annotation Stefan Richter
2010-01-10 15:12 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).