* [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev()
@ 2010-01-17 15:15 Roel Kluin
2010-01-19 22:40 ` James Smart
2010-01-19 22:41 ` James Smart
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2010-01-17 15:15 UTC (permalink / raw)
To: James Smart, linux-scsi, Andrew Morton, LKML
Regardless of the flag state, the branches execute the same code
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/scsi/lpfc/lpfc_ct.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 0ebcd9b..bf7bf62 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -1843,12 +1843,7 @@ lpfc_decode_firmware_rev(struct lpfc_hba *phba, char *fwrevision, int flag)
c = (rev & 0x0000ff00) >> 8;
b4 = (rev & 0x000000ff);
- if (flag)
- sprintf(fwrevision, "%d.%d%d%c%d ", b1,
- b2, b3, c, b4);
- else
- sprintf(fwrevision, "%d.%d%d%c%d ", b1,
- b2, b3, c, b4);
+ sprintf(fwrevision, "%d.%d%d%c%d", b1, b2, b3, c, b4);
}
return;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev()
2010-01-17 15:15 [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev() Roel Kluin
@ 2010-01-19 22:40 ` James Smart
2010-01-19 22:41 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2010-01-19 22:40 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-scsi, Andrew Morton, LKML
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Roel Kluin wrote:
> Regardless of the flag state, the branches execute the same code
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 0ebcd9b..bf7bf62 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -1843,12 +1843,7 @@ lpfc_decode_firmware_rev(struct lpfc_hba *phba, char *fwrevision, int flag)
> c = (rev & 0x0000ff00) >> 8;
> b4 = (rev & 0x000000ff);
>
> - if (flag)
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> - else
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> + sprintf(fwrevision, "%d.%d%d%c%d", b1, b2, b3, c, b4);
> }
> return;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev()
2010-01-17 15:15 [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev() Roel Kluin
2010-01-19 22:40 ` James Smart
@ 2010-01-19 22:41 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2010-01-19 22:41 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-scsi, Andrew Morton, LKML
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Roel Kluin wrote:
> Regardless of the flag state, the branches execute the same code
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 0ebcd9b..bf7bf62 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -1843,12 +1843,7 @@ lpfc_decode_firmware_rev(struct lpfc_hba *phba, char *fwrevision, int flag)
> c = (rev & 0x0000ff00) >> 8;
> b4 = (rev & 0x000000ff);
>
> - if (flag)
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> - else
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> + sprintf(fwrevision, "%d.%d%d%c%d", b1, b2, b3, c, b4);
> }
> return;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-19 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-17 15:15 [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev() Roel Kluin
2010-01-19 22:40 ` James Smart
2010-01-19 22:41 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).